Example: https://luci-milo.appspot.com/buildbot/chromeos/elm-paladin/3527 Likely culprit: https://chromium-review.googlesource.com/567328 However, a simple revert is not enough, we need a push to prod as well. P1 as unclear if this is intermittent or consistent. Could be that it only happens with the suite_attr_wrapper suite.
Actually, I take it back, reverting should be sufficient. Reverting it now.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a11346cafeb0cfa252afc3de096c9bb7ee192cd9 commit a11346cafeb0cfa252afc3de096c9bb7ee192cd9 Author: Aviv Keshet <akeshet@chromium.org> Date: Fri Jul 28 08:04:04 2017 Revert "[autotest] Add num control to provision suite" This reverts commit a4656a265443f474efde7a31a02d302e8d956f91. BUG= chromium:749971 , chromium:672348 TEST=None Change-Id: I409f8220a8923b9c5cc1127afcd0a2b46f0c61af Reviewed-on: https://chromium-review.googlesource.com/590934 Reviewed-by: Aviv Keshet <akeshet@chromium.org> Tested-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/a11346cafeb0cfa252afc3de096c9bb7ee192cd9/server/cros/dynamic_suite/suite.py [modify] https://crrev.com/a11346cafeb0cfa252afc3de096c9bb7ee192cd9/test_suites/control.suite_attr_wrapper [modify] https://crrev.com/a11346cafeb0cfa252afc3de096c9bb7ee192cd9/server/cros/dynamic_suite/dynamic_suite.py [modify] https://crrev.com/a11346cafeb0cfa252afc3de096c9bb7ee192cd9/frontend/afe/rpc_interface.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9bf04b6bd7dbd4c2a765e5bce3bac46bd0511564 commit 9bf04b6bd7dbd4c2a765e5bce3bac46bd0511564 Author: Aviv Keshet <akeshet@chromium.org> Date: Fri Jul 28 08:04:31 2017 Revert "[autotest] Factor out suite_args evaluation." This reverts commit 91f1ddd486eaf78fbfbd3469091f0023b98609f0. BUG= chromium:749971 , chromium:672348 TEST=None Change-Id: I02bf08d33e09c9c27422aecefce404d7826728fa Reviewed-on: https://chromium-review.googlesource.com/590935 Reviewed-by: Aviv Keshet <akeshet@chromium.org> Tested-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/9bf04b6bd7dbd4c2a765e5bce3bac46bd0511564/test_suites/control.suite_attr_wrapper [modify] https://crrev.com/9bf04b6bd7dbd4c2a765e5bce3bac46bd0511564/frontend/afe/rpc_interface.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/968e768cdbe91dba06998210965f190b1dd94c99 commit 968e768cdbe91dba06998210965f190b1dd94c99 Author: Aviv Keshet <akeshet@chromium.org> Date: Fri Jul 28 08:13:50 2017 Revert "[autotest] Pre-evaluate suite_args" This reverts commit 913e0ffdadd50e1df3d1f774f0cfee4a069c0b19. BUG= chromium:749971 , chromium:672348 TEST=None Change-Id: I66248a6e8c43c9182ce09b8e0c3b7bd804a05c72 Reviewed-on: https://chromium-review.googlesource.com/590937 Reviewed-by: Aviv Keshet <akeshet@chromium.org> Tested-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/968e768cdbe91dba06998210965f190b1dd94c99/site_utils/run_suite.py [modify] https://crrev.com/968e768cdbe91dba06998210965f190b1dd94c99/site_utils/run_suite_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bab86262598a207a5187721fc4c5e390780a5169 commit bab86262598a207a5187721fc4c5e390780a5169 Author: Aviv Keshet <akeshet@chromium.org> Date: Fri Jul 28 08:14:17 2017 Revert "[autotest] Add special provision suite failure handling" This reverts commit bf1a4f3ac73cea9eeb3f69275606dae0b545bd8d. BUG= chromium:749971 , chromium:672348 TEST=None Change-Id: Ic2b06a524d9c3bd35f0160cf0f9c8ba1ac92226e Reviewed-on: https://chromium-review.googlesource.com/590938 Reviewed-by: Aviv Keshet <akeshet@chromium.org> Tested-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/bab86262598a207a5187721fc4c5e390780a5169/site_utils/run_suite.py
Issue 750225 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ecdba6c4adf7064c6d041f33bafcbde38e62cd1e commit ecdba6c4adf7064c6d041f33bafcbde38e62cd1e Author: Allen Li <ayatane@chromium.org> Date: Fri Aug 11 05:47:20 2017 [autotest] Pre-evaluate suite_args (reland) See dependent CL. Also, remove old regression tests. suite_args has changed and now takes a dict, so the original regression bug is no longer relevant, and I do not see a good way to preserve the regression test. BUG= chromium:672348 BUG= chromium:749971 TEST=None CQ-DEPEND=CL:567328 Change-Id: Ib268c9a124f9b2242b1f6f1db46e645eb450825a Reviewed-on: https://chromium-review.googlesource.com/591884 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/ecdba6c4adf7064c6d041f33bafcbde38e62cd1e/site_utils/run_suite.py [modify] https://crrev.com/ecdba6c4adf7064c6d041f33bafcbde38e62cd1e/site_utils/run_suite_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e21ed7eb31a8983d7e03a3bd6f96aa86cfd5e33e commit e21ed7eb31a8983d7e03a3bd6f96aa86cfd5e33e Author: Allen Li <ayatane@chromium.org> Date: Fri Aug 11 05:47:22 2017 [autotest] Factor out suite_args evaluation (reland) The intent is to: 1. Standardize how suite_args is handled (currently it is a special snowflake only used by control.suite). This will be used to pass additional arguments to provision suite and potentially other suites. 2. Pass suite_args as a dict instead of as a string to be evaluated. This is how test_args is passed currently. This change needs to be made also in run_suite.py, but compatibility code needs to be kept during the transition. I feel like channeling Richard and jumping off a bridge. BUG= chromium:672348 BUG= chromium:749971 TEST=None Change-Id: Ic67f21366cc0731e4fd73a7e29135be2bb454229 Reviewed-on: https://chromium-review.googlesource.com/591885 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/e21ed7eb31a8983d7e03a3bd6f96aa86cfd5e33e/test_suites/control.suite_attr_wrapper [modify] https://crrev.com/e21ed7eb31a8983d7e03a3bd6f96aa86cfd5e33e/frontend/afe/rpc_interface.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/337e124ffb799d96648b356df28b329a9410045e commit 337e124ffb799d96648b356df28b329a9410045e Author: Allen Li <ayatane@chromium.org> Date: Fri Aug 11 05:47:22 2017 [autotest] Add num control to provision suite (reland) BUG= chromium:672348 BUG= chromium:749971 TEST=None Change-Id: I1934c7172eaaf677f3c3a35e65e2dcb85b26f228 Reviewed-on: https://chromium-review.googlesource.com/591886 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/337e124ffb799d96648b356df28b329a9410045e/server/cros/dynamic_suite/suite.py [modify] https://crrev.com/337e124ffb799d96648b356df28b329a9410045e/server/cros/dynamic_suite/dynamic_suite.py
Comment 1 by akes...@chromium.org
, Jul 28 2017