Not effective memory utilization in SimpleStringDictionary
Reported by
rkuk...@yandex-team.ru,
Jul 28 2017
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0 Steps to reproduce the problem: 1. Set a breakpoint here https://cs.chromium.org/chromium/src/third_party/crashpad/crashpad/client/simple_string_dictionary.h?q=simple_string_dicti&sq=package:chromium&l=152 2. Start debugging 3. Keep pressing "Continue" until this->entries_ is filled with values. 4. Look at variations-* entries What is the expected behavior? The variations crash key is divided to 256 bytes chunks What went wrong? The variations crash key is divided to 64 bytes chunks Did this work before? N/A Chrome version: 62.0.3166.0 (Developer Build) (64-bit) Channel: n/a OS Version: 10.0 Flash Version: It seems the problem is here: https://cs.chromium.org/chromium/src/components/crash/core/common/crash_keys.h?q=src/components/crash/core/common/crash_keys.h&sq=package:chromium&l=58 These limitations should be actualized as we use 256-bytes crash keys on all systems. The crash keys map costs 32KB in each process. Let's use it effectively.
,
Aug 7 2017
Unable to triage this issue from TE-End, hence adding a "TE-NeedsTriageHelp" for further triage.
,
Aug 8 2017
I'm not sure that this issue is related to Chrome DevTools or to JavaScript.
,
Aug 8 2017
,
Jan 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8cff9f91ff4bad55dff176fceebd32784c956153 commit 8cff9f91ff4bad55dff176fceebd32784c956153 Author: Robert Sesek <rsesek@chromium.org> Date: Wed Jan 10 22:39:19 2018 Stop allocating a SimpleStringDictionary for Crashpad clients. Bug: 598854 , 749970 Change-Id: I1886528b886b14f5151842de486a058d726f8ace Reviewed-on: https://chromium-review.googlesource.com/850952 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Penny MacNeil <pennymac@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#528451} [modify] https://crrev.com/8cff9f91ff4bad55dff176fceebd32784c956153/chrome_elf/chrome_elf_x64.def [modify] https://crrev.com/8cff9f91ff4bad55dff176fceebd32784c956153/chrome_elf/chrome_elf_x86.def [modify] https://crrev.com/8cff9f91ff4bad55dff176fceebd32784c956153/components/crash/content/app/crash_export_stubs.cc [modify] https://crrev.com/8cff9f91ff4bad55dff176fceebd32784c956153/components/crash/content/app/crash_export_thunks.cc [modify] https://crrev.com/8cff9f91ff4bad55dff176fceebd32784c956153/components/crash/content/app/crash_export_thunks.h [modify] https://crrev.com/8cff9f91ff4bad55dff176fceebd32784c956153/components/crash/content/app/crashpad.cc [modify] https://crrev.com/8cff9f91ff4bad55dff176fceebd32784c956153/components/crash/content/app/crashpad.h [modify] https://crrev.com/8cff9f91ff4bad55dff176fceebd32784c956153/components/crash/content/app/crashpad_mac.mm
,
Jan 11 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ranjitkan@chromium.org
, Aug 2 2017