webkit_tests: media/controls/controls-video-keynav.html failing on chromium.webkit/WebKit Win7 (dbg) |
|||||
Issue descriptionwebkit_tests failing on chromium.webkit/WebKit Win7 (dbg) Builders failed on: - WebKit Win7 (dbg): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29 The failing test is media/controls/controls-video-keynav.html I couldn't find any CL that was obviously caused this, so I'm filing a bug and disabling the test for now. Adding test author and reviewer to take a look.
,
Jul 28 2017
Disabling CL is on the commit queue: https://chromium-review.googlesource.com/c/590894/
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83c77c81db5c34c0bcb9ecdd6b4f74f7ea3273d4 commit 83c77c81db5c34c0bcb9ecdd6b4f74f7ea3273d4 Author: Eddy Mead <meade@chromium.org> Date: Fri Jul 28 09:01:30 2017 [Chromium sheriff] disable media/controls/controls-video-keynav.html It is failing consistently on chromium.webkit/WebKit Win7 (dbg). See bug for details. TBR=lethalantidote@chromium.org,mlamouri@chromium.org Bug: 749965 Change-Id: I43e5b1a447e2ad44ff65adce5157be0673422e0b Reviewed-on: https://chromium-review.googlesource.com/590894 Reviewed-by: meade_UTC10 <meade@chromium.org> Commit-Queue: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#490330} [modify] https://crrev.com/83c77c81db5c34c0bcb9ecdd6b4f74f7ea3273d4/third_party/WebKit/LayoutTests/TestExpectations
,
Jul 30 2017
Removing from sheriff queue.
,
Sep 8 2017
Hi, I am trying to debug this, but am not seeing clear failure messages (I see a failure with my test, but I also see a lot of other tests failing, and the tool highlights different tests as the cause). It would help me a lot if you could tell me why you think my test is the source of all this? (Not in any way denying it is, it's just my first time troubleshooting this type of thing).
,
Sep 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/124fd90ff2ec6c34e4e7e9a15cdd9fc9c747200c commit 124fd90ff2ec6c34e4e7e9a15cdd9fc9c747200c Author: Max Morin <maxmorin@chromium.org> Date: Mon Sep 18 10:06:33 2017 Mark media/controls/controls-video-keynav.html flaky on Mac. Also consolidate test expectations for media/controls/controls-video-keynav.html in a section. Example failure on Mac: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/10180 21:45:20.125 9776 worker/5 virtual/new-remote-playback-pipeline/media/controls/controls-video-keynav.html output stderr lines: 21:45:20.125 9776 [10498:1295:0917/214519.834726:826422408194:ERROR:audio_manager_mac.cc(284)] Error getting default AudioDevice. 21:45:20.125 9776 [10498:1295:0917/214519.834865:826422544697:ERROR:audio_manager_mac.cc(845)] Invalid output device 21:45:20.127 9732 [4308/62916] virtual/new-remote-playback-pipeline/media/controls/controls-video-keynav.html failed unexpectedly (asserts failed) 21:45:20.126 9776 worker/5 virtual/new-remote-playback-pipeline/media/controls/controls-video-keynav.html failed: 21:45:20.126 9776 worker/5 asserts failed BUG= 749965 TBR=lethalantidote,mlamouri Change-Id: I7111dfc3e831f848a018b3d7b5316f8b9c7201e2 Reviewed-on: https://chromium-review.googlesource.com/670601 Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#502547} [modify] https://crrev.com/124fd90ff2ec6c34e4e7e9a15cdd9fc9c747200c/third_party/WebKit/LayoutTests/TestExpectations
,
Dec 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/171e396049a11c42cff7a00c8373362f09710c71 commit 171e396049a11c42cff7a00c8373362f09710c71 Author: CJ DiMeglio <lethalantidote@chromium.org> Date: Fri Dec 01 11:17:00 2017 Addresses flakiness by making tests event-based. Tests were failing due to a race condition where a variable would be checked before the completion of an event. The tests have been rewritten to be event based to avoid this issue. Due to the verbosity of this method, the test has been split into two files. Bug: 749965 Change-Id: I837497448402a0c8a730eda7283edeaed47d740f Reviewed-on: https://chromium-review.googlesource.com/753130 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#520913} [modify] https://crrev.com/171e396049a11c42cff7a00c8373362f09710c71/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/171e396049a11c42cff7a00c8373362f09710c71/third_party/WebKit/LayoutTests/media/controls/controls-video-keynav-space-vol.html [modify] https://crrev.com/171e396049a11c42cff7a00c8373362f09710c71/third_party/WebKit/LayoutTests/media/controls/controls-video-keynav.html
,
Dec 1 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by meade@chromium.org
, Jul 28 2017