New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749953 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Regression: Pictures in Emoji palette are seen black

Project Member Reported by rkalavakuntla@chromium.org, Jul 28 2017

Issue description

Chrome Version:62.0.3166.0/9785.0.0 dev channel Peppy,Candy,Reks
OS:chrome

What steps will reproduce the problem?
(1)Sign in to user >> Launch Chrome and Open chrome://md-settings/languages >>Input method
(2)Turn On the toggle button of 'Show input options in the shelf'
(3)In Input methods overlay, click on Emoji palette and Observe(Kindly refer video)

Actual: In Emoji palette.. emoji's,pictures are seen black
Expected:Instead, they should be colorful

This is a Regression issue as same is working fine in 61.0.3163.15/9765.8.0 dev channel Peppy

Note:Issue is not seen in Linux,Windows OS

@Stevenjb: Please confirm the above issue


 
Actual.webm
2.5 MB View Download
Expected.webm
551 KB View Download
Components: -UI>Settings UI>Input>VirtualKeyboard
Labels: emoji
Owner: ----
Status: Untriaged (was: Assigned)
This is not a settings bug, it's related to the emoji keyboard.

Owner: oka@chromium.org
Status: Assigned (was: Untriaged)
That somehow feels like a feature. Not saying it's a good one, but all the colors are applied so well that it's surprising :P 

oka@ can you have a look?

Comment 3 by oka@chromium.org, Jul 30 2017

Cc: wuyingbing@chromium.org
Yingbing, could you take a look?

Comment 4 by oka@chromium.org, Jul 31 2017

Owner: oka@chromium.org
Status: Assigned (was: Untriaged)
Ok. Looks like it's a recent regression. Let me bisect.

Testing on Kevin
OK: 62.0.3166.0
NG: 62.0.3169.0

Comment 5 by oka@chromium.org, Jul 31 2017

Owner: wuyingbing@chromium.org
wuyingbing@ I suspect https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/3f1215f51b263ebba9281fb4a5d153faafcde531 caused the issue. Could you take a look?

I confirmed Chrome OS 9780.0.0 is OK with Kevin.
There is no difference in Chrome between 9780 (OK) and 9785 (NG).
Chrome OS side diff https://crosland.corp.google.com/log/9780.0.0..9785.0.0
contains the said change.
Status: Started (was: Assigned)
Hi Oka,
I test my package on M61.0.3163.13. It's fine.
I am traveling on MTV now. 
Can't flash ChromeOS device to latest version.
It's supposed to be font issue.
Could you help to confirm it?
Can you see the colorful emoji "😀"?
If you can't see colorful emoji in the broken version.
It should be font issue.
Otherwise it should be Google Input Tool issue.
I will continue to investigate.

Comment 8 by oka@chromium.org, Aug 1 2017

Thank you for your investigation. I'll do more bisect per image.
Hi oka, Can you see the colorful emoji "😀"?

Comment 10 by oka@chromium.org, Aug 1 2017

9782 is also bad. I cannot see the colorful emoji.

Comment 11 by oka@chromium.org, Aug 1 2017

Cc: js...@chromium.org
9781 is good. To be precise, both VK emoji and #9 are colorful.
Diff: https://crosland.corp.google.com/log/9781.0.0..9782.0.0

Now I'm suspecting https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/229c8f27eb9f110c9319f959732c1e3d6b263b2d.

Comment 12 by oka@chromium.org, Aug 1 2017

Hi Jessica (jshin@).

I'm suspecting your change (#11) caused the issue that the emojis (e.g. "😀") become monochrome in Chrome OS.
Could you take a look?
Cc: keta...@chromium.org pucchakayala@chromium.org
Labels: M-61
Reproduce the issue on Chrome 61.0.3163.20/CrOS 9765.15.0 - Quawks, Caroline

Comment 14 by oka@chromium.org, Aug 2 2017

Oh, your name is Jungshik. Sorry for the mistake.

Hmm... CL in #11 didn't change either Noto Color Emoji (color) or NotoEmoji (b&w).

Anyway, let me take a look. I confirmed the bug in 62 canary build. 

BTW, the font used is Noto Emoji (B&W). 

Owner: js...@chromium.org
I found out the cause. There's a typo in local.conf that I overlooked because it scrolled over quickly when I ran 'fc-match -v "<font name>"'.  


Labels: -M-62
Has to be ported to 61 branch as well. 
CL is up at https://chromium-review.googlesource.com/c/599210 and was sent to CQ. 

Will merge to 61 branch as well. 
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e0a543042de87612a71afc0c095502199da7dbe5

commit e0a543042de87612a71afc0c095502199da7dbe5
Author: Jungshik Shin <jshin@chromium.org>
Date: Thu Aug 03 08:11:04 2017

Fix fontconfig for Noto Color Emoji

Typos in the latest fontconfig update causes Noto Color Emoji to be
treated as a bitmap font. Because Blink rejects bitmap fonts, Noto Color
Emoji is not used for Emojis. Instead, NotoEmoji (B&W) is used instead.

BUG= chromium:749953 
TEST=After updating fontconfig package, 'fc-match -v "Noto Color Emoji"'
does not have any error from fontconfig and 'scalable' is set to 'true'.
TEST=The browser column in http://unicode.org/emoji/charts/full-emoji-list.html
has color glyphs.

Change-Id: I95fee857b8483992231d1e64325f727c256cab9b
Reviewed-on: https://chromium-review.googlesource.com/599210
Commit-Ready: Jungshik Shin <jshin@chromium.org>
Tested-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/e0a543042de87612a71afc0c095502199da7dbe5/media-libs/fontconfig/files/local.conf
[rename] https://crrev.com/e0a543042de87612a71afc0c095502199da7dbe5/media-libs/fontconfig/fontconfig-2.11.1-r20.ebuild

Status: Fixed (was: Started)
I verified it in my local build. Will wait for Canary to have the above CL and ask for merge to R61 branch. 

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD Merge-Request-61
Verified in the latest canary build as well. 

Asking for Merge to 61. This is a safe/verified change and critical for R61 (color font support). 

Thank you !
Project Member

Comment 23 by sheriffbot@chromium.org, Aug 5 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 25 by bugdroid1@chromium.org, Aug 7 2017

Labels: merge-merged-release-R61-9765.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bc41f48c825816f4fbe4172a2cbd25d1fc468771

commit bc41f48c825816f4fbe4172a2cbd25d1fc468771
Author: Jungshik Shin <jshin@chromium.org>
Date: Mon Aug 07 19:57:44 2017

[R61] Fix fontconfig for Noto Color Emoji

Typos in the latest fontconfig update causes Noto Color Emoji to be
treated as a bitmap font. Because Blink rejects bitmap fonts, Noto Color
Emoji is not used for Emojis. Instead, NotoEmoji (B&W) is used instead.

BUG= chromium:749953 
TEST=After updating fontconfig package, 'fc-match -v "Noto Color Emoji"'
does not have any error from fontconfig and 'scalable' is set to 'true'.
TEST=The browser column in http://unicode.org/emoji/charts/full-emoji-list.html
has color glyphs.

Change-Id: I95fee857b8483992231d1e64325f727c256cab9b
Reviewed-on: https://chromium-review.googlesource.com/599210
Commit-Ready: Jungshik Shin <jshin@chromium.org>
Tested-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
(cherry picked from commit e0a543042de87612a71afc0c095502199da7dbe5)
Reviewed-on: https://chromium-review.googlesource.com/604167
Commit-Queue: Jungshik Shin <jshin@chromium.org>

[modify] https://crrev.com/bc41f48c825816f4fbe4172a2cbd25d1fc468771/media-libs/fontconfig/files/local.conf
[rename] https://crrev.com/bc41f48c825816f4fbe4172a2cbd25d1fc468771/media-libs/fontconfig/fontconfig-2.11.1-r20.ebuild

Project Member

Comment 26 by sheriffbot@chromium.org, Aug 11 2017

Cc: kbleicher@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 27 by sheriffbot@chromium.org, Aug 14 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 28 by js...@chromium.org, Dec 12 2017

Labels: -Merge-Approved-61

Comment 29 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment