Heap-use-after-free in test_runner::SpellCheckClient::RequestCheckingOfText |
|||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=6316752798744576 Fuzzer: ochang_domfuzzer Job Type: linux_asan_content_shell_drt Platform Id: linux Crash Type: Heap-use-after-free READ 8 Crash Address: 0x6030001b78d0 Crash State: test_runner::SpellCheckClient::RequestCheckingOfText blink::TextCheckerClientImpl::RequestCheckingOfString blink::HotModeSpellCheckRequester::CheckSpellingAt Sanitizer: address (ASAN) Recommended Security Severity: High Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=489897:489985 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6316752798744576 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
Jul 28 2017
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it. If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 28 2017
,
Jul 28 2017
,
Jul 31 2017
,
Jul 31 2017
This is not a security bug because the UAF is in testing code. Not a regression either. The bug exists since the introduction of the relevant test framework.
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c9464a6ea620209fc6ce23abc97ddc270a0dc02 commit 6c9464a6ea620209fc6ce23abc97ddc270a0dc02 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Tue Aug 01 02:40:28 2017 Fix a raw pointer use-after-free in test runner This patch clears the |last_requested_text_checking_completion_| raw pointer in test runner's mock spellchecker after calling DidCancelCheckingText() (which deletes itself), so that it won't be reused after free via the RequestResolved() callback. Bug: 749949 Change-Id: Id4f62ad4be7f94e65259fae0125223d7599e7257 Reviewed-on: https://chromium-review.googlesource.com/594837 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#490839} [modify] https://crrev.com/6c9464a6ea620209fc6ce23abc97ddc270a0dc02/content/shell/test_runner/spell_check_client.cc
,
Aug 1 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sheriffbot@chromium.org
, Jul 28 2017