New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749943 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

browser_tests failing on 2 builders

Project Member Reported by meade@chromium.org, Jul 28 2017

Issue description

browser_tests failing on 2 builders

Builders failed on: 
- Linux CFI: 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20CFI
- Linux MSan Tests: 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests

SettingsAccessibilityTest.All

Fails with error message
[ RUN      ] SettingsAccessibilityTest.All
Xlib:  extension "RANDR" missing on display ":99".
[2302:2302:0727/194600.068901:WARNING:password_store_factory.cc(255)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[2302:2302:0727/194603.747425:INFO:CONSOLE(1220)] "Running TestCase SettingsAccessibilityTest.All", source: test_api.js (1220)
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x0000082efa2c base::debug::StackTrace::StackTrace()
#1 0x000008b8f6fd content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f81dd548cb0 <unknown>
#3 0x7f81dd60284d __poll
#4 0x7f81dc0b5fe4 <unknown>
#5 0x7f81dc0b60ec g_main_context_iteration
#6 0x00000832ae45 base::MessagePumpGlib::Run()
#7 0x0000083262ac base::MessageLoop::Run()
#8 0x0000083691ee base::RunLoop::Run()
#9 0x000008be4317 content::RunThisRunLoop()
#10 0x000008be42cd content::RunMessageLoop()
#11 0x00000e4a40ad WebUITestHandler::WaitForResult()
#12 0x00000e4a3dc4 WebUITestHandler::RunJavaScriptTestWithResult()
#13 0x00000842c874 WebUIBrowserTest::RunJavascriptUsingHandler()
#14 0x00000842ce0f WebUIBrowserTest::RunJavascriptAsyncTest()
#15 0x00000842cc60 WebUIBrowserTest::RunJavascriptTestF()
#16 0x000006120bff SettingsAccessibilityTest_All_Test::RunTestOnMainThread()
#17 0x000008b8f458 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#18 0x000008b90161 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#19 0x0000084a0384 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#20 0x00000849f645 ChromeBrowserMainParts::PreMainMessageLoopRun()
#21 0x000006b64696 content::BrowserMainLoop::PreMainMessageLoopRun()
#22 0x000006b67bc1 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#23 0x0000071731dc content::StartupTaskRunner::RunAllTasksNow()
#24 0x000006b62e27 content::BrowserMainLoop::CreateStartupTasks()
#25 0x000006b6903a content::BrowserMainRunnerImpl::Initialize()
#26 0x000006b60006 content::BrowserMain()
#27 0x0000082ae70d content::RunNamedProcessTypeMain()
#28 0x0000082af8fb content::ContentMainRunnerImpl::Run()
#29 0x00000a4ba496 service_manager::Main()
#30 0x0000082addc1 content::ContentMain()
#31 0x000008b8f16f content::BrowserTestBase::SetUp()
#32 0x000008425254 InProcessBrowserTest::SetUp()
#33 0x0000061e5b23 testing::Test::Run()
#34 0x0000061e628e testing::TestInfo::Run()
#35 0x0000061e6942 testing::TestCase::Run()
#36 0x0000061eb593 testing::internal::UnitTestImpl::RunAllTests()
#37 0x0000061eb2c6 testing::UnitTest::Run()
#38 0x00000843cb1b base::TestSuite::Run()
#39 0x0000082de1a0 ChromeTestSuiteRunner::RunTestSuite()
#40 0x000008bde0d4 content::LaunchTests()
#41 0x0000082de0ec main
#42 0x7f81dd533f45 __libc_start_main

Suspecting https://chromium-review.googlesource.com/c/589696
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4bce1abf6150a5f5fc35846931608610a64c964

commit a4bce1abf6150a5f5fc35846931608610a64c964
Author: meade_UTC10 <meade@chromium.org>
Date: Fri Jul 28 03:55:43 2017

Revert "Add accessibility tests for passwords section of Chrome Settings."

This reverts commit 099c1190811a71b20162df04a53368b3d2a7f0ef.

Reason for revert: Seems to cause failure in browser_tests
SettingsAccessibilityTest.All. See  http://crbug.com/749943 

Original change's description:
> Add accessibility tests for passwords section of Chrome Settings.
> 
> Set up the GTest and Mocha-based a11y testing framework for Chrome WebUI
> by defining an accessibility_browsertest.js file for a11y test fixtures
> and including this file in the BUILD.gn.
> 
> The passwords section now fires an event when the settings section has
> expanded--an event that is responded to in the added a11y test.
> 
> The accessibility tests are only defined in normal mode because they
> timeout in debug mode.
> 
> Bug: 737739
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I43cb3b4f8d897e82292c1cddcae50ffc2fb83912
> Reviewed-on: https://chromium-review.googlesource.com/589696
> Commit-Queue: Tina Quach <quacht@google.com>
> Reviewed-by: Hector Carmona <hcarmona@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490192}

TBR=tommycli@chromium.org,hcarmona@chromium.org,quacht@google.com

Change-Id: I610728997486ece8dec0335239d0593bd70d3684
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 737739, 749943 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/590911
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490250}
[modify] https://crrev.com/a4bce1abf6150a5f5fc35846931608610a64c964/chrome/browser/resources/settings/settings_page/settings_section.js
[modify] https://crrev.com/a4bce1abf6150a5f5fc35846931608610a64c964/chrome/test/data/webui/BUILD.gn
[delete] https://crrev.com/fd7957902206f5958800cbed6203ba8b9a01dd81/chrome/test/data/webui/settings/accessibility_browsertest.js
[delete] https://crrev.com/fd7957902206f5958800cbed6203ba8b9a01dd81/chrome/test/data/webui/settings/passwords_a11y_test.js

Comment 2 by meade@chromium.org, Jul 28 2017

Status: Fixed (was: Available)
Bots have cycled green after revert.
Owner: quacht@google.com
Status: Assigned (was: Fixed)
SettingsAccessibilityTest.All is failing on Linux CFI again
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20CFI/builds/642

I am going to revert https://chromium-review.googlesource.com/#/q/I8715e83778409802849db38d90fef387db203f9b
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a708eb2ef6b2bccc5975b1f1bf6673ee39113c5f

commit a708eb2ef6b2bccc5975b1f1bf6673ee39113c5f
Author: Luna Lu <loonybear@chromium.org>
Date: Wed Aug 02 18:21:14 2017

Revert "Add accessibility tests for passwords section of Chrome Settings."

This reverts commit 6829a5b8f05dcfd00ba29f323ef73631472dd0bd.

Reason for revert: Seems to cause failure in browser_tests
SettingsAccessibilityTest.All. See  http://crbug.com/749943 

Original change's description:
> Add accessibility tests for passwords section of Chrome Settings.
> 
> Set up the GTest and Mocha-based a11y testing framework for Chrome WebUI
> by defining an accessibility_browsertest.js file for a11y test fixtures
> and including this file in the BUILD.gn.
> 
> The passwords section now fires an event when the settings section has
> expanded--an event that is responded to in the added a11y test.
> 
> The tests are disabled in debug mode and memory sanitizer mode due to
> timeout.
> 
> Bug: 737739
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I8715e83778409802849db38d90fef387db203f9b
> Reviewed-on: https://chromium-review.googlesource.com/592156
> Commit-Queue: Tina Quach <quacht@google.com>
> Reviewed-by: Hector Carmona <hcarmona@chromium.org>
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491409}

TBR=aboxhall@chromium.org,tommycli@chromium.org,hcarmona@chromium.org,quacht@google.com

Change-Id: I3c96c164e1872946897084a8713317e9d12c0aa5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 737739,  749943 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/598607
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491442}
[modify] https://crrev.com/a708eb2ef6b2bccc5975b1f1bf6673ee39113c5f/chrome/browser/resources/settings/settings_page/settings_section.js
[modify] https://crrev.com/a708eb2ef6b2bccc5975b1f1bf6673ee39113c5f/chrome/test/data/webui/BUILD.gn
[delete] https://crrev.com/f1d2878f3e9c945e326f01ffde0472e8eb0e322e/chrome/test/data/webui/settings/accessibility_browsertest.js
[delete] https://crrev.com/f1d2878f3e9c945e326f01ffde0472e8eb0e322e/chrome/test/data/webui/settings/passwords_a11y_test.js

Comment 5 by quacht@google.com, Aug 3 2017

Status: Fixed (was: Assigned)
I've disabled the test (by commenting out the TEST_F call) so that I can enable the test in a separate CL. I meant to comment it out the time Luna had to revert, but I made a mistake and submitted it uncommented. Thanks for your patience with this.

Sign in to add a comment