BridgedNativeWidgetUITest.FullscreenSynchronousState interactive_ui_tests failing on 10.13 |
||||||
Issue description
Chrome Version : 61.0.3135.4
OS Version: OS X 10.13
There seems to be one regression
1 test timed out:
BridgedNativeWidgetUITest.FullscreenSynchronousState (../../ui/views/cocoa/bridged_native_widget_interactive_uitest.mm:78)
(two others fail, but they are not regressions:
NativeWidgetMacInteractiveUITestInstance/NativeWidgetMacInteractiveUITest.ShowAttainsKeyStatus/0 NativeWidgetMacInteractiveUITestInstance/NativeWidgetMacInteractiveUITest.ShowAttainsKeyStatus/1
,
Nov 1 2017
,
Jan 29 2018
Mac CQ will be upgraded to 10.13 over the coming 3-4 weeks. Please see issue 805475 for more details. Please resolve 10.13 blockers asap.
,
Jan 29 2018
macviews_interactive_ui_tests was absorbed into interactive_ui_tests in r503301 BridgedNativeWidgetUITest.FullscreenSynchronousState still fails on 10.13 (but not other OSes) https://luci-milo.appspot.com/buildbot/chromium.fyi/Chromium%20Mac%2010.13/857 [ RUN ] BridgedNativeWidgetUITest.FullscreenSynchronousState 2018-01-29 13:51:19.177 interactive_ui_tests[8508:112600] *** WARNING: Textured window <NativeWidgetMacNSWindow: 0x7f89ffe0cb30> is getting an implicitly transparent titlebar. This will break when linking against newer SDKs. Use NSWindow's -titlebarAppearsTransparent=YES instead. 2018-01-29 13:51:19.834 interactive_ui_tests[8508:112600] not in fullscreen state
,
Jan 30 2018
tapted@: please kick this back to me if you aren't likely to have cycles for it in the next two weeks.
,
Feb 2 2018
@tapted the mac CQ migration is starting, please do let us know if you'll be able to address this over the next week and a half?
,
Feb 5 2018
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34aecb34894fd6bead6ab5146bd6afd1e792bebf commit 34aecb34894fd6bead6ab5146bd6afd1e792bebf Author: Trent Apted <tapted@chromium.org> Date: Tue Feb 06 00:26:51 2018 Mac: Toggle fullscreen asynchronously when recovering from a mid-transition request BridgedNativeWidgetUITest.FullscreenSynchronousState currently fails on 10.13. AppKit used to be able to start a new fullscreen transition inside the windowDidEnterFullScreen: observer/delegate callback. Now it fails and just prints text to stdio like "not in a fullscreen state". To fix, post the call to -[NSWindow toggleFullScreen:] asynchronously. Bug: 749939 Change-Id: I3426c961c77db8eef2cf418aedc5df7e17aac468 Reviewed-on: https://chromium-review.googlesource.com/900610 Reviewed-by: Sarah Chan <spqchan@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#534549} [modify] https://crrev.com/34aecb34894fd6bead6ab5146bd6afd1e792bebf/ui/views/cocoa/bridged_native_widget.h [modify] https://crrev.com/34aecb34894fd6bead6ab5146bd6afd1e792bebf/ui/views/cocoa/bridged_native_widget.mm [modify] https://crrev.com/34aecb34894fd6bead6ab5146bd6afd1e792bebf/ui/views/cocoa/bridged_native_widget_unittest.mm
,
Feb 6 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tapted@chromium.org
, Jul 28 2017