Spell check underlines appear on words while typing in some text boxes with idle-time spell checking enabled |
|||||||
Issue descriptionChrome Version: 60.0.3112.78 (Official Build) beta (64-bit) OS: macOS 10.12.5 What steps will reproduce the problem? (1) Verify idle-time spell-checking is enabled (in chrome://flags) (2) Click "reply" on a Gerrit text box (e.g. on https://chromium-review.googlesource.com/c/590532/) (3) Start typing What is the expected result? A spell check underline should not appear on a word I'm still typing. What happens instead? Spell check underlines appear immediately, before I'm finished typing the word. Note: the issue does not occur in all text boxes, there may be some JavaScript involved. Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Jul 28 2017
,
Jul 28 2017
Seems that Gerrit closes typing after each key press, as after typing a word, each Ctrl+Z removes only one character at a time Still investigating...
,
Jul 29 2017
The root cause is that FrameSelection, as a SynchronousMutationObserver, closes typing when observing node removal. Gerrit has a JS callback that modifies DOM after pressing each key. Repro: https://jsfiddle.net/ruxsxc74/1/
,
Jul 30 2017
Note: Slack exhibits the same bug
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6869f052d77b8816a3276e1cf22205aa09ecaec8 commit 6869f052d77b8816a3276e1cf22205aa09ecaec8 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Fri Aug 04 07:20:07 2017 Polish idle time spell checker's typing progress checking algorithm This patch makes idle time spell checker consider the possibility of typing in a partial word even with closed typing command, so that we won't be marking partial words due to JS closing typing command in the middle of typing. Bug: 749934 Change-Id: I426392adf69c30803a5c6de475680c2c9d55cfc5 Reviewed-on: https://chromium-review.googlesource.com/592789 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491959} [add] https://crrev.com/6869f052d77b8816a3276e1cf22205aa09ecaec8/third_party/WebKit/LayoutTests/editing/spelling/close_typing_in_partial_word.html [modify] https://crrev.com/6869f052d77b8816a3276e1cf22205aa09ecaec8/third_party/WebKit/Source/core/editing/spellcheck/HotModeSpellCheckRequester.cpp
,
Aug 4 2017
,
Aug 10 2017
Let me still merge it to M61. The bug is quite annoying when there is event handler constantly closing typing, e.g., in Gerrit. It's even more annoying given that idle time spell checker has launched in M60.
,
Aug 10 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 10 2017
This issue exists on M60 (not an M61 regression). Can this wait until M62? Please note M61 is already in Beta, so merge bar is very high. We're only taking only critical merges in. Thank you.
,
Aug 10 2017
I'm OK with waiting until M62. This is not a critical fix.
,
Aug 10 2017
Rejecting merge based on comment #11. Please do let us know if you see more reports on this and merge is needed.
,
Oct 9 2017
Issue 772856 has been merged into this issue. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by xiaoche...@chromium.org
, Jul 28 2017