Files app: Flatten contents of Media View |
|||||||||||||||
Issue descriptionCurrently, the files displayed in Media View are organized by the direct parent folder which can be confusing when users are trying to locate their files. Because the Media Views are intended to be a read-only quick access path for users to locate their files, we should flatten the contents of these views to only display the files and hide the directory structure. Note: Implementing this feature would also address crbug.com/687637 .
,
Sep 6 2017
,
Nov 16 2017
,
Dec 12 2017
,
Dec 12 2017
,
Dec 12 2017
,
Jan 30 2018
,
Feb 7 2018
,
Feb 16 2018
<files-triage>
,
Feb 28 2018
,
Feb 28 2018
,
Feb 28 2018
,
Apr 19 2018
,
Apr 19 2018
,
May 31 2018
fukino@ - Per our conversation yesterday, assigning this one to you for M69.
,
Jun 1 2018
Yes, I'll work on it. We have a UI concern about the flattened view. Users can't tell a photo of Snapsheed folder from one of other folders like DCIM. If we don't use folders to classify media files, we need an alternative UI hint about where the media file comes from. Possible solution might be adding "path" column on table view, or adding separators separating files from other folders. Detailed UI mock will be helpful to investigate this further.
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12a87b78f406952d9aad5be80b34a05b5832f941 commit 12a87b78f406952d9aad5be80b34a05b5832f941 Author: Naoki Fukino <fukino@chromium.org> Date: Fri Jul 13 06:24:25 2018 Files app: Flatten media views. In FileSystem API level, the root directory contains sub directories only, and all files are guaranteed to be located inside first-level directories. For example, in Pictures view, we have directories in the first level and all image files are in the second level. Pictures/ DCIM/ a.jpg Snapsheed/ foo.jpg To provide flatten view of files, it is enough to retrieve files recursively up to one level from the root. This CL adds a parameter to util.readFilesRecursively to limit the level of recursion, and use the function with limit:one-level to retrieve media-view files. Bug: 749924 Test: Manual test with/without #new-files-app-navigation and browser_tests Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie73f053fd7377cb3ef54013f97cd779920869613 Reviewed-on: https://chromium-review.googlesource.com/1135117 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#574847} [modify] https://crrev.com/12a87b78f406952d9aad5be80b34a05b5832f941/chrome/browser/chromeos/file_manager/file_manager_jstest.cc [modify] https://crrev.com/12a87b78f406952d9aad5be80b34a05b5832f941/ui/file_manager/file_manager/common/js/util.js [add] https://crrev.com/12a87b78f406952d9aad5be80b34a05b5832f941/ui/file_manager/file_manager/common/js/util_unittest.html [add] https://crrev.com/12a87b78f406952d9aad5be80b34a05b5832f941/ui/file_manager/file_manager/common/js/util_unittest.js [modify] https://crrev.com/12a87b78f406952d9aad5be80b34a05b5832f941/ui/file_manager/file_manager/foreground/js/directory_contents.js [modify] https://crrev.com/12a87b78f406952d9aad5be80b34a05b5832f941/ui/file_manager/file_manager/foreground/js/directory_model.js [modify] https://crrev.com/12a87b78f406952d9aad5be80b34a05b5832f941/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
,
Jul 13
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by uekawa@chromium.org
, Jul 28 2017