New issue
Advanced search Search tips

Issue 749916 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

components_unittests failing on chromium.mac/Mac10.9 Tests (dbg)

Project Member Reported by meade@chromium.org, Jul 28 2017

Issue description

components_unittests failing on chromium.mac/Mac10.9 Tests (dbg)

Builders failed on: 
- Mac10.9 Tests (dbg): 
  https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29



 

Comment 1 by meade@chromium.org, Jul 28 2017

[  FAILED  ] ImageCaptureDeviceManagerTest.DownloadFile
 1 FAILED TEST
[66452:771:0727/175406.024396:21234051575493:FATAL:image_capture_device.mm(74)] Check failed: ![camera_ delegate]. 
0   libbase.dylib                       0x000000012d0b467e base::debug::StackTrace::StackTrace(unsigned long) + 174
1   libbase.dylib                       0x000000012d0b474d base::debug::StackTrace::StackTrace(unsigned long) + 29
2   libbase.dylib                       0x000000012d0b29ec base::debug::StackTrace::StackTrace() + 28
3   libbase.dylib                       0x000000012d151c5f logging::LogMessage::~LogMessage() + 479
4   libbase.dylib                       0x000000012d14f5c5 logging::LogMessage::~LogMessage() + 21
5   components_unittests                0x000000011848f93e -[ImageCaptureDevice dealloc] + 270
6   libobjc.A.dylib                     0x00007fff903b465a (anonymous namespace)::AutoreleasePoolPage::pop(void*) + 502
7   CoreFoundation                      0x00007fff842e5932 _CFAutoreleasePoolPop + 50
8   Foundation                          0x00007fff9066e437 -[NSAutoreleasePool drain] + 147
9   libbase.dylib                       0x000000012d174a6d base::mac::ScopedNSAutoreleasePool::Recycle() + 61
10  components_unittests                0x000000011424d810 base::TestSuite::Run() + 352
11  components_unittests                0x0000000115a902ed content::UnitTestTestSuite::Run() + 45
12  components_unittests                0x0000000111809202 int base::internal::FunctorTraits<int (content::UnitTestTestSuite::*)(), void>::Invoke<std::__1::unique_ptr<content::UnitTestTestSuite, std::__1::default_delete<content::UnitTestTestSuite> > const&>(int (content::UnitTestTestSuite::*)(), std::__1::unique_ptr<content::UnitTestTestSuite, std::__1::default_delete<content::UnitTestTestSuite> > const&&&) + 146
13  components_unittests                0x0000000111809134 int base::internal::InvokeHelper<false, int>::MakeItSo<int (content::UnitTestTestSuite::* const&)(), std::__1::unique_ptr<content::UnitTestTestSuite, std::__1::default_delete<content::UnitTestTestSuite> > const&>(int (content::UnitTestTestSuite::* const&&&)(), std::__1::unique_ptr<content::UnitTestTestSuite, std::__1::default_delete<content::UnitTestTestSuite> > const&&&) + 68
14  components_unittests                0x00000001118090e0 int base::internal::Invoker<base::internal::BindState<int (content::UnitTestTestSuite::*)(), std::__1::unique_ptr<content::UnitTestTestSuite, std::__1::default_delete<content::UnitTestTestSuite> > >, int ()>::RunImpl<int (content::UnitTestTestSuite::* const&)(), std::__1::tuple<std::__1::unique_ptr<content::UnitTestTestSuite, std::__1::default_delete<content::UnitTestTestSuite> > > const&, 0ul>(int (content::UnitTestTestSuite::* const&&&)(), std::__1::tuple<std::__1::unique_ptr<content::UnitTestTestSuite, std::__1::default_delete<content::UnitTestTestSuite> > > const&&&, base::IndexSequence<0ul>) + 80
15  components_unittests                0x0000000111808ffc base::internal::Invoker<base::internal::BindState<int (content::UnitTestTestSuite::*)(), std::__1::unique_ptr<content::UnitTestTestSuite, std::__1::default_delete<content::UnitTestTestSuite> > >, int ()>::Run(base::internal::BindStateBase*) + 44
16  components_unittests                0x00000001160e5fed base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>::Run() const + 61
17  components_unittests                0x000000011428c2c8 base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, unsigned long, int, bool, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) + 376
18  components_unittests                0x000000011428c113 base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) + 163
19  components_unittests                0x000000010fd6efca main + 90
20  libdyld.dylib                       0x00007fff855ba5fd start + 1
[10888/10888] ImageCaptureDeviceManagerTest.DownloadFile (UNKNOWN)

Comment 2 by meade@chromium.org, Jul 28 2017

Suspecting https://chromium-review.googlesource.com/c/588078/ "Storage Monitor: Port Mac ImageCaptureDevice off of FILE thread."
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3594e75100f4e471e46a15107cae07279e4f21de

commit 3594e75100f4e471e46a15107cae07279e4f21de
Author: meade_UTC10 <meade@chromium.org>
Date: Fri Jul 28 01:58:21 2017

Revert "Storage Monitor: Port Mac ImageCaptureDevice off of FILE thread."

This reverts commit a456fdbdbac4831652a01e084ab512b8b6919619.

Reason for revert: Breaks component_unittests on 
Chromium.mac/Mac10.9 Tests(dbg). See http://crbug/749916
with error ImageCaptureDeviceManagerTest.DownloadFile:
Check failed: ![camera_ delegate]

Original change's description:
> Storage Monitor: Port Mac ImageCaptureDevice off of FILE thread.
> 
> Bug:  575383 
> Change-Id: I7e2908ff4ffb93fe30e48a54e6c0ab616ce1f736
> Reviewed-on: https://chromium-review.googlesource.com/588078
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Commit-Queue: Tommy Li <tommycli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490102}

TBR=thestig@chromium.org,tommycli@chromium.org

Change-Id: Ia7533daf98b0d1b16f9a9c1fc9a2468eeaa801eb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  575383 , 749916 
Reviewed-on: https://chromium-review.googlesource.com/590592
Commit-Queue: meade_UTC10 <meade@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490202}
[modify] https://crrev.com/3594e75100f4e471e46a15107cae07279e4f21de/chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm
[modify] https://crrev.com/3594e75100f4e471e46a15107cae07279e4f21de/components/storage_monitor/image_capture_device.mm

Cc: tommycli@chromium.org
Labels: OS-Mac Pri-3 Type-Bug

Comment 5 by meade@chromium.org, Jul 28 2017

Status: Fixed (was: Available)
Seems to have cycled green after revert - closing this.

Sign in to add a comment