Issue metadata
Sign in to add a comment
|
browser_side_navigation_content_browsertests failing on 2 builders |
||||||||||||||||||
Issue descriptionbrowser_side_navigation_content_browsertests failing on 2 builders Builders failed on: - Mac10.11 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests - Mac10.12 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23f4680286ad33ed59f24303954ff5ab79ae6cf8 commit 23f4680286ad33ed59f24303954ff5ab79ae6cf8 Author: meade_UTC10 <meade@chromium.org> Date: Fri Jul 28 01:47:03 2017 Revert "[DevTools] Suspend Page.navigate command until navigation has finished" This reverts commit 40d4ce0e6ae34044b4c8a13b571d2454b187ac05. Reason for revert: Seems to break browser_side_navigation_content_browsertests on at least two mac builders (see http://crbug.com/749915 ) Original change's description: > [DevTools] Suspend Page.navigate command until navigation has finished > > With browser side navigation, WCO::DidStartNavigation does not happen > synchronously after calling NavigationController::LoadURL(), which makes > Page.navigate command to be dispatched to old renderer during cross-process > navigations and yields a stale frame id. > > This patch specifically works around the problem for Page.navigate > by calling back synchronously to RFDTAH. > > BUG= 747224 > > Change-Id: I44935a407a4223004ef9873a49fc18dabbbfe02a > Reviewed-on: https://chromium-review.googlesource.com/585653 > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490096} TBR=dgozman@chromium.org,pfeldman@chromium.org Change-Id: Idad579478dd29cb59d35b688f4ad9b64628ec5fe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 747224 , 749915 Reviewed-on: https://chromium-review.googlesource.com/590509 Reviewed-by: meade_UTC10 <meade@chromium.org> Commit-Queue: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#490191} [modify] https://crrev.com/23f4680286ad33ed59f24303954ff5ab79ae6cf8/content/browser/devtools/protocol/devtools_protocol_browsertest.cc [modify] https://crrev.com/23f4680286ad33ed59f24303954ff5ab79ae6cf8/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/23f4680286ad33ed59f24303954ff5ab79ae6cf8/content/browser/devtools/render_frame_devtools_agent_host.h
,
Jul 28 2017
Revert has landed.
,
Jul 28 2017
Seems to have cycled green after revert, closing this. |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by meade@chromium.org
, Jul 28 2017