New issue
Advanced search Search tips

Issue 749913 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

remoting_unittests failing on 4 builders

Project Member Reported by meade@chromium.org, Jul 28 2017

Issue description

Comment 1 by meade@chromium.org, Jul 28 2017

My guess is https://chromium-review.googlesource.com/c/575730/, reverting.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efcdd07aa24562d73e7dae45a29d0f5505fdfff3

commit efcdd07aa24562d73e7dae45a29d0f5505fdfff3
Author: meade_UTC10 <meade@chromium.org>
Date: Fri Jul 28 01:45:52 2017

Revert "Implement EvaluateCapability and its tests"

This reverts commit 62d230808fcd5c92db013b59620ae52c36bd35d0.

Reason for revert:
Caused failures on various mac builders. See  http://crbug.com/749913 

Original change's description:
> Implement EvaluateCapability and its tests
> 
> This change adds --type=evaluate_capability command line parameter to execute
> host binary in "evaluate capability" mode. Meanwhile a helper function
> int EvaluateCapabilityForkedly() has been added to execute the host binary to
> evaluate certain functionality, and retrieves its output.
> 
> Return value is too simple for the evaluation, e.g. for DirectX capturer, both
> initialization result and DirectX version are required. To make it simple, in a
> coming change, we can directly output the host attributes regarding to the
> DirectX capturer into console, so the network process needs not to execute any
> DirectX related logic.
> 
> Bug:  741926 
> Change-Id: Ief06bed7b9297318bd387106108eccd02180e066
> Reviewed-on: https://chromium-review.googlesource.com/575730
> Commit-Queue: Zijie He <zijiehe@chromium.org>
> Reviewed-by: Joe Downing <joedow@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490121}

TBR=joedow@chromium.org,zijiehe@chromium.org

Change-Id: I386a908069e208db29af8be579efbf11903d9aa0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  741926 ,  749913 
Reviewed-on: https://chromium-review.googlesource.com/590909
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490189}
[modify] https://crrev.com/efcdd07aa24562d73e7dae45a29d0f5505fdfff3/remoting/host/BUILD.gn
[modify] https://crrev.com/efcdd07aa24562d73e7dae45a29d0f5505fdfff3/remoting/host/daemon_process_win.cc
[modify] https://crrev.com/efcdd07aa24562d73e7dae45a29d0f5505fdfff3/remoting/host/desktop_session_win.cc
[delete] https://crrev.com/6e2f0d649feb2fa9af693e20feade41df4dfd77c/remoting/host/evaluate_capability.cc
[delete] https://crrev.com/6e2f0d649feb2fa9af693e20feade41df4dfd77c/remoting/host/evaluate_capability.h
[delete] https://crrev.com/6e2f0d649feb2fa9af693e20feade41df4dfd77c/remoting/host/evaluate_capability_unittest.cc
[modify] https://crrev.com/efcdd07aa24562d73e7dae45a29d0f5505fdfff3/remoting/host/host_main.cc
[modify] https://crrev.com/efcdd07aa24562d73e7dae45a29d0f5505fdfff3/remoting/host/host_main.h
[modify] https://crrev.com/efcdd07aa24562d73e7dae45a29d0f5505fdfff3/remoting/host/switches.cc
[modify] https://crrev.com/efcdd07aa24562d73e7dae45a29d0f5505fdfff3/remoting/host/switches.h

Cc: zijiehe@google.com
Components: Services>Chromoting
Labels: Pri-3 Type-Bug
https://build.chromium.org/p/chromium.memory/builders/Linux%20TSan%20Tests/builds/9463 failed too.

Comment 6 by meade@chromium.org, Jul 28 2017

Yeah, looks like lots of builds failed, not just the quicker finishing ones. I'll merge the things in sheriff-o-matic.

Comment 7 by meade@chromium.org, Jul 28 2017

Seems to have cycled green after the revert, closing this.

Comment 8 by meade@chromium.org, Jul 28 2017

Status: Fixed (was: Available)

Sign in to add a comment