New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749911 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

long in public Windows apis probably should be LONG

Project Member Reported by dougt@chromium.org, Jul 28 2017

Issue description

Review AXPlatformNodeWin code for usages of long.  We should probably being using LONG.
 

Comment 1 by dougt@chromium.org, Jul 30 2017

Note that LONG is a 32-bit signed integer and is typedef'ed to a long in windows header files.

Nektar, do you have any further reason why we should make this change other than consistency at this point?

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5373fe3ca62f83f6288935ee7bf83e33115fa65f

commit 5373fe3ca62f83f6288935ee7bf83e33115fa65f
Author: Doug Turner <dougt@chromium.org>
Date: Wed Aug 23 23:45:34 2017

Use LONG instead of long in public MSCOM Accessibility APIs.

Bug:  749911 
Change-Id: I02fdad8a626b90d60aaab3d5c558c137b4fdd12e
Reviewed-on: https://chromium-review.googlesource.com/592791
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496873}
[modify] https://crrev.com/5373fe3ca62f83f6288935ee7bf83e33115fa65f/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/5373fe3ca62f83f6288935ee7bf83e33115fa65f/ui/accessibility/platform/ax_platform_node_win.h

Comment 3 by dougt@chromium.org, Aug 24 2017

Status: Fixed (was: Assigned)

Sign in to add a comment