Issue 749910 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	l...@chromium.org
Closed:	Aug 2017
Components:	Platform>DevTools
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

DevTools: arrow up/down in prompt should not load next/prev history command when there is selection

Project Member Reported by l...@chromium.org, Jul 28 2017

Issue description

What steps will reproduce the problem?
(1) Type text into the DevTools console prompt, evaluate with Enter
(2) Type text into the prompt
(3) Try to select all the text with Shift+Up repeatedly

What is the expected result?
Console prompt should not load the previous command from history

What happens instead?
Console prompt loads the previous command from history

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51357b560652a71c71a8449dd37c27107df62e4a

commit 51357b560652a71c71a8449dd37c27107df62e4a
Author: Erik Luo <luoe@chromium.org>
Date: Sat Jul 29 06:08:56 2017

DevTools: shift+arrow keys in console prompt should not move in history

Bug:  749910 
Change-Id: Iea25c4b2e102d773273523de10734efc1d688923
Reviewed-on: https://chromium-review.googlesource.com/590960
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490631}
[add] https://crrev.com/51357b560652a71c71a8449dd37c27107df62e4a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-prompt-keyboard-expected.txt
[add] https://crrev.com/51357b560652a71c71a8449dd37c27107df62e4a/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-prompt-keyboard.js
[modify] https://crrev.com/51357b560652a71c71a8449dd37c27107df62e4a/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js
[modify] https://crrev.com/51357b560652a71c71a8449dd37c27107df62e4a/third_party/WebKit/Source/devtools/front_end/console_test_runner/ConsoleTestRunner.js

Comment 2 by l...@chromium.org, Aug 14 2017

Status: Fixed (was: Started)

►

Issue 749910 link

Issue metadata

DevTools: arrow up/down in prompt should not load next/prev history command when there is selection

Issue description

Comment 1 by bugdroid1@chromium.org, Jul 29 2017

Comment 1 Deleted

Comment 2 by l...@chromium.org, Aug 14 2017

Comment 2 Deleted

Sign in to add a comment