New issue
Advanced search Search tips

Issue 749908 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocked on:
issue 768045



Sign in to add a comment

Update system SDK jar to their new location under third_party

Project Member Reported by sgu...@chromium.org, Jul 28 2017

Issue description

Update system SDK Jar to third_party/android_system_sdk. The change was LGTMed by chrome eng reviewers (klobag@) 

Also update the jar files to NMF26U
 

Comment 1 by sgu...@chromium.org, Jul 28 2017

Labels: -Pri-3 Pri-1
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f11fd495ece7b2046faadc1e69b9347873668390

commit f11fd495ece7b2046faadc1e69b9347873668390
Author: Selim Gurun <sgurun@google.com>
Date: Thu Aug 10 19:23:33 2017

Add Android System SDK to Chromium Source code

Move System SDK drops from third_party/android_platform/webview to
its special home. This CL updates android_system.jar and
android_stubs-src jar to NMF26U (Build ID 3562008).

Artifacts were downloaded from sdk_google_arm_phonev7.

BUG= 749908 

Change-Id: Iccf8bb57d2487869ff5471c76ca994cfc64fdf0a
Reviewed-on: https://chromium-review.googlesource.com/590988
Reviewed-by: Michael Case <mikecase@chromium.org>
Reviewed-by: Grace Kloba <klobag@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493492}
[modify] https://crrev.com/f11fd495ece7b2046faadc1e69b9347873668390/DEPS
[modify] https://crrev.com/f11fd495ece7b2046faadc1e69b9347873668390/third_party/.gitignore
[add] https://crrev.com/f11fd495ece7b2046faadc1e69b9347873668390/third_party/android_system_sdk/LICENSE
[add] https://crrev.com/f11fd495ece7b2046faadc1e69b9347873668390/third_party/android_system_sdk/OWNERS
[add] https://crrev.com/f11fd495ece7b2046faadc1e69b9347873668390/third_party/android_system_sdk/README.chromium
[add] https://crrev.com/f11fd495ece7b2046faadc1e69b9347873668390/third_party/android_system_sdk/android-stubs-src.jar.sha1
[add] https://crrev.com/f11fd495ece7b2046faadc1e69b9347873668390/third_party/android_system_sdk/android_system.jar.sha1

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af1d285f81dff2617a49ffa85139069e5fa31e33

commit af1d285f81dff2617a49ffa85139069e5fa31e33
Author: Paul Miller <paulmiller@google.com>
Date: Fri Aug 11 17:59:59 2017

Switch WebView builds to the new Android SDK location

This is a follow-up to f11fd495ece7b2046faadc1e69b9347873668390.

BUG= 749908 

Change-Id: Ica24227b8eef9cf7bd08c7a3218ed24bc713cfd5
Reviewed-on: https://chromium-review.googlesource.com/611247
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493803}
[modify] https://crrev.com/af1d285f81dff2617a49ffa85139069e5fa31e33/build/config/android/config.gni

Owner: paulmiller@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c10860836b84dc0d0b9848997dd1c13e17a7b393

commit c10860836b84dc0d0b9848997dd1c13e17a7b393
Author: Paul Miller <paulmiller@google.com>
Date: Tue Aug 15 17:25:02 2017

Update system SDK to O

Update android_system.jar and android-stubs-src.jar to OPR1.170623.015.
Artifacts were downloaded from sdk_phone_armv7-win_sdk.

BUG= 749908 

Change-Id: I9e2d089a3cb516ffb7a126989415a15d35c4cb65
Reviewed-on: https://chromium-review.googlesource.com/614660
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494426}
[modify] https://crrev.com/c10860836b84dc0d0b9848997dd1c13e17a7b393/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
[modify] https://crrev.com/c10860836b84dc0d0b9848997dd1c13e17a7b393/third_party/android_system_sdk/README.chromium
[modify] https://crrev.com/c10860836b84dc0d0b9848997dd1c13e17a7b393/third_party/android_system_sdk/android-stubs-src.jar.sha1
[modify] https://crrev.com/c10860836b84dc0d0b9848997dd1c13e17a7b393/third_party/android_system_sdk/android_system.jar.sha1

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 3 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/701dab1ce12a12d717d5038ec9540dd7d28a87b9

commit 701dab1ce12a12d717d5038ec9540dd7d28a87b9
Author: John Budorick <jbudorick@chromium.org>
Date: Sun Sep 03 04:52:10 2017

M61: Update Android System SDK to O.

This is a cherry-pick of three CLs to M61:
 - crrev.com/c/590988
 - crrev.com/c/614660
 - crrev.com/c/611247

BUG= 749908 ,761650
TBR=amineer@chromium.org,paulmiller@chromium.org,sgurun@chromium.org

Change-Id: I1c4320f6a24d6a719403b162aac73b1aa0927083
Reviewed-on: https://chromium-review.googlesource.com/648633
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1089}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/701dab1ce12a12d717d5038ec9540dd7d28a87b9/DEPS
[modify] https://crrev.com/701dab1ce12a12d717d5038ec9540dd7d28a87b9/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
[modify] https://crrev.com/701dab1ce12a12d717d5038ec9540dd7d28a87b9/build/config/android/config.gni
[modify] https://crrev.com/701dab1ce12a12d717d5038ec9540dd7d28a87b9/third_party/.gitignore
[add] https://crrev.com/701dab1ce12a12d717d5038ec9540dd7d28a87b9/third_party/android_system_sdk/LICENSE
[add] https://crrev.com/701dab1ce12a12d717d5038ec9540dd7d28a87b9/third_party/android_system_sdk/OWNERS
[add] https://crrev.com/701dab1ce12a12d717d5038ec9540dd7d28a87b9/third_party/android_system_sdk/README.chromium
[add] https://crrev.com/701dab1ce12a12d717d5038ec9540dd7d28a87b9/third_party/android_system_sdk/android-stubs-src.jar.sha1
[add] https://crrev.com/701dab1ce12a12d717d5038ec9540dd7d28a87b9/third_party/android_system_sdk/android_system.jar.sha1

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/1345e7e624a128aaa2da7095312e0bedad02d89a

commit 1345e7e624a128aaa2da7095312e0bedad02d89a
Author: Paul Miller <paulmiller@google.com>
Date: Tue Sep 19 19:30:48 2017

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/377494943e1590ea92cb169f5b2a08893c3fc487

commit 377494943e1590ea92cb169f5b2a08893c3fc487
Author: Paul Miller <paulmiller@google.com>
Date: Wed Sep 20 17:34:33 2017

Labels: OS-Android
Status: Fixed (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/91e575217ad60b98d23eb3a1e2a9b0e416e0b79c

commit 91e575217ad60b98d23eb3a1e2a9b0e416e0b79c
Author: Michael van Ouwerkerk <mvanouwerkerk@google.com>
Date: Fri Sep 22 10:58:47 2017

Blockedon: 768045
Status: Assigned (was: Fixed)
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/260e872b44c4956c6ca54c887f533cd5499e4cda

commit 260e872b44c4956c6ca54c887f533cd5499e4cda
Author: Paul Miller <paulmiller@google.com>
Date: Mon Oct 09 19:16:50 2017

Status: Fixed (was: Assigned)

Sign in to add a comment