New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749899 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Create common methods for grey_scrollInDirection and cleanup tests.

Project Member Reported by huangml@chromium.org, Jul 28 2017

Issue description

This method is used across multiple eg test files.

Create scroll action in chrome_earl_grey_ui.h file and clean up tests.
 

Comment 1 by baxley@chromium.org, Jul 28 2017

Could you clarify what is the problem with grey_scrollInDirection in our tests? Why do we need a separate API?

I'm not arguing against it, it's just not intuitive to me why we need helpers for it, and it would be good to have this info in the bug.
The matcher is to reduce the hardcoded number kMenuScrollDisplacement for  grey_scrollInDirection in tests.  The value is inconsistent within tests.  Some use 100, some 150 or 200 etc.   There is a matcher in chrome_earl_grey.mm already ScrollDown(),  though it's now private.  I think we can use that to clean up tests.   

Comment 3 by baxley@chromium.org, Jul 28 2017

Cool, thanks for clarifying.

An option can be to expose ScrollDown() in chrome_earl_grey_ui, and create ScrollUp()

Or we can just create a constant for the scroll displacement (or both). I just saw a CL that uses 150 and asked for a comment, having a constant would make the code more understandable.
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 30

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -baxley@chromium.org -liaoyuke@chromium.org linds...@chromium.org ericale@chromium.org yzjr@chromium.org
Status: Available (was: Untriaged)
Adding new people for visibility

Sign in to add a comment