Create common methods for grey_scrollInDirection and cleanup tests. |
|||
Issue descriptionThis method is used across multiple eg test files. Create scroll action in chrome_earl_grey_ui.h file and clean up tests.
,
Jul 28 2017
The matcher is to reduce the hardcoded number kMenuScrollDisplacement for grey_scrollInDirection in tests. The value is inconsistent within tests. Some use 100, some 150 or 200 etc. There is a matcher in chrome_earl_grey.mm already ScrollDown(), though it's now private. I think we can use that to clean up tests.
,
Jul 28 2017
Cool, thanks for clarifying. An option can be to expose ScrollDown() in chrome_earl_grey_ui, and create ScrollUp() Or we can just create a constant for the scroll displacement (or both). I just saw a CL that uses 150 and asked for a comment, having a constant would make the code more understandable.
,
Jul 30
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 30
Adding new people for visibility |
|||
►
Sign in to add a comment |
|||
Comment 1 by baxley@chromium.org
, Jul 28 2017