Default icon of some apps are not shown. |
|||||||||||
Issue descriptionChrome OS Version: 9592.71.0 Chrome OS Platform: 60.0.3112.80, Beta channel This issue is seen on samus device but not on cave, caroline devices. Steps To Reproduce: (1) Open the app launcher (2) Default icon of some apps are not shown. (3) When tried to open such apps, they don't start off. (4) Even after the device restart, the default icon is not visible. Refer the screenshot Expected Result: Default icon must be visible Actual Result: Default icon of some apps are not shown.
,
Aug 1 2017
P.s. creating a link using hc https://support.google.com/chrome_webstore/answer/3060053?hl=en has same effect
,
Aug 1 2017
Reproduced on M61 9765.5.0/61.0.3163.11 too. Some of the app icons are now default Google My Maps Google Deawings Google Forms Google Sites
,
Aug 1 2017
,
Aug 2 2017
+Josafat (ChromeOS TPM) and Mano (M60 stability owner) Adding "Needs-Triage" label so this gets looked at by the test team.
,
Aug 2 2017
Let me work on the bisect.
,
Aug 2 2017
Here is the narrow bisect: https://chromium.googlesource.com/chromium/src/+log/111fdd030ce49ce1de525ac10a983bed8fd8720e..32426e0c6511485debbf3b7c77e87791b6b3ec93 estade@, can you please look into this change (https://chromium.googlesource.com/chromium/src/+/32426e0c6511485debbf3b7c77e87791b6b3ec93) ? Thank you!
,
Aug 2 2017
FYI: Good Build# 56.0.2924.0 Bad Build# 57.0.2979.0
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1dbafbd845d0e5f33848327b2562f818a616acd commit a1dbafbd845d0e5f33848327b2562f818a616acd Author: Evan Stade <estade@chromium.org> Date: Thu Aug 10 17:40:30 2017 Restore functionality for generateAppForLink It turns out the dominant color codepath was still in use. If you drag a link to the NTP, it will use the favicon and a dominant color stripe for the app (link) it creates. ExtensionIconSource::GetIconURL will always return a valid URL but it may be for a default icon. IconsInfo::GetIconURL will return an empty URL if a non-default icon is not available. This CL mostly just resurrects pre-existing code. FaviconWebUIHandler is now dubbed AppIconWebUIHandler. Bug: 749889 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I014f974e9e2bf662313ae8c118915ae8fd6b125e Reviewed-on: https://chromium-review.googlesource.com/599073 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#493449} [modify] https://crrev.com/a1dbafbd845d0e5f33848327b2562f818a616acd/chrome/browser/extensions/extension_icon_manager.cc [modify] https://crrev.com/a1dbafbd845d0e5f33848327b2562f818a616acd/chrome/browser/extensions/extension_icon_manager.h [modify] https://crrev.com/a1dbafbd845d0e5f33848327b2562f818a616acd/chrome/browser/extensions/extension_icon_manager_unittest.cc [modify] https://crrev.com/a1dbafbd845d0e5f33848327b2562f818a616acd/chrome/browser/resources/ntp4/apps_page.css [modify] https://crrev.com/a1dbafbd845d0e5f33848327b2562f818a616acd/chrome/browser/resources/ntp4/apps_page.js [modify] https://crrev.com/a1dbafbd845d0e5f33848327b2562f818a616acd/chrome/browser/resources/ntp4/new_tab.html [modify] https://crrev.com/a1dbafbd845d0e5f33848327b2562f818a616acd/chrome/browser/resources/ntp4/new_tab.js [modify] https://crrev.com/a1dbafbd845d0e5f33848327b2562f818a616acd/chrome/browser/resources/ntp4/page_list_view.js [modify] https://crrev.com/a1dbafbd845d0e5f33848327b2562f818a616acd/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/a1dbafbd845d0e5f33848327b2562f818a616acd/chrome/browser/ui/webui/app_launcher_page_ui.cc [add] https://crrev.com/a1dbafbd845d0e5f33848327b2562f818a616acd/chrome/browser/ui/webui/ntp/app_icon_webui_handler.cc [add] https://crrev.com/a1dbafbd845d0e5f33848327b2562f818a616acd/chrome/browser/ui/webui/ntp/app_icon_webui_handler.h [modify] https://crrev.com/a1dbafbd845d0e5f33848327b2562f818a616acd/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
,
Aug 11 2017
As per c#8, it seems like this case was introduced in M57 (eg. not new with M60), can you confirm? maybe too late for merge to M61 but feel free to merge-request for evaluation
,
Aug 11 2017
the original report and comment 1 are probably different bugs, I don't know why they got lumped together. Comment 1 is what's been fixed and yes, it will have been present for several milestones. I don't think it's urgent to merge since it took us a while to realize it. The bug that corresponds to the original report might still stand, who knows. I don't know who's in charge of packaging chromeos default apps.
,
Sep 21 2017
In addition to the apps listed in #3, Google Play books Google Play movies & TV are shown with default icon. On trying to open such app, app remains in loading state on the shelf forever. Attached the screenshot.
,
Oct 4 2017
,
Oct 6 2017
Also saw this for bookmark apps
,
Sep 13
+afakhry for default apps. This one is probably long obsolete.
,
Sep 28
Let's close this because launcher has changed, and must be a newer bug if this is still a problem. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by marchuk@chromium.org
, Aug 1 2017Labels: Hotlist-Enterprise OS-Windows
Owner: bustamante@chromium.org
4.0 MB
4.0 MB View Download