Issue metadata
Sign in to add a comment
|
DevTools network throttling doesn't work with PlzNavigate |
||||||||||||||||||||||
Issue descriptionChrome Version: Chromium 62.0.3169.0 (Developer Build) (64-bit) OS: Goobuntu What steps will reproduce the problem? (1) Turn on PlzNavigate (chrome://flags/#browser-side-navigation) (2) Open DevTools, go to Network panel, check "offline" box (3) Go to example.com - expected result: page load fails, actual results: page loads normally I discovered this bug when I added a browser test for DevTools Network Throttling and found that it failed in CQ when the test is run w/ PlzNavigate. CL: https://chromium-review.googlesource.com/c/585845/ Example of failed run: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/511643/steps/browser_side_navigation_browser_tests%20%28with%20patch%29
,
Jul 27 2017
I am going to investigate tomorrow. Cc'ing more folks.
,
Jul 28 2017
,
Jul 29 2017
Andrey is going to fix this.
,
Aug 3 2017
Is there a rough idea about how to fix this? I'm interested because we have a similar issue at issue 746220 for service worker bypass.
,
Aug 3 2017
@falken, I'm currently looking into this and hopefully just adding X-DevTools-Emulate-Network-Conditions-Client-Id for the navigation request should do the trick -- we used to do this in Blink (InspectorNetworkAgent.cpp) which obviously doesn't happen in case of PlzNavigate.
,
Aug 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25dc5157098d393d8ed7263a8780c3f2471840ae commit 25dc5157098d393d8ed7263a8780c3f2471840ae Author: Andrey Kosyakov <caseq@chromium.org> Date: Mon Aug 07 21:30:52 2017 DevTools: support main resource throttling with PlzNavigate When navigating a frame that has DevTools attached, set X-DevTools-Emulate-Network-Conditions-Client-Id in NavigationRequest so that network conditions are applied when browser-initiated navigation if performed. Also, merge this logic with applying User-Agent override for brevity. Bug: 749884 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I26332c621b00e1c2d9a1872b95cb55d63f8d82d1 Reviewed-on: https://chromium-review.googlesource.com/600816 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#492416} [modify] https://crrev.com/25dc5157098d393d8ed7263a8780c3f2471840ae/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/25dc5157098d393d8ed7263a8780c3f2471840ae/content/browser/devtools/render_frame_devtools_agent_host.h [modify] https://crrev.com/25dc5157098d393d8ed7263a8780c3f2471840ae/content/browser/frame_host/navigation_request.cc
,
Aug 24 2017
,
Oct 6 2017
Issue 772133 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dgozman@chromium.org
, Jul 27 2017Owner: dgozman@chromium.org
Status: Assigned (was: Untriaged)