New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749880 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 749882

Blocking:
issue 747563


Participants' hotlists:
Downloads-Foreground-Service


Sign in to add a comment

[Downloads Foreground Service] Point DownloadBroadcastReceiver straight to DownloadBroadcastManager

Project Member Reported by jming@chromium.org, Jul 27 2017

Issue description

Re-route DownloadBroadcastReceiver to point directly to DownloadBroadcastManager (which becomes a service), making it unnecessary to go "back" to DownloadNotificationService.
 

Comment 1 by jming@chromium.org, Jul 27 2017

Blockedon: 749882

Comment 2 by jming@chromium.org, Jul 27 2017

Blockedon: -747569
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/411fb85ffd1c2478c78e9f6e6105d4c88f38ad96

commit 411fb85ffd1c2478c78e9f6e6105d4c88f38ad96
Author: Joy Ming <jming@chromium.org>
Date: Tue Aug 15 20:55:21 2017

Reroute notification interactions directly to DownloadBroadcastManager.

This is part of a larger refactor to make downloads a foreground
service. The DownloadBroadcastManager (DBM) is designed to handle all
interactions with the notifications that needed to be propagated to
native. Before this CL, notification interactions were received by the
DownloadBroadcastReceiver (DBR), sent to the DownloadNotificationService
(DNS), and then propagated to native by DBM. This CL makes the DBM a
service, allowing the notification interactions to directly start the 
DBM so that it no longer has to go through the DBR and DNS.

Bug:  749880 , 747563 
Change-Id: Iaef62292433a53e28366d796f7cfe9932e2fb28a
Reviewed-on: https://chromium-review.googlesource.com/611144
Commit-Queue: Joy Ming <jming@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494535}
[modify] https://crrev.com/411fb85ffd1c2478c78e9f6e6105d4c88f38ad96/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/411fb85ffd1c2478c78e9f6e6105d4c88f38ad96/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastManager.java
[modify] https://crrev.com/411fb85ffd1c2478c78e9f6e6105d4c88f38ad96/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastReceiver.java
[modify] https://crrev.com/411fb85ffd1c2478c78e9f6e6105d4c88f38ad96/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationFactory.java
[modify] https://crrev.com/411fb85ffd1c2478c78e9f6e6105d4c88f38ad96/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/411fb85ffd1c2478c78e9f6e6105d4c88f38ad96/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java
[modify] https://crrev.com/411fb85ffd1c2478c78e9f6e6105d4c88f38ad96/chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java

Comment 4 by jming@chromium.org, Aug 15 2017

Status: Fixed (was: Assigned)

Sign in to add a comment