New issue
Advanced search Search tips

Issue 749879 link

Starred by 1 user
Status: Fixed
Owner:
robertma@chromium.org
Closed: Sep 2017
Cc:
qyears...@chromium.org
jeffcarp@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Update webkitpy/thirdparty/wpt and use the wpt command

Project Member Reported by qyears...@chromium.org, Jul 27 2017 
In the latest version of wpt, the invocation of some tools has changed; e.g. wptserve it can now be started via `wpt serve`.

We should update thirdparty/wpt to the latest version and update related code in webkitpy.

Comment 1 by robertma@chromium.org, Jul 31 2017

Cc: -robertma@chromium.org qyears...@chromium.org
Owner: robertma@chromium.org
Status: Assigned (was: Available)
I can work on this one!

Comment 2 by qyears...@chromium.org, Jul 31 2017 

Excellent, thanks Robert!

Right now I'm not totally sure what has changed with the wpt tools, but you'll want to look at https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/README.chromium, and:

 1. Update WPTWhiteList and WPT_HEAD in checkout.sh
 2. Run checkout.sh
 3. Update places where tools are invoked in webkitpy
 4. Test that run-webkit-tests external/wpt works locally

Also, there's a local change to wpt that may or may not be in the upstream wpt repo now (adding the --repo-root and --ignore-glob flags to lint: https://chromium.googlesource.com/chromium/src/+/0c0029fc1d20f7c0b3da2df268f7e8e1c09c7b67). Jeff, do you remember if those are now merged in upstream wpt now?

Comment 3 by robertma@chromium.org, Jul 31 2017 

Quickly checked the wpt repo, it seems --repo-root was upstreamed but not --ignore-glob: https://github.com/w3c/web-platform-tests/blob/75b7060a306053d9392c9a9e99e47798a70e6188/tools/lint/lint.py#L682

Waiting for Jeff to provide some more context. Perhaps we need to dump our local changes into a patch, check it in, and re-apply the changes whenever we roll in a new upstream version (checkout.sh).

Comment 4 by jeffcarp@chromium.org, Aug 2 2017 

Ideally it'd be great to PR and land --ignore-glob upstream. However, since our local copy of WPT tools doesn't change often, re-applying the patch as you suggested should be fairly straightforward.

Comment 5 by robertma@chromium.org, Sep 14 2017

Status: Started (was: Assigned)

Comment 6 by robertma@chromium.org, Sep 21 2017 

+qyearsley: Do we still run wpt lint in Chromium now? I can't find where it's called.

Comment 7 by robertma@chromium.org, Sep 21 2017 

Ahh never mind, I found it at external/PRESUBMIT.py. Was looking at the wrong PRESUBMIT.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7448f7827b99e3c3ac392e36a93d781815ea20f

commit f7448f7827b99e3c3ac392e36a93d781815ea20f
Author: Robert Ma <robertma@chromium.org>
Date: Thu Sep 21 23:07:57 2017

Update documentation for thirdparty/wpt

Bug:  749879 
Change-Id: Ie283642f14d62191d86b57b058f2dd7515fe05b4
Reviewed-on: https://chromium-review.googlesource.com/676658
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503602}
[modify] https://crrev.com/f7448f7827b99e3c3ac392e36a93d781815ea20f/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/README.chromium
[modify] https://crrev.com/f7448f7827b99e3c3ac392e36a93d781815ea20f/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh

Comment 9 by robertma@chromium.org, Sep 25 2017

Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26a8ae1db8e8caa1f7c8b84611d6c72948120320

commit 26a8ae1db8e8caa1f7c8b84611d6c72948120320
Author: Robert Ma <robertma@chromium.org>
Date: Mon Sep 25 15:31:56 2017

Roll in new version of wpt tools and modify callers correspondingly

* Updated the versions in WPT_HEAD in checkout.sh and README.chromium.
* All wpt commands now have a single entry point, wpt. Include this
  dispatch module in WPTWhiteList.
* The commands for generating manifest, starting wptserve and running
  wpt lint are now "wpt manifest", "wpt serve" and "wpt lint". Change
  webkitpy and PRESUBMIT.py accordingly.
* The new wptserve contains a change for
  fetch/api/abort/general-serviceworker.https.html
  (https://github.com/w3c/web-platform-tests/pull/6484),
  so the test is rebaselined.

Bug:  749879 
Change-Id: I214860078add1c391266f063193aa279db414bb0
Reviewed-on: https://chromium-review.googlesource.com/677557
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504060}
[modify] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/LayoutTests/external/PRESUBMIT.py
[modify] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/LayoutTests/external/wpt/fetch/api/abort/general-serviceworker.https-expected.txt
[modify] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py
[modify] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/wptserve_unittest.py
[modify] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/README.chromium
[modify] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTWhiteList
[modify] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
[add] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/chromium.patch
[modify] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/.gitignore
[modify] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/config.default.json
[delete] https://crrev.com/ea69a470367f45ef9c98b9cb79d540c689154d0d/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/lint
[delete] https://crrev.com/ea69a470367f45ef9c98b9cb79d540c689154d0d/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/manifest
[delete] https://crrev.com/ea69a470367f45ef9c98b9cb79d540c689154d0d/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/serve
[add] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/lint/commands.json
[modify] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/lint/lint.py
[modify] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/localpaths.py
[add] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/commands.json
[modify] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/log.py
[modify] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/manifest.py
[modify] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/sourcefile.py
[modify] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/update.py
[add] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/serve/commands.json
[modify] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/serve/serve.py
[add] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/__init__.py
[add] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/browser.py
[add] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/commands.json
[add] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/install.py
[add] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/markdown.py
[add] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/paths
[add] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/run.py
[add] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/stability.py
[add] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/testfiles.py
[add] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/utils.py
[add] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/virtualenv.py
[add] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/wpt.py
[delete] https://crrev.com/ea69a470367f45ef9c98b9cb79d540c689154d0d/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/.gitignore
[modify] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/response.py
[add] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/wpt
[add] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/wpt.py
[modify] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
[modify] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_manifest.py
[modify] https://crrev.com/26a8ae1db8e8caa1f7c8b84611d6c72948120320/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_manifest_unittest.py
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5260d7bb2b96138fcd778b91af7edcf1b842ea1

commit d5260d7bb2b96138fcd778b91af7edcf1b842ea1
Author: Robert Ma <robertma@chromium.org>
Date: Wed Dec 06 00:33:03 2017

Roll in new version of WPT tools

Especially in order to get the new lint for 'web-platform.test'
(https://github.com/w3c/web-platform-tests/pull/6868)

Chromium custom patch for lint.py is modified to accompany
upstream changes.

Bug:  749879 
Change-Id: Ic2fb4655441f1d0e3bccbb7742565cb55645cf8f
Reviewed-on: https://chromium-review.googlesource.com/809745
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521913}
[modify] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/README.chromium
[modify] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTWhiteList
[modify] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
[modify] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/chromium.patch
[modify] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/gitignore/gitignore.py
[modify] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/lint/lint.py
[modify] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/commands.json
[add] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/download.py
[modify] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/item.py
[modify] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/sourcefile.py
[modify] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/update.py
[modify] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/serve/serve.py
[modify] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/browser.py
[modify] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/commands.json
[modify] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/run.py
[modify] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/testfiles.py
[modify] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/utils.py
[modify] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/wpt.py
[modify] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/handlers.py
[modify] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/pipes.py
[modify] https://crrev.com/d5260d7bb2b96138fcd778b91af7edcf1b842ea1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/server.py
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93a9cea62343308b074950734ee1f214d0c82681

commit 93a9cea62343308b074950734ee1f214d0c82681
Author: Robert Ma <robertma@chromium.org>
Date: Thu Mar 01 22:35:29 2018

Roll in new version of WPT tools

Bug:  749879 
Change-Id: Iff4a6e047b029bb12fa225bbf2cdeffc9172a1b7
Reviewed-on: https://chromium-review.googlesource.com/941966
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540311}
[modify] https://crrev.com/93a9cea62343308b074950734ee1f214d0c82681/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/README.chromium
[modify] https://crrev.com/93a9cea62343308b074950734ee1f214d0c82681/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
[modify] https://crrev.com/93a9cea62343308b074950734ee1f214d0c82681/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/lint/lint.py
[modify] https://crrev.com/93a9cea62343308b074950734ee1f214d0c82681/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/localpaths.py
[modify] https://crrev.com/93a9cea62343308b074950734ee1f214d0c82681/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/XMLParser.py
[modify] https://crrev.com/93a9cea62343308b074950734ee1f214d0c82681/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/manifest.py
[modify] https://crrev.com/93a9cea62343308b074950734ee1f214d0c82681/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/serve/serve.py
[modify] https://crrev.com/93a9cea62343308b074950734ee1f214d0c82681/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/sslutils/base.py
[modify] https://crrev.com/93a9cea62343308b074950734ee1f214d0c82681/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/browser.py
[modify] https://crrev.com/93a9cea62343308b074950734ee1f214d0c82681/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/install.py
[modify] https://crrev.com/93a9cea62343308b074950734ee1f214d0c82681/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/markdown.py
[modify] https://crrev.com/93a9cea62343308b074950734ee1f214d0c82681/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/run.py
[modify] https://crrev.com/93a9cea62343308b074950734ee1f214d0c82681/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/utils.py
[modify] https://crrev.com/93a9cea62343308b074950734ee1f214d0c82681/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/virtualenv.py
[modify] https://crrev.com/93a9cea62343308b074950734ee1f214d0c82681/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/handlers.py
[modify] https://crrev.com/93a9cea62343308b074950734ee1f214d0c82681/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/pipes.py
[modify] https://crrev.com/93a9cea62343308b074950734ee1f214d0c82681/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/response.py
[modify] https://crrev.com/93a9cea62343308b074950734ee1f214d0c82681/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/server.py
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/654af1c797919357cb9b1d11325c91af89d36f44

commit 654af1c797919357cb9b1d11325c91af89d36f44
Author: Robert Ma <robertma@chromium.org>
Date: Fri Mar 02 00:18:20 2018

Roll in new version of WPT tools again to include a Windows fix

The previous checkout contains a bug that would cause manifest update to
fail on Windows sometimes, so we are rolling a new version again to
include a high-priority fix:
https://github.com/w3c/web-platform-tests/pull/9737

Bug:  749879 
Change-Id: I36495316d5ddea288c7422c2dbed30c1fed6106d
Reviewed-on: https://chromium-review.googlesource.com/944720
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540364}
[modify] https://crrev.com/654af1c797919357cb9b1d11325c91af89d36f44/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/README.chromium
[modify] https://crrev.com/654af1c797919357cb9b1d11325c91af89d36f44/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
[modify] https://crrev.com/654af1c797919357cb9b1d11325c91af89d36f44/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/localpaths.py
[modify] https://crrev.com/654af1c797919357cb9b1d11325c91af89d36f44/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/manifest.py
[modify] https://crrev.com/654af1c797919357cb9b1d11325c91af89d36f44/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/vcs.py
[modify] https://crrev.com/654af1c797919357cb9b1d11325c91af89d36f44/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/serve/serve.py
[modify] https://crrev.com/654af1c797919357cb9b1d11325c91af89d36f44/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/browser.py
[modify] https://crrev.com/654af1c797919357cb9b1d11325c91af89d36f44/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/commands.json
[modify] https://crrev.com/654af1c797919357cb9b1d11325c91af89d36f44/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wpt/run.py
[modify] https://crrev.com/654af1c797919357cb9b1d11325c91af89d36f44/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/handlers.py
►

Sign in to add a comment