New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749868 link

Starred by 0 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on: View detail
issue 749890
issue 750323



Sign in to add a comment

telemetry unit test failures Jul 27

Project Member Reported by achuith@chromium.org, Jul 27 2017

Issue description

These 27 failures seem to be consistent:
telemetry.core.platform_unittest.TestHostPlatformInfo.testConsistentHostPlatformInfo
telemetry.internal.actions.load_media_unittest.LoadMediaActionTest.testLoadRaisesAnExceptionOnTimeout
telemetry.internal.actions.load_media_unittest.LoadMediaActionTest.testLoadWithAllSelector
telemetry.internal.actions.load_media_unittest.LoadMediaActionTest.testLoadWithNoSelector
telemetry.internal.actions.load_media_unittest.LoadMediaActionTest.testLoadWithSelector
telemetry.internal.actions.loop_unittest.LoopActionTest.testLoopWaitForLoopTimeout
telemetry.internal.actions.loop_unittest.LoopActionTest.testLoopWithAllSelector
telemetry.internal.actions.loop_unittest.LoopActionTest.testLoopWithNoSelector
telemetry.internal.actions.play_unittest.PlayActionTest.testPlayWaitForEnded
telemetry.internal.actions.play_unittest.PlayActionTest.testPlayWaitForEndedTimeout
telemetry.internal.actions.play_unittest.PlayActionTest.testPlayWaitForPlayTimeout
telemetry.internal.actions.play_unittest.PlayActionTest.testPlayWithAllSelector
telemetry.internal.actions.play_unittest.PlayActionTest.testPlayWithNoSelector
telemetry.internal.actions.play_unittest.PlayActionTest.testPlayWithVideoSelector
telemetry.internal.actions.play_unittest.PlayActionTest.testPlayWithoutWaitForEnded
telemetry.internal.actions.seek_unittest.SeekActionTest.testSeekWaitForSeekTimeout
telemetry.internal.actions.seek_unittest.SeekActionTest.testSeekWithAllSelector
telemetry.internal.actions.seek_unittest.SeekActionTest.testSeekWithNoSelector
telemetry.internal.actions.seek_unittest.SeekActionTest.testSeekWithVideoSelector
telemetry.internal.util.webpagereplay_go_server_unittest.WebPageReplayGoServerTest.testSmokeStartingWebPageReplayGoServer
telemetry.util.color_histogram_unittest.HistogramTest.testHistogram
telemetry.util.color_histogram_unittest.HistogramTest.testHistogramDistanceIgnoreColor
telemetry.util.color_histogram_unittest.HistogramTest.testHistogramIgnoreColor
telemetry.util.color_histogram_unittest.HistogramTest.testHistogramIgnoreColorTolerance
telemetry.util.image_util_unittest.ImageUtilTest.testCrop
telemetry.util.image_util_unittest.ImageUtilTest.testGetBoundingBox
telemetry.util.image_util_unittest.ImageUtilTest.testWriteCroppedBmpToPngFile


Both runs in 12004:
https://uberchromegw.corp.google.com/i/chromiumos.chromium/builders/amd64-generic-telemetry/builds/12004

Run 1 in 12001:
https://uberchromegw.corp.google.com/i/chromiumos.chromium/builders/amd64-generic-telemetry/builds/12001

Run 1 in 11999
https://uberchromegw.corp.google.com/i/chromiumos.chromium/builders/amd64-generic-telemetry/builds/11999


 
Cc: erosky@chromium.org
Should we close bug 702930 since you plan to use this?
That bug lists a number of unittests that were disabled, and someone needs to actually investigate and re-enable those tests. I view the bug as a tracking bug for the unittest failures, not just greening the bot by disabling the tests.

This bug will be more of the same - I'll fix a few of these tests, but the rest will simply be disabled.
Blockedon: 749890
Pulled the media unittests into own bug.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60f58b9ac0a58133d932f94c93d9c758571c0aa7

commit 60f58b9ac0a58133d932f94c93d9c758571c0aa7
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Fri Jul 28 05:04:22 2017

Roll src/third_party/catapult/ cc7953a31..a71decf74 (5 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/cc7953a310be..a71decf74249

$ git log cc7953a31..a71decf74 --date=short --no-merges --format='%ad %ae %s'
2017-07-27 achuith Disable failing media unittests on chromeos.
2017-07-27 achuith Fix testConsistentHostPlatformInfo on cros
2017-07-27 xunjieli [wpr-go] Roll binary forward
2017-07-27 xunjieli [wpr-go] Use a dummy cert when legacyformatconverter.go fails to reach server
2017-07-27 phsilva DeviceInfo into GenericSets

Created with:
  roll-dep src/third_party/catapult
BUG= 749868 , 749868 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I902b02e8dbf814da6f366fb256cc123e8b794396
Reviewed-on: https://chromium-review.googlesource.com/590678
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490271}
[modify] https://crrev.com/60f58b9ac0a58133d932f94c93d9c758571c0aa7/DEPS

Blockedon: 750323
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/872164a1e9d8557a2a0802be47da587ce4817f94

commit 872164a1e9d8557a2a0802be47da587ce4817f94
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Thu Aug 03 20:00:50 2017

Fixes for blink_perf tests

* browser_type may not be specified in blink_perf.py
* WebKit/PerformanceTests/TestData, and WebKit/PerformanceTests/SVG are
necessary.
* Get rid of bogus svn links.

BUG= chromium:664196 ,chromium:651219, chromium:749868 
TEST=manual

Change-Id: Idd5fbbb32e01f88a21f37e8e55a288f86a776f89
Reviewed-on: https://chromium-review.googlesource.com/599018
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491822}
[modify] https://crrev.com/872164a1e9d8557a2a0802be47da587ce4817f94/tools/perf/benchmarks/blink_perf.py
[modify] https://crrev.com/872164a1e9d8557a2a0802be47da587ce4817f94/tools/perf/bootstrap_deps

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e157751e8224c02aba014a435e06e1cc9ec9af8

commit 9e157751e8224c02aba014a435e06e1cc9ec9af8
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Sat Aug 05 02:27:44 2017

blink perf tests also need PerformanceData/resources.

BUG= 749868 
TEST=manual

Change-Id: I5b4a91555db866f28a31877aee425969c0e33d50
Reviewed-on: https://chromium-review.googlesource.com/603072
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492217}
[modify] https://crrev.com/9e157751e8224c02aba014a435e06e1cc9ec9af8/tools/perf/bootstrap_deps

Status: Fixed (was: Started)

Comment 11 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment