New issue
Advanced search Search tips

Issue 749866 link

Starred by 0 users
Status: Archived
Owner:
sammiequon@chromium.org
Closed: Aug 2017
Cc:
jdufault@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Regression: Password on lock screen does not show up after 10 minutes of idle.

Project Member Reported by sammiequon@chromium.org, Jul 27 2017 
(1) Open settings -> lock screen.
(2) Enter password.
(3) Idle for ten minutes.

Actual: nothing

Expected: Prompt password again.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/626e1fa012bf38c990bbcb37fa028bbd9ec6266f

commit 626e1fa012bf38c990bbcb37fa028bbd9ec6266f
Author: Sammie Quon <sammiequon@google.com>
Date: Sat Jul 29 01:20:10 2017

settings: Fix password prompt not displaying after timeout.

Password prompt would not display because of a old function causing a console error which would then skip the show password prompt function.

Test: manual
Bug:  749866 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I235fa5de68b6c37b76f21bfb1d2262860b7543ed
Reviewed-on: https://chromium-review.googlesource.com/590761
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490572}
[modify] https://crrev.com/626e1fa012bf38c990bbcb37fa028bbd9ec6266f/chrome/browser/resources/settings/people_page/lock_screen.js

Comment 2 by sammiequon@chromium.org, Jul 29 2017

Labels: Merge-Request-61
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 30 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 31 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e02455c1ef206951b9f882328eac50196ae23a0

commit 4e02455c1ef206951b9f882328eac50196ae23a0
Author: Sammie Quon <sammiequon@google.com>
Date: Mon Jul 31 17:16:01 2017

merge to 61: settings: Fix password prompt not displaying after timeout.

Password prompt would not display because of a old function causing a console error which would then skip the show password prompt function.

TBR=sammiequon@google.com

(cherry picked from commit 626e1fa012bf38c990bbcb37fa028bbd9ec6266f)

Test: manual
Bug:  749866 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I235fa5de68b6c37b76f21bfb1d2262860b7543ed
Reviewed-on: https://chromium-review.googlesource.com/590761
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490572}
Reviewed-on: https://chromium-review.googlesource.com/594350
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#158}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/4e02455c1ef206951b9f882328eac50196ae23a0/chrome/browser/resources/settings/people_page/lock_screen.js

Comment 5 by sammiequon@chromium.org, Aug 3 2017

Status: Fixed (was: Assigned)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment