New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 749860 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
█ hdodda@chromium.org
dpa...@chromium.org
steve...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Do not track dialog enter key handler only works the first time it's opened

Project Member Reported by tommycli@chromium.org, Jul 27 2017 
Just noticed:

Do not track dialog enter key handler only works the first time it's opened.

Subsequent openings seem to ignore the enter key.

I'm not sure if it's a bug with cr-dialog or due to the uncommon way the DNT dialog is not restamped.

Comment 1 by tommycli@chromium.org, Jul 27 2017 

I also get these errors when the dialog is closed on subsequent times:

[21074:21074:0727/154144.692337:ERROR:CONSOLE(204)] "Uncaught InvalidStateError: Failed to execute 'close' on 'HTMLDialogElement': The element does not have an 'open' attribute, and therefore cannot be closed.", source: chrome://settings/crisper.js (204)
[21074:21074:0727/154249.061675:ERROR:CONSOLE(204)] "Uncaught InvalidStateError: Failed to execute 'close' on 'HTMLDialogElement': The element does not have an 'open' attribute, and therefore cannot be closed.", source: chrome://settings/crisper.js (204)

So there's something probably not quite right.

Overall i'd recommend just restamping the dialog, as most other dialogs are restamped.

Comment 2 by hdodda@chromium.org, Sep 20 2017

Cc: hdodda@chromium.org
Labels: Needs-Milestone Needs-Feedback
Could you please provide any test file /jsfiddle and steps to reproduce the issue from TE End.

Thanks!

Comment 3 by dpa...@chromium.org, Sep 20 2017

Labels: Proj-MaterialDesign-WebUI
Status: Available (was: Unconfirmed)
@tommycli: I am able to reproduce the keyboard behavior you are describing. Could not reproduce the runtime error though.

Looked briefly and it does not seem like a cr-dialog bug (the listener is correctly attached, verified by firing a keypress event manually from the dev console).

The 2nd time the dialog is opened it does not receive any 'keypress' events, which indicates that it might not be focused after it is opened, which seems like a Blink bug. Obviously a minimal jsfiddle example would be helpful to isolate the problem here.

@hdodda, repro steps:
Turn on "do not track" in the privacy section, a dialog comes up. Hit "Enter", it closes. Turn off and back on "do not track". Same dialog comes up. Hit "Enter" again, this time it does not do anything.
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 21

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment