New issue
Advanced search Search tips

Issue 749843 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

build sys-devel/dev86 with clang

Project Member Reported by manojgupta@chromium.org, Jul 27 2017

Issue description

Currently sys-devel/dev86 is built with gcc.
Allow it to be built with clang.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b463ab8a0f5c80514a6badc3866d6302d2bc282f

commit b463ab8a0f5c80514a6badc3866d6302d2bc282f
Author: Manoj Gupta <manojgupta@google.com>
Date: Fri Jul 28 02:56:23 2017

dev86: Remove forced build by gcc.

dev86-0.16.21-r2 can be built with clang.

CQ-DEPEND=CL:590152

BUG= chromium:749843 
TEST=dev86 builds with both gcc and clang.

Change-Id: I6eb3f856c7f63a7bcbcb15bef656cc1ea35650f9
Reviewed-on: https://chromium-review.googlesource.com/590650
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/8757fe24607d0c6fd16d44a05f714f0b2cac73a9/chromeos/config/env/sys-devel/dev86

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/f3c36240c356b0c4bdb98c5854353bfbd7a91ced

commit f3c36240c356b0c4bdb98c5854353bfbd7a91ced
Author: Manoj Gupta <manojgupta@google.com>
Date: Fri Jul 28 02:56:23 2017

dev86: Upgrade to latest gentoo version 0.16.21-r2.

The latest gentoo version includes a patch to fix build with clang.

Ebuild changes from upstream:
1. EAPI: 6->5
2. default -> epatch
3. KEYWORKDS -> *
4. Added import of eutils otherwise epatch was not found in src_prepare.

BUG= chromium:749843 
TEST=dev86 builds with both gcc and clang.

Change-Id: I19673c40ec894726760a1d2c423de84a7b6e414c
Reviewed-on: https://chromium-review.googlesource.com/590152
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/f3c36240c356b0c4bdb98c5854353bfbd7a91ced/sys-devel/dev86/dev86-0.16.21-r2.ebuild
[delete] https://crrev.com/1cbf7c903b52abc77004206400ea95aec43b9d1f/sys-devel/dev86/files/dev86-0.16.19-memmove.patch
[delete] https://crrev.com/1cbf7c903b52abc77004206400ea95aec43b9d1f/sys-devel/dev86/files/dev86-0.16.17-fortify.patch
[add] https://crrev.com/f3c36240c356b0c4bdb98c5854353bfbd7a91ced/sys-devel/dev86/files/dev86-0.16.21-non-void-return-clang.patch
[delete] https://crrev.com/1cbf7c903b52abc77004206400ea95aec43b9d1f/sys-devel/dev86/files/dev86-0.16.17-make382.patch

Status: Verified (was: Started)

Sign in to add a comment