New issue
Advanced search Search tips

Issue 749829 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 1
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

LinuxClangAnalyzer crashing without going red

Project Member Reported by pbos@chromium.org, Jul 27 2017

Issue description

This bot is green, but looking at the logs the static analyzer is crashing heavily: https://build.chromium.org/p/chromium.fyi/builders/Linux%20Clang%20Analyzer

Bot says to look at  issue 695243  which says to file bugs for the specific instance to llvm directly, but clang analyzer crashing should probably turn the bot red (so these errors can be detected).

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FLinux_Clang_Analyzer%2F484%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout
 
Cc: dpranke@chromium.org
This could be a nice incentive to report analyzer regressions to the LLVM folks.

dpranke: Is there a way we can turn the bot red, short of returning an error code from a build task & stopping the entire build? I'd like to avoid that.
For the `compile` step, currently the only mechanism we have to tell the build that something passed or failed is to look at the return code.

If you wanted to do something else (like fail based on the contents of stdout), you'd need to write something that wrapped the invocation of ninja, parsed it, and then returned a different exit code. 

Somewhat coincidentally, we're actually working on a wrapper that does that but for different reasons, so I don't know if that would be useful here.

Alternatively, you could periodically fetch the logs for those steps afterwards and scan them for errors.

A third option would be to change the clang invocation to invoke a wrapper that captured the output and failed the individual compile command. I'm not actually sure why the crashes you're seeing now aren't already failing the compile?
The wrapper script does a regular compile regardless of the analysis output, since as you can see, the analyzer is a bit more fragile/regression-prone. Only the return code from the second compile step is propagated.
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 1

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment