New issue
Advanced search Search tips

Issue 749814 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 901165
Owner:
Closed: Nov 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocked on:
issue 753435



Sign in to add a comment

Surface first contentful paint in Performance panel

Project Member Reported by phulce@chromium.org, Jul 27 2017

Issue description

Labels: ProgressiveWebMetrics
Labels: -Pri-3 Pri-2
Now that we're shipping these web perf APIs, I think we should prioritize this.

Bumping up to P2.

Comment 3 by panicker@google.com, Aug 18 2017

First Paint is still behind a flag right? Can we ship it?

Comment 4 by phulce@chromium.org, Aug 18 2017

First Paint is in Chrome stable without any flags, the performance pane just has issues that make it hard to see the title right now. CL is already in progress for adding FCP and aligning the coloring.

https://chromium-review.googlesource.com/c/619500/

Comment 5 by phulce@chromium.org, Aug 18 2017

Blockedon: 753435
Update from caseq@ you're actually *supposed* to need to turn on a flag to be able to see it, but there's a bug that shows them all anyway in all current versions of Chrome. See https://bugs.chromium.org/p/chromium/issues/detail?id=753435.
Is there any plan to surface FP/FCP? Now that the paint timing API has shipped, surfacing these in devtools seems like a good plan.

Comment 7 by npm@chromium.org, Jan 9 2018

Ping

Comment 8 by phulce@chromium.org, Jan 10 2018

Cc: paulir...@chromium.org
Just got the thumbs up from @paulirish to go ahead and land the CL without waiting for the broader Performance Panel UX fix so will go ahead and rebase it when I get back.
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8aa9d3c36da38e073a2edb2c6ff3b913c5a56905

commit 8aa9d3c36da38e073a2edb2c6ff3b913c5a56905
Author: Patrick Hulce <phulce@chromium.org>
Date: Tue Feb 06 21:45:56 2018

DevTools: Add FCP to timeline markers

* Adds FirstContentfulPaint to timeline markers
* Adjusts colors of paint markers to different shades of green

BUG= 749814 

Change-Id: I4ccbcae4c6906d9fbacc8a81eb55b6059f55f472
Reviewed-on: https://chromium-review.googlesource.com/619500
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Patrick Hulce <phulce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534802}
[modify] https://crrev.com/8aa9d3c36da38e073a2edb2c6ff3b913c5a56905/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
[modify] https://crrev.com/8aa9d3c36da38e073a2edb2c6ff3b913c5a56905/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

Wooo!

Comment 11 by dproy@chromium.org, Mar 16 2018

Components: Speed>Metrics
Labels: -ProgressiveWebMetrics

Comment 12 by npm@chromium.org, Jun 27 2018

Can this be marked as fixed?
This is still behind an experimental flag.

I'd really like to see this brought out from behind the flag. Are we still stuck on UX here?
@paulirish last time you voiced concerns about bringing it out of experiment, are you still hesitant?
Hello,

I've tried to check this but I'm unable to find FP, FMP nor FCP in devtools UI. Using Canary 72 on Windows.

Which flag is it behind? FYI I have enabled chrome://flags/#enable-devtools-experiments

How is this supposed to look like? A dashed vertical bar like the red and blue ones for load/DOMContentLoaded?

FYI I'm using this page to test: https://jg-testpage.github.io/wpt/user-timing.html
Owner: paulir...@chromium.org
Mergedinto: 901165
Status: Duplicate (was: Assigned)

Sign in to add a comment