Issue metadata
Sign in to add a comment
|
'Filter' text box should have focus after clicking 'Choose try jobs' |
||||||||||||||||||||||
Issue descriptionAffected Version: What steps will reproduce the problem? 1. Click 'Choose try jobs' 2. Try to start typing to filter list of bots What is the expected output? Should work. What do you see instead? I have to manually click the 'Filter' text box first, even though nothing else has keyboard focus while the try dialog is up. Please provide any additional information below.
,
Jul 25 2017
Kasper: the "choose try jobs" box is a gr-overlay. Can you comment on what the best way would be to have the new gr-overlay focus a specific sub-element? And relatedly, for accessibility, when it closes, gr-overlay needs to restore focus to wherever it was prior to the overlay being opened.
,
Jul 25 2017
I'd recommend following the approach done in gr-change-view here: https://gerrit.googlesource.com/gerrit/+/master/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js#371
,
Jul 27 2017
Aaron, feel free to send this back our way if you need help implementing this.
,
Jul 27 2017
,
Jul 27 2017
,
Jan 3 2018
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.
,
Mar 27 2018
I fixed this! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by wyatta@google.com
, Jul 24 2017