New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749801 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

GLMark2 perf regressions

Project Member Reported by marc...@chromium.org, Jul 27 2017

Issue description

Lots of perf regressions : 

buddy:

https://chromeperf.appspot.com/report?masters=ChromeOS_Graphics&bots=cros-buddy&tests=graphics_GLMark2%2Fshading.shading_cel&checked=shading.shading_cel%2Cshading.shading_cel_ref%2Cref&rev=31540000973500000

https://chromeperf.appspot.com/report?masters=ChromeOS_Graphics&bots=cros-buddy&tests=graphics_GLMark2%2Fbuffer.columns_200.interleave_false.update-dispersion_0.9.update-fraction_0.5.update-method_map&checked=buffer.columns_200.interleave_false.update-dispersion_0.9.update-fraction_0.5.update-method_map%2Cbuffer.columns_200.interleave_false.update-dispersion_0.9.update-fraction_0.5.update-method_map_ref%2Cref&rev=31540000973500000

https://chromeperf.appspot.com/report?masters=ChromeOS_Graphics&bots=cros-buddy&tests=graphics_GLMark2%2Fdesktop.effect_shadow.windows_4&checked=desktop.effect_shadow.windows_4%2Cdesktop.effect_shadow.windows_4_ref%2Cref&rev=31540000973500000

https://chromeperf.appspot.com/report?masters=ChromeOS_Graphics&bots=cros-buddy&tests=graphics_GLMark2%2Feffect2d.kernel_0-1-0_1--4-1_0-1-0_&checked=effect2d.kernel_0-1-0_1--4-1_0-1-0_%2Ceffect2d.kernel_0-1-0_1--4-1_0-1-0__ref%2Cref&rev=31540000973500000

https://chromeperf.appspot.com/report?masters=ChromeOS_Graphics&bots=cros-buddy&tests=graphics_GLMark2%2Fshading.shading_phong&checked=shading.shading_phong%2Cshading.shading_phong_ref%2Cref&rev=31540000973500000

https://chromeperf.appspot.com/report?masters=ChromeOS_Graphics&bots=cros-buddy&tests=graphics_GLMark2%2Fdesktop.blur-radius_5.effect_blur.passes_1.separable_true.windows_4&checked=desktop.blur-radius_5.effect_blur.passes_1.separable_true.windows_4%2Cdesktop.blur-radius_5.effect_blur.passes_1.separable_true.windows_4_ref%2Cref&rev=31540000973500000

https://chromeperf.appspot.com/report?masters=ChromeOS_Graphics&bots=cros-buddy&tests=graphics_GLMark2%2Fterrain.default&checked=terrain.default%2Cterrain.default_ref%2Cref&rev=31540000973500000

https://chromeperf.appspot.com/report?masters=ChromeOS_Graphics&bots=cros-buddy&tests=graphics_GLMark2%2Fbuild.use-vbo_false&checked=build.use-vbo_false%2Cbuild.use-vbo_false_ref%2Cref&rev=31540000973500000

https://chromeperf.appspot.com/report?masters=ChromeOS_Graphics&bots=cros-buddy&tests=graphics_GLBench%2Ftemperature_2_before_test&checked=temperature_2_before_test%2Ctemperature_2_before_test_ref%2Cref&rev=30680010945600000


monroe:

https://chromeperf.appspot.com/report?masters=ChromeOS_Graphics&bots=cros-monroe&tests=graphics_GLMark2%2Fbuffer.columns_200.interleave_false.update-dispersion_0.9.update-fraction_0.5.update-method_map&checked=buffer.columns_200.interleave_false.update-dispersion_0.9.update-fraction_0.5.update-method_map%2Cbuffer.columns_200.interleave_false.update-dispersion_0.9.update-fraction_0.5.update-method_map_ref%2Cref&rev=31540000973500000

https://chromeperf.appspot.com/report?masters=ChromeOS_Graphics&bots=cros-monroe&tests=graphics_GLMark2%2Fbuffer.columns_200.interleave_false.update-dispersion_0.9.update-fraction_0.5.update-method_subdata&checked=buffer.columns_200.interleave_false.update-dispersion_0.9.update-fraction_0.5.update-method_subdata%2Cbuffer.columns_200.interleave_false.update-dispersion_0.9.update-fraction_0.5.update-method_subdata_ref%2Cref&rev=31540000973500000

https://chromeperf.appspot.com/report?masters=ChromeOS_Graphics&bots=cros-monroe&tests=graphics_GLMark2%2Fbuffer.columns_200.interleave_true.update-dispersion_0.9.update-fraction_0.5.update-method_map&checked=buffer.columns_200.interleave_true.update-dispersion_0.9.update-fraction_0.5.update-method_map%2Cbuffer.columns_200.interleave_true.update-dispersion_0.9.update-fraction_0.5.update-method_map_ref%2Cref&rev=31540000973500000

https://chromeperf.appspot.com/report?masters=ChromeOS_Graphics&bots=cros-monroe&tests=graphics_GLMark2%2Fideas.speed_duration&checked=ideas.speed_duration%2Cideas.speed_duration_ref%2Cref&rev=31540000973500000

https://chromeperf.appspot.com/report?masters=ChromeOS_Graphics&bots=cros-monroe&tests=graphics_GLMark2%2Fbuild.use-vbo_false&checked=build.use-vbo_false%2Cbuild.use-vbo_false_ref%2Cref&rev=31540000973500000



falco:

https://chromeperf.appspot.com/report?masters=ChromeOS_Graphics&bots=cros-falco_li&tests=graphics_GLMark2%2Fbuffer.columns_200.interleave_false.update-dispersion_0.9.update-fraction_0.5.update-method_subdata&checked=buffer.columns_200.interleave_false.update-dispersion_0.9.update-fraction_0.5.update-method_subdata%2Cbuffer.columns_200.interleave_false.update-dispersion_0.9.update-fraction_0.5.update-method_subdata_ref%2Cref&rev=31540000973400000

https://chromeperf.appspot.com/report?masters=ChromeOS_Graphics&bots=cros-falco_li&tests=graphics_GLMark2%2Fbuffer.columns_200.interleave_true.update-dispersion_0.9.update-fraction_0.5.update-method_map&checked=buffer.columns_200.interleave_true.update-dispersion_0.9.update-fraction_0.5.update-method_map%2Cbuffer.columns_200.interleave_true.update-dispersion_0.9.update-fraction_0.5.update-method_map_ref%2Cref&rev=31540000973400000

https://chromeperf.appspot.com/report?masters=ChromeOS_Graphics&bots=cros-falco_li&tests=graphics_GLMark2%2Fideas.speed_duration&checked=ideas.speed_duration%2Cideas.speed_duration_ref%2Cref&rev=31540000973400000



leon:

https://chromeperf.appspot.com/report?masters=ChromeOS_Graphics&bots=cros-leon&tests=graphics_GLMark2%2Fbuffer.columns_200.interleave_true.update-dispersion_0.9.update-fraction_0.5.update-method_map&checked=buffer.columns_200.interleave_true.update-dispersion_0.9.update-fraction_0.5.update-method_map%2Cbuffer.columns_200.interleave_true.update-dispersion_0.9.update-fraction_0.5.update-method_map_ref%2Cref&rev=31540000973500000

https://chromeperf.appspot.com/report?masters=ChromeOS_Graphics&bots=cros-leon&tests=graphics_GLMark2%2Fbuffer.columns_200.interleave_false.update-dispersion_0.9.update-fraction_0.5.update-method_subdata&checked=buffer.columns_200.interleave_false.update-dispersion_0.9.update-fraction_0.5.update-method_subdata%2Cbuffer.columns_200.interleave_false.update-dispersion_0.9.update-fraction_0.5.update-method_subdata_ref%2Cref&rev=31540000973500000

I think it's a continuation of yesterday's glmark regressions. Again nothing obvious from the changelog, but it looks pretty consistent.
 
Cc: ihf@chromium.org
The changelog does include GBM changes to Intel tiling, which could be the root cause. If we end up with the wrong or no tiling, that'd be the kind of thing that would cause this kind of regression.
Labels: Gfx-Guard
Status: Assigned (was: Untriaged)
Kristian, anything here? The perf regression looks like it's still here.
Status: Fixed (was: Assigned)
We've had these regression for a while - since July 2017 and the chromeos changes in question are:

https://crosland.corp.google.com/log/9732.0.0..9735.0.0

suggesting that the minigbm changes regressed something. Looking at the first datapoint after CL:1008867 it looks like we're back to the level we had before the July regression.  Without investigating further, my guess would be that we lost tiling for some ARGB buffers that were allocated as scanout but not actually used for scanout.

Sign in to add a comment