Issue metadata
Sign in to add a comment
|
Location of tree status is confusing |
||||||||||||||||||||||||
Issue descriptionChromium review's PolyGerrit has a "Commit-Queue" box. However, this box is the only thing on the page not related to the CL being viewed. This is confusing, because it can turn red and contain commentary that can appear incidentally related to the CL – or just nonsense (e.g. emoji, slang, in-jokes). In addition, if the explanation string is long, then the text in the box wraps and takes up a lot of space. I have been caught off-guard by this, and have seen one other person be confused by it, too. I'm assuming that we can't enforce that the explanation string for the commit queue is concise and professional. However, it would be nice if the context was made clear. In particular, it would be nice if the UI didn't scream "SOMETHING IS VERY WRONG" when the draft CL has no problems.
,
Jul 11 2017
Ah, interesting. That box has (virtually) nothing to do with the CQ. If someone had set a CQ label on that change, you'd see that it appears between the words "Commit-Queue" and that red box. The words "Commit-Queue" are there as an indication that that is where any CQ+X votes will appear. That box is the tree status (https://chromium-status.appspot.com). It indicates whether the repository is currently accepting commits or not. It does purposefully scream "SOMETHING IS VERY WRONG" because if something has gone so badly wrong that the tree has been closed -- i.e. compile is failing on one of our primary configurations and the sheriffs are investigating -- then you as a person contributing to that tree should probably know about it. If you have an idea for how to better display this information such that it seems less likely to be confused with information about the CL itself, patches are welcome at https://chromium.googlesource.com/infra/gerrit-plugins/chumpdetector/
,
Jul 27 2017
,
Jul 27 2017
,
Jul 27 2017
,
Jan 3 2018
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.
,
Jan 6 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by wyatta@google.com
, Jul 11 2017