New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 749795 link

Starred by 1 user
Status: Duplicate
Merged: issue 749196
Owner:
tapted@chromium.org
Closed: Jan 2018
Cc:
tapted@chromium.org
ellyjo...@chromium.org
linds...@chromium.org
█ shrike@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug
Team-Security-UX

Blocking:
issue 748242


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment

interactive_ui_tests PermissionBubbleInteractiveUITest.CmdWClosesWindow tests time out on 10.13

Project Member Reported by rsesek@chromium.org, Jul 27 2017 
Chrome Version: 5f9df04869c13d09182e36ad8f1c7192e0389214
OS: macOS 10.13 High Sierra

What steps will reproduce the problem?
(1) Run browser_tests on 10.13
(2) The following tests time out:

PermissionBubbleInteractiveUITest.CmdWClosesWindow_Cocoa
PermissionBubbleInteractiveUITest.CmdWClosesWindow_Views

What is the expected result?
Test passes

What happens instead?
Test times out

Please use labels and text to provide additional information.

Job: https://luci-milo.appspot.com/buildbot/chromium.fyi/Chromium%20Mac%2010.13/6
Logs: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FChromium_Mac_10.13%2F6%2F%2B%2Frecipes%2Fsteps%2Finteractive_ui_tests%2F0%2Fstdout

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by tapted@chromium.org, Jul 28 2017

Owner: tapted@chromium.org
Status: Assigned (was: Untriaged)
I've verified this still happens in beta 4 (17A315i)

Performing the steps manually in Canary still works OK, so it's likely something to do with the test..

Comment 2 by tapted@chromium.org, Jul 28 2017

Cc: shrike@chromium.org
Ah, this is another case of NOTIFICATION_BROWSER_CLOSED not being sent out. Same as  Issue 749196 

// There is only one tab. Cmd+w will close it along with the browser window.
IN_PROC_BROWSER_TEST_P(PermissionBubbleInteractiveUITest, CmdWClosesWindow) {
  base::scoped_nsobject<NSWindow> browser_window(
      browser()->window()->GetNativeWindow(), base::scoped_policy::RETAIN);
  EXPECT_TRUE([browser_window isVisible]);

  LOG(INFO) << "Waitinf for close.";
  content::WindowedNotificationObserver observer(
      chrome::NOTIFICATION_BROWSER_CLOSED, content::Source<Browser>(browser()));

  SendAccelerator(ui::VKEY_W, false, false);

  // The actual window close happens via a posted task.
  EXPECT_TRUE([browser_window isVisible]);
  observer.Wait();
  
  LOG(INFO) << "Closed!";
  EXPECT_FALSE([browser_window isVisible]);
}

Comment 3 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 4 by linds...@chromium.org, Jan 29 2018

Cc: linds...@chromium.org ellyjo...@chromium.org
Labels: -Pri-2 Pri-1
Mac CQ will be upgraded to 10.13 over the coming 3-4 weeks. Please see issue 805475 for more details. Please resolve 10.13 blockers asap.

Comment 5 by tapted@chromium.org, Jan 29 2018

Mergedinto: 749196
Status: Duplicate (was: Assigned)
this passes now
►

Sign in to add a comment