Multiple stack-overflow issues in gn_parser_fuzzer |
||||||
Issue descriptionThere are several stack-overflow crashes in GN (see blocking issues). I guess all of these issues may have the same root cause, but not sure. Existing fuzzer is hitting stack-overflow in 66% of runs: https://clusterfuzz.com/v2/performance-report/libFuzzer_gn_parser_fuzzer/libfuzzer_chrome_asan/latest
,
Jul 27 2017
I liked this suggestion: https://bugs.chromium.org/p/chromium/issues/detail?id=648076#c6 But it basically just cuts of parsing in cases where we'd hit the overflow, so adding it didn't seem super useful to me, so I didn't. It's a one-line patch if someone feels like it though!
,
Oct 2 2017
,
Oct 17 2017
,
Oct 18 2017
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/697f302d91e7ad4466416ab22c290c7fea9c6b93 commit 697f302d91e7ad4466416ab22c290c7fea9c6b93 Author: Penny MacNeil <pennymac@chromium.org> Date: Mon Oct 30 21:29:41 2017 [GN fuzzer] Stack overflow fix. Fuzzathon 2017. Bug: 648076 , 749793 , 773426 , 768111 , 754972 , 734401 , 734200 Change-Id: Ic608c5a374252809443a879ad4e2ddf8f6184697 Reviewed-on: https://chromium-review.googlesource.com/736159 Commit-Queue: Penny MacNeil <pennymac@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#512626} [modify] https://crrev.com/697f302d91e7ad4466416ab22c290c7fea9c6b93/tools/gn/parser_fuzzer.cc
,
Oct 31 2017
I'll just let this breathe for a bit Max. Let me know if you see any problems on clusterfuzz in the next couple days. Setting this ticket to Fixed, but not Verified yet.
,
Nov 3 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mmoroz@chromium.org
, Jul 27 2017Blocking: 584819
Cc: och...@chromium.org mbarbe...@chromium.org kcc@chromium.org tanin@chromium.org infe...@chromium.org
Owner: thakis@chromium.org