Fix finally landed for generate build files and not surprisingly tests are broken: https://luci-milo.appspot.com/buildbot/chromium.fyi/Fuchsia/7549 to https://luci-milo.appspot.com/buildbot/chromium.fyi/Fuchsia/7555 MessageTest.ExtendPayloadWithHandlesAttached
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e74c4893950a1c42c843014e2d5271b56d34f529 commit e74c4893950a1c42c843014e2d5271b56d34f529 Author: Wez <wez@chromium.org> Date: Fri Jul 28 21:45:16 2017 Filter out ExtendPayloadWithHandlesAttached test. The test uses RunTestClient(), like the Serialize* tests in the same fixture, which we filter because RunTestClientAndGetExitCode doesn't yet work on Fuchsia. Bug: 749792 Change-Id: I38022a43f5f3b1e6a9a1c7d54c2636382d0ecc43 Reviewed-on: https://chromium-review.googlesource.com/592010 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#490518} [modify] https://crrev.com/e74c4893950a1c42c843014e2d5271b56d34f529/testing/buildbot/filters/fuchsia.mojo_system_unittests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d commit 9736ba78d6c5e04dbbdd993546e0bfd655e2a06d Author: Wez <wez@chromium.org> Date: Thu Aug 10 16:35:36 2017 Implement minimal set of Mojo platform IPC primitives for Fuchsia. Previously we were building Mojo IPC against Fuchsia's POSIX emulation layer, in which key APIs (e.g. sendmsg/resvmsg) are not-implemented. To implement Mojo IPC natively for Fuchsia this CL: - Switches Mojo HandlePassingInformation to map to the Fuchsia-specific base::HandlesToTransferVector (see base/launch_process.h). - Implements the embedder PlatformChannel[Handle|Pair] classes. - Implements the Mojo system Channel class. - Updates the Mojo system core APIs to be aware of Fuchsia handles. - Updates the MultiprocessTestHelper to be aware of Fuchsia. The newly-passing tests are removed from the Fuchsia test filters. Some functionality is notably missing: - We do not yet support passing of POSIX file-descriptors. - Stubs out NamedPlatformHandle APIs with NOTREACHED(). - We do not yet cope with SHOULD_WAIT on write attempts, because the OS doesn't ever actually return that yet (see https://fuchsia.atlassian.net/browse/MG-894). Bug: 740791 , 749792 Change-Id: If5d8f7d7962e89f8cb2008aa55deac276b309a00 Reviewed-on: https://chromium-review.googlesource.com/604008 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Wez <wez@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#493422} [modify] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/mojo/edk/embedder/BUILD.gn [modify] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/mojo/edk/embedder/embedder_unittest.cc [add] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/mojo/edk/embedder/named_platform_handle_utils_fuchsia.cc [modify] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/mojo/edk/embedder/platform_channel_pair.cc [modify] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/mojo/edk/embedder/platform_channel_pair.h [add] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/mojo/edk/embedder/platform_channel_pair_fuchsia.cc [modify] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/mojo/edk/embedder/platform_handle.cc [modify] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/mojo/edk/embedder/platform_handle.h [add] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/mojo/edk/embedder/platform_handle_utils_fuchsia.cc [modify] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/mojo/edk/embedder/platform_shared_buffer.cc [modify] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/mojo/edk/system/BUILD.gn [add] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/mojo/edk/system/channel_fuchsia.cc [modify] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/mojo/edk/system/core.cc [modify] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/mojo/edk/system/message_unittest.cc [modify] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/mojo/edk/system/node_controller.cc [modify] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/mojo/edk/system/node_controller.h [modify] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/mojo/edk/system/platform_wrapper_unittest.cc [modify] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/mojo/edk/test/BUILD.gn [modify] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/mojo/edk/test/multiprocess_test_helper.cc [add] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/mojo/edk/test/test_utils_fuchsia.cc [modify] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/services/service_manager/runner/host/service_process_launcher.cc [modify] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/testing/buildbot/filters/fuchsia.ipc_tests.filter [add] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/testing/buildbot/filters/fuchsia.mojo_common_unittests.filter [modify] https://crrev.com/9736ba78d6c5e04dbbdd993546e0bfd655e2a06d/testing/buildbot/filters/fuchsia.mojo_system_unittests.filter
Comment 1 by w...@chromium.org
, Jul 28 2017Status: Started (was: Available)