Data saver site breakdown disappears on screen rotation |
|||||||
Issue descriptionSteps: 1. Start in landscape mode. 2. Go to data save settings. See the site breakdown. 3. Rotate to portrait. 4. The site breakdown is missing (not WAI?). 5. Rotate back to landscape. 6. The site breakdown is still missing (not WAI?). There is a similar bug if we start in portrait and then rotate (not WAI?).
,
Jul 27 2017
,
Jul 27 2017
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f51b6751b525c24aff5d2f3efc7fa43e592d91d commit 9f51b6751b525c24aff5d2f3efc7fa43e592d91d Author: Megan Jablonski <megjablon@google.com> Date: Tue Aug 01 04:40:29 2017 Data saver site breakdown disappears on screen rotation Fix bug where Data Saver site breakdown disappears on rotation. The site breakdown view was being re-inflated, but the data was not being set again. Bug: 749790 Change-Id: I1d0ea9f9bff8e65dc83116d84291a3ffd452f0b7 Reviewed-on: https://chromium-review.googlesource.com/590765 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#490849} [modify] https://crrev.com/9f51b6751b525c24aff5d2f3efc7fa43e592d91d/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java [modify] https://crrev.com/9f51b6751b525c24aff5d2f3efc7fa43e592d91d/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionStatsPreference.java
,
Aug 1 2017
,
Aug 2 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 7 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4d101223d670c88b0a6423c198efb15e2d67064 commit e4d101223d670c88b0a6423c198efb15e2d67064 Author: Megan Jablonski <megjablon@google.com> Date: Mon Aug 07 18:21:51 2017 Data saver site breakdown disappears on screen rotation Fix bug where Data Saver site breakdown disappears on rotation. The site breakdown view was being re-inflated, but the data was not being set again. TBR=megjablon@google.com (cherry picked from commit 9f51b6751b525c24aff5d2f3efc7fa43e592d91d) Bug: 749790 Change-Id: I1d0ea9f9bff8e65dc83116d84291a3ffd452f0b7 Reviewed-on: https://chromium-review.googlesource.com/590765 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#490849} Reviewed-on: https://chromium-review.googlesource.com/603886 Reviewed-by: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#360} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/e4d101223d670c88b0a6423c198efb15e2d67064/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java [modify] https://crrev.com/e4d101223d670c88b0a6423c198efb15e2d67064/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionStatsPreference.java
,
Aug 7 2017
,
Aug 10 2017
Verified in 61.0.3163.42 build |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 Deleted