New issue
Advanced search Search tips

Issue 749783 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

On-demand update checks failing with 0x8001010E

Project Member Reported by grt@chromium.org, Jul 27 2017

Issue description

The migration to the task scheduler introduced a bug in the on-demand update check. COM calls are failing with RPC_E_WRONG_THREAD on account of them being scheduled on a sequence rather than on a COM STA thread.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9c18a6d62d771a20d35a5de43bfc4b33edbd818

commit c9c18a6d62d771a20d35a5de43bfc4b33edbd818
Author: Greg Thompson <grt@chromium.org>
Date: Fri Jul 28 09:14:30 2017

Run update checks in a COM STA thread.

There's no guarantee that threads in a sequence are initialized into
COM, and running update checks on arbitrary threads as part of a
sequence leads to RPC_E_WRONG_THREAD errors.

BUG= 749783 
R=pkasting@chromium.org

Change-Id: I82338fe8cf237e616a17c89cda569b6b90867b67
Reviewed-on: https://chromium-review.googlesource.com/590229
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490333}
[modify] https://crrev.com/c9c18a6d62d771a20d35a5de43bfc4b33edbd818/chrome/browser/google/google_update_win.cc
[modify] https://crrev.com/c9c18a6d62d771a20d35a5de43bfc4b33edbd818/chrome/browser/google/google_update_win.h
[modify] https://crrev.com/c9c18a6d62d771a20d35a5de43bfc4b33edbd818/chrome/browser/google/google_update_win_unittest.cc

Comment 2 by grt@chromium.org, Jul 28 2017

Status: Fixed (was: Started)
This will need a merge. I'll request one after it ships on canary.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.

Comment 4 by grt@chromium.org, Jul 31 2017

Labels: Merge-Request-61
Everything looks good on canary. Requesting merge to M61.
Labels: -Merge-TBD
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 1 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 1 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1baf7cb5a08f49cf8068634f04f06f445e63ee30

commit 1baf7cb5a08f49cf8068634f04f06f445e63ee30
Author: Greg Thompson <grt@chromium.org>
Date: Tue Aug 01 13:59:29 2017

Run update checks in a COM STA thread.

There's no guarantee that threads in a sequence are initialized into
COM, and running update checks on arbitrary threads as part of a
sequence leads to RPC_E_WRONG_THREAD errors.

BUG= 749783 
R=pkasting@chromium.org
TBR=grt@chromium.org

(cherry picked from commit c9c18a6d62d771a20d35a5de43bfc4b33edbd818)

Change-Id: I82338fe8cf237e616a17c89cda569b6b90867b67
Reviewed-on: https://chromium-review.googlesource.com/590229
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490333}
Reviewed-on: https://chromium-review.googlesource.com/595971
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#208}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/1baf7cb5a08f49cf8068634f04f06f445e63ee30/chrome/browser/google/google_update_win.cc
[modify] https://crrev.com/1baf7cb5a08f49cf8068634f04f06f445e63ee30/chrome/browser/google/google_update_win.h
[modify] https://crrev.com/1baf7cb5a08f49cf8068634f04f06f445e63ee30/chrome/browser/google/google_update_win_unittest.cc

Sign in to add a comment