New issue
Advanced search Search tips

Issue 749778 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug

Blocking:
issue 701833



Sign in to add a comment

Element highlighting does not work for UI DevTools

Project Member Reported by tdander...@chromium.org, Jul 27 2017

Issue description

When using UI DevTools on Windows OS, hovering over elements of the DOM tree does not highlight the corresponding element in the UI being inspected.

 
Description: Show this description
Blocking: 701833
Labels: -OS-Linux
FTR this is observed with a remote connection. The Chrome instance being inspected is Win7 ToT at revision #489647, and the UI DevTools FE is open in Win7 canary 62.0.3169.0.


Possible cause of problem: On Windows OS, there can be more than one RootWindow (unlike Ash), so it is possible that we are placing the highlight layer on the wrong root window.
Components: -UI Platform>DevTools
Labels: -M-62 M-72 OS-Linux
Owner: weili@chromium.org
Status: Started (was: Assigned)
Summary: Element highlighting does not work for UI DevTools (was: Element highlighting does not work for UI DevTools on Win)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f13641402a99df47ca2b08cc5d4c50e09b7da80c

commit f13641402a99df47ca2b08cc5d4c50e09b7da80c
Author: Wei Li <weili@chromium.org>
Date: Fri Oct 05 18:16:57 2018

[UI Devtools] Fix missing element highlight

UI Devtools use overlay model to support element highlight. However,
in remote debugging configuration, the highlight is handled by
screencast module which is not supported in current UI Devtools.
This CL fixes this by using local debugging on local sessions.

BUG= 749778 

Change-Id: Idc81ff27e05d5b95e72748873b933b1ecdb80ad2
Reviewed-on: https://chromium-review.googlesource.com/c/1262960
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597200}
[modify] https://crrev.com/f13641402a99df47ca2b08cc5d4c50e09b7da80c/components/ui_devtools/devtools_server.cc

Status: Fixed (was: Started)

Sign in to add a comment