Issue metadata
Sign in to add a comment
|
Make memory_instrumentation extensions aware |
||||||||||||||||||||||||
Issue descriptionCurrently, the new memory_instrumentation system currently sends memory data for all renderer processes in the same metrics, while the memory usage of extension renderers is "quiet" different from a Tab renderer process. The old system was able to track this information, but as we moved to a centralized approach, we currently can only distinguish process by their major type only (i.e. browser vs. renderer). Making memory_instrumentation aware of the extensions would improve the metrics quality substantially.
,
Jul 27 2017
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b746ecb08bed305c7d02deaa718de43ce8d6d847 commit b746ecb08bed305c7d02deaa718de43ce8d6d847 Author: Fadi Meawad <fmeawad@chromium.org> Date: Wed Aug 23 04:04:27 2017 [Memory UMA] Make memory uma/ukm extension aware The old memory uma distinguished between extension render process and non-extension ones. This CL reintroduces that in the new memory UMAs. For UKM, it add the number of extensions in the process instead. For both, We only account for true extensions, and we exclude hosted apps. Bug: chromium:749775 Change-Id: I5e2dda7d6fa4420af7f63f4cbace09f5f7cf9309 Reviewed-on: https://chromium-review.googlesource.com/611316 Commit-Queue: Fadi Meawad <fmeawad@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#496583} [modify] https://crrev.com/b746ecb08bed305c7d02deaa718de43ce8d6d847/chrome/browser/metrics/process_memory_metrics_emitter.cc [modify] https://crrev.com/b746ecb08bed305c7d02deaa718de43ce8d6d847/chrome/browser/metrics/process_memory_metrics_emitter.h [modify] https://crrev.com/b746ecb08bed305c7d02deaa718de43ce8d6d847/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc [modify] https://crrev.com/b746ecb08bed305c7d02deaa718de43ce8d6d847/chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc [modify] https://crrev.com/b746ecb08bed305c7d02deaa718de43ce8d6d847/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/b746ecb08bed305c7d02deaa718de43ce8d6d847/tools/metrics/ukm/ukm.xml
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbf276f018ea6ad8efbade99908eefd34aa1f73d commit fbf276f018ea6ad8efbade99908eefd34aa1f73d Author: Fadi Meawad <fmeawad@chromium.org> Date: Fri Aug 25 19:23:27 2017 [Memory UMA] Fix a race condition when checking if an extension is hosted The reason for the race condition is ExtensionSet::GetID can return a null pointer. This can happen if the extension we are checking was terminated before we checked if it was hosted or not. Fix: If we do not have an extension object, ignore that extension entry. Bug: chromium:758940, chromium:749775 Change-Id: Ia029389d0628e435ef5975fbd47caa6c12fdf778 Reviewed-on: https://chromium-review.googlesource.com/635666 Reviewed-by: Erik Chen <erikchen@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Fadi Meawad <fmeawad@chromium.org> Cr-Commit-Position: refs/heads/master@{#497490} [modify] https://crrev.com/fbf276f018ea6ad8efbade99908eefd34aa1f73d/chrome/browser/metrics/process_memory_metrics_emitter.cc
,
Aug 29 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by erikc...@chromium.org
, Jul 27 2017