Issue metadata
Sign in to add a comment
|
[FATAL:ClassicPendingScript.cpp(172)] Check failed: GetResource()->IsLoaded(). in telemetry_perf_unittests |
||||||||||||||||||||||
Issue descriptionEncountered this in CQ for an unrelated CL. https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.android%2Fandroid_n5x_swarming_rel%2F230492%2F%2B%2Frecipes%2Fsteps%2Ftelemetry_perf_unittests__with_patch__on_Android%2F0%2Fstdout Stack Trace: RELADDR FUNCTION FILE:LINE 00000000012ff5df cc::LayerTreeHostImpl::MouseUp() /b/c/b/android_n5x_swarming_rel/src/cc/trees/layer_tree_host_impl.cc:3664 0000000004751c1b WTF::HashTableAddResult<WTF::HashTable<unsigned long, WTF::KeyValuePair<unsigned long, blink::Member<blink::ScriptPromiseResolver> >, WTF::KeyValuePairKeyExtractor, WTF::IntHash<unsigned long>, WTF::HashMapValueTraits<WTF::UnsignedWithZeroKeyHashTraits<unsigned long>, WTF::HashTraits<blink::Member<blink::ScriptPromiseResolver> > >, WTF::UnsignedWithZeroKeyHashTraits<unsigned long>, blink::HeapAllocator>, WTF::KeyValuePair<unsigned long, blink::Member<blink::ScriptPromiseResolver> > > WTF::HashTable<unsigned long, WTF::KeyValuePair<unsigned long, blink::Member<blink::ScriptPromiseResolver> >, WTF::KeyValuePairKeyExtractor, WTF::IntHash<unsigned long>, WTF::HashMapValueTraits<WTF::UnsignedWithZeroKeyHashTraits<unsigned long>, WTF::HashTraits<blink::Member<blink::ScriptPromiseResolver> > >, WTF::UnsignedWithZeroKeyHashTraits<unsigned long>, blink::HeapAllocator>::insert<WTF::HashMapTranslator<WTF::HashMapValueTraits<WTF::UnsignedWithZeroKeyHashTraits<unsigned long>, WTF::HashTraits<blink::Member<blink::ScriptPromiseResolver> > >, WTF::IntHash<unsigned long> >, unsigned long&, blink::ScriptPromiseResolver*&>(unsigned long&, blink::ScriptPromiseResolver*&) /b/c/b/android_n5x_swarming_rel/src/third_party/WebKit/Source/platform/wtf/HashTable.h:1245 00000000047ec507 media::GpuVideoEncodeAccelerator::NotifyError(media::VideoEncodeAccelerator::Error) /b/c/b/android_n5x_swarming_rel/src/media/gpu/ipc/service/gpu_video_encode_accelerator.cc:230 v------> base::Callback<base::internal::MakeUnboundRunTypeImpl<void (*)(std::__ndk1::unique_ptr<base::SharedMemory, std::__ndk1::default_delete<base::SharedMemory> >), base::internal::PassedWrapper<std::__ndk1::unique_ptr<base::SharedMemory, std::__ndk1::default_delete<base::SharedMemory> > > >::Type, (base::internal::CopyMode)1, (base::internal::RepeatMode)1> base::Bind<void (*)(std::__ndk1::unique_ptr<base::SharedMemory, std::__ndk1::default_delete<base::SharedMemory> >), base::internal::PassedWrapper<std::__ndk1::unique_ptr<base::SharedMemory, std::__ndk1::default_delete<base::SharedMemory> > > >(void (*&&)(std::__ndk1::unique_ptr<base::SharedMemory, std::__ndk1::default_delete<base::SharedMemory> >), base::internal::PassedWrapper<std::__ndk1::unique_ptr<base::SharedMemory, std::__ndk1::default_delete<base::SharedMemory> > >&&) /b/c/b/android_n5x_swarming_rel/src/base/bind.h:77 00000000047ecb1f media::GpuVideoEncodeAccelerator::CreateEncodeFrameOnEncoderWorker(AcceleratedVideoEncoderMsg_Encode_Params const&) /b/c/b/android_n5x_swarming_rel/src/media/gpu/ipc/service/gpu_video_encode_accelerator.cc:398 00000000047ef7c3 extensions_v8::BenchmarkingWrapper::BenchmarkingWrapper() /b/c/b/android_n5x_swarming_rel/src/chrome/renderer/benchmarking_extension.cc:51 00000000047eed2f bool IPC::MessageT<GpuCommandBufferMsg_GetChannelToken_Meta, std::__ndk1::tuple<>, std::__ndk1::tuple<base::UnguessableToken> >::DispatchDelayReply<media::MediaGpuChannelFilter, void, void (media::MediaGpuChannelFilter::*)(IPC::Message*)>(IPC::Message const*, media::MediaGpuChannelFilter*, void*, void (media::MediaGpuChannelFilter::*)(IPC::Message*)) /b/c/b/android_n5x_swarming_rel/src/ipc/ipc_message_templates.h:193 v------> cc::TilingSetRasterQueueAll::OnePriorityRectIterator::OnePriorityRectIterator() /b/c/b/android_n5x_swarming_rel/src/cc/tiles/tiling_set_raster_queue_all.cc:162 v------> cc::TilingSetRasterQueueAll::PendingVisibleTilingIterator::PendingVisibleTilingIterator() /b/c/b/android_n5x_swarming_rel/src/cc/tiles/tiling_set_raster_queue_all.h:77 00000000012de91b cc::TilingSetRasterQueueAll::TilingIterator::TilingIterator() /b/c/b/android_n5x_swarming_rel/src/cc/tiles/tiling_set_raster_queue_all.cc:364 0000000003467893 enterprise_management::CloudPolicySettings::SerializeWithCachedSizes(google::protobuf::io::CodedOutputStream*) const /b/c/b/android_n5x_swarming_rel/src/out/Release/gen/components/policy/proto/cloud_policy.pb.cc:4558 0000000003465f2b enterprise_management::CloudPolicySettings::mutable_incognitoenabled() /b/c/b/android_n5x_swarming_rel/src/out/Release/gen/components/policy/proto/cloud_policy.pb.h:2467 v------> cc::TilingSetRasterQueueAll::OnePriorityRectIterator::OnePriorityRectIterator() /b/c/b/android_n5x_swarming_rel/src/cc/tiles/tiling_set_raster_queue_all.cc:162 v------> cc::TilingSetRasterQueueAll::PendingVisibleTilingIterator::PendingVisibleTilingIterator() /b/c/b/android_n5x_swarming_rel/src/cc/tiles/tiling_set_raster_queue_all.h:77 00000000012de91b cc::TilingSetRasterQueueAll::TilingIterator::TilingIterator() /b/c/b/android_n5x_swarming_rel/src/cc/tiles/tiling_set_raster_queue_all.cc:364 000000000130a0a3 cc::LayerTreeImpl::GetAllPrioritizedTilesForTracing(std::__ndk1::vector<cc::PrioritizedTile, std::__ndk1::allocator<cc::PrioritizedTile> >*) const /b/c/b/android_n5x_swarming_rel/src/cc/trees/layer_tree_impl.cc:1449 v------> std::__ndk1::__constrain_hash(unsigned long, unsigned long) /b/c/b/android_n5x_swarming_rel/src/third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include/__hash_table:77 v------> std::__ndk1::__hash_const_iterator<std::__ndk1::__hash_node<std::__ndk1::__hash_value_type<int, cc::LayerImpl*>, void*>*> std::__ndk1::__hash_table<std::__ndk1::__hash_value_type<int, cc::LayerImpl*>, std::__ndk1::__unordered_map_hasher<int, std::__ndk1::__hash_value_type<int, cc::LayerImpl*>, std::__ndk1::hash<int>, true>, std::__ndk1::__unordered_map_equal<int, std::__ndk1::__hash_value_type<int, cc::LayerImpl*>, std::__ndk1::equal_to<int>, true>, std::__ndk1::allocator<std::__ndk1::__hash_value_type<int, cc::LayerImpl*> > >::find<int>(int const&) const /b/c/b/android_n5x_swarming_rel/src/third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include/__hash_table:2053 v------> std::__ndk1::unordered_map<int, cc::LayerImpl*, std::__ndk1::hash<int>, std::__ndk1::equal_to<int>, std::__ndk1::allocator<std::__ndk1::pair<int const, cc::LayerImpl*> > >::find(int const&) const /b/c/b/android_n5x_swarming_rel/src/third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include/unordered_map:972 v------> cc::LayerTreeImpl::LayerById(int) const /b/c/b/android_n5x_swarming_rel/src/cc/trees/layer_tree_impl.cc:1188 v------> cc::LayerTreeImpl::InnerViewportScrollLayer() const /b/c/b/android_n5x_swarming_rel/src/cc/trees/layer_tree_impl.h:250 000000000130a37b cc::LayerTreeImpl::DistributeRootScrollOffset(gfx::ScrollOffset const&) /b/c/b/android_n5x_swarming_rel/src/cc/trees/layer_tree_impl.cc:1496 v------> gfx::ScrollOffset::SetToMin(gfx::ScrollOffset const&) /b/c/b/android_n5x_swarming_rel/src/ui/gfx/geometry/scroll_offset.h:61 000000000130a603 cc::LayerTreeImpl::DistributeRootScrollOffset(gfx::ScrollOffset const&) /b/c/b/android_n5x_swarming_rel/src/cc/trees/layer_tree_impl.cc:1509 000000000130c71f std::__ndk1::__hash_table<std::__ndk1::__hash_value_type<cc::ElementId, float>, std::__ndk1::__unordered_map_hasher<cc::ElementId, std::__ndk1::__hash_value_type<cc::ElementId, float>, cc::ElementIdHash, true>, std::__ndk1::__unordered_map_equal<cc::ElementId, std::__ndk1::__hash_value_type<cc::ElementId, float>, std::__ndk1::equal_to<cc::ElementId>, true>, std::__ndk1::allocator<std::__ndk1::__hash_value_type<cc::ElementId, float> > >::__node_insert_unique(std::__ndk1::__hash_node<std::__ndk1::__hash_value_type<cc::ElementId, float>, void*>*) /data/app/org.chromium.chrome-1/base.apk v------> std::__ndk1::unique_ptr<cc::LayerTreeImpl, std::__ndk1::default_delete<cc::LayerTreeImpl> >::get() const /b/c/b/android_n5x_swarming_rel/src/third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include/memory:2609 v------> cc::LayerTreeHostImpl::recycle_tree() /b/c/b/android_n5x_swarming_rel/src/cc/trees/layer_tree_host_impl.h:434 0000000001309c7f cc::LayerTreeImpl::IsRecycleTree() const /b/c/b/android_n5x_swarming_rel/src/cc/trees/layer_tree_impl.cc:1357 v------> gfx::operator==(gfx::Vector2dF const&, gfx::Vector2dF const&) /b/c/b/android_n5x_swarming_rel/src/ui/gfx/geometry/vector2d_f.h:71 0000000001335cf7 cc::TransformNode::operator==(cc::TransformNode const&) const /b/c/b/android_n5x_swarming_rel/src/cc/trees/transform_node.cc:82 0000000005375f2f .LC0 /data/app/org.chromium.chrome-1/base.apk 000000000350e34f TemplateURLService::TemplateURLService(PrefService*, std::__ndk1::unique_ptr<SearchTermsData, std::__ndk1::default_delete<SearchTermsData> >, scoped_refptr<KeywordWebDataService> const&, std::__ndk1::unique_ptr<TemplateURLServiceClient, std::__ndk1::default_delete<TemplateURLServiceClient> >, GoogleURLTracker*, rappor::RapporServiceImpl*, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) /b/c/b/android_n5x_swarming_rel/src/components/search_engines/template_url_service.cc:262 000000000350ea4f TemplateURLService::~TemplateURLService() /b/c/b/android_n5x_swarming_rel/src/components/search_engines/template_url_service.cc:292 v------> v8::internal::GCTracer::AverageSpeed(v8::base::RingBuffer<std::__ndk1::pair<unsigned long, double> > const&, std::__ndk1::pair<unsigned long, double> const&, double) /b/c/b/android_n5x_swarming_rel/src/v8/src/heap/gc-tracer.cc:753 v------> v8::internal::GCTracer::AverageSpeed(v8::base::RingBuffer<std::__ndk1::pair<unsigned long, double> > const&) /b/c/b/android_n5x_swarming_rel/src/v8/src/heap/gc-tracer.cc:760 v------> v8::internal::GCTracer::CompactionSpeedInBytesPerMillisecond() const /b/c/b/android_n5x_swarming_rel/src/v8/src/heap/gc-tracer.cc:795 00000000022ea3c3 v8::internal::GCTracer::PrintNVP() const /b/c/b/android_n5x_swarming_rel/src/v8/src/heap/gc-tracer.cc:730 v------> std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >::basic_string(char const*) /b/c/b/android_n5x_swarming_rel/src/third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include/string:2049 000000000350dc5b TemplateURLPrepopulateData::(anonymous namespace)::GetCountryIDFromPrefs(PrefService*) /b/c/b/android_n5x_swarming_rel/src/components/search_engines/template_url_prepopulate_data.cc:620 0000000000defadb <unknown>
,
Jul 27 2017
In the link I provided above, it looks like we hit this exact same stack 4 times. That makes it less likely that this was random memory corruption. Hm.
,
Jul 27 2017
Perhaps Issue 692856 ? Which CL causes the CHECK failure?
,
Jul 27 2017
,
Jul 27 2017
Thanks! It seems the DCHECK() os failing flakily on android_n5x_swarming_rel. (Another example: https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/230613 )
,
Jul 27 2017
DCHECK() failure in benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile.load:news:cnn ? Flakiness Dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=telemetry_perf_unittests&tests=benchmarks%2Fsystem_health_smoke_test%2FSystemHealthBenchmarkSmokeTest%2Fsystem_health%2Fmemory_mobile%2Fload%3Anews%3Acnn
,
Jul 27 2017
,
Jul 31 2017
,
Jul 31 2017
Also quite flaky on Linux telemetry_perf_unittests: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/513569 https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/513565 https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/513564 https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/513562
,
Jul 31 2017
,
Jul 31 2017
Issue 749886 has been merged into this issue.
,
Jul 31 2017
,
Jul 31 2017
,
Jul 31 2017
,
Jul 31 2017
The root cause is Issue 692856 , but Issue 692856 will take some time to fix (2 weeks?). I'm planning to fix before M-62 branch, but probably I have to fix the recent increase of the DCHECK() failures on the bots (does this also means increased DCHECK() failure in the wild?). Currently culprit is not yet found though.
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/408e5cd80fe4036687691479b1451cc219d3fdb2 commit 408e5cd80fe4036687691479b1451cc219d3fdb2 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Tue Aug 01 00:50:22 2017 [Sheriff] Disable memory_desktop.browse:news:hackernews Temporarily disable the test to clear the bot errors, because the test is failing frequently/flakily due to crbug.com/749773 . TBR=nednguyen@chromium.org, adithyas@chromium.org, yutak@chromium.org NOTRY=true Bug: 749773 Change-Id: Ib0f919c243450c64a168f268d8e365646f2936ff Reviewed-on: https://chromium-review.googlesource.com/595239 Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#490828} [modify] https://crrev.com/408e5cd80fe4036687691479b1451cc219d3fdb2/tools/perf/benchmarks/system_health_smoke_test.py
,
Aug 1 2017
Issue 750958 has been merged into this issue.
,
Aug 1 2017
imgur test is also failing after Comment #17. https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/514314 Disabling it too.
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52c04f8b3d321904b4fbac3fa227f808d296f63b commit 52c04f8b3d321904b4fbac3fa227f808d296f63b Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Tue Aug 01 02:06:35 2017 [Sheriff] Disable memory_desktop.browse:media:imgur Temporarily disable the test to clear the bot errors, because the test is failing frequently/flakily due to crbug.com/749773 . TBR=nednguyen@chromium.org, adithyas@chromium.org, yutak@chromium.org NOTRY=true Bug: 749773 Change-Id: I6c4540ef2a357b47c4c9dc00ced499196bc7a566 Reviewed-on: https://chromium-review.googlesource.com/595254 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#490835} [modify] https://crrev.com/52c04f8b3d321904b4fbac3fa227f808d296f63b/tools/perf/benchmarks/system_health_smoke_test.py
,
Aug 1 2017
,
Aug 1 2017
,
Aug 1 2017
Bisected. The first bad commit for memory_desktop.browse:news:hackernews was https://chromium-review.googlesource.com/c/580618
,
Aug 1 2017
That is +xunjieli CL to move this benchmark to wprgo. This is a change in the test infrastructure, so I can imagine whatever causes this check to fail was always there but recently got exposed by the change?
,
Aug 1 2017
> I can imagine whatever causes this check to fail was always there but recently got exposed by the change? Yes (The root cause is Issue 692856 , highly timing-dependent). Perhaps the change in the test infrastructure causes timing or content changes, which can expose the exising issue?
,
Aug 1 2017
> Perhaps the change in the test infrastructure causes timing or content changes, which can expose the exising issue? There's definitely a timing change because the WPR backend is different. I don't think there's change in contents (html and js files should be the same). I just took the old recordings and converted them to the new format used by WprGo. I am not sure how easy it is to reproduce this locally. You can do: tools/perf/run_benchmark <name of benchmark> --browser=<custom build> --story-filter=memory_desktop.browse:news:hackernews
,
Aug 2 2017
Another instance of this failure: https://luci-milo.appspot.com/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/515476 on unrelated CL: https://chromium-review.googlesource.com/596679 The stack trace seems reasonable. [1:1:0801/144013.632107:FATAL:ClassicPendingScript.cpp(172)] Check failed: GetResource()->IsLoaded(). #0 0x7f9a7055c6f7 base::debug::StackTrace::StackTrace() #1 0x7f9a70576421 logging::LogMessage::~LogMessage() #2 0x7f9a743f56e2 blink::ClassicPendingScript::GetSource() #3 0x7f9a7508ea96 blink::ScriptLoader::ExecuteScriptBlock() #4 0x7f9a7508efbe blink::ScriptLoader::Execute() #5 0x7f9a744b6e5a blink::ScriptRunner::ExecuteAsyncTask() #6 0x7f9a744b5fb8 blink::ScriptRunner::ExecuteTask() #7 0x7f9a7055ce2b base::debug::TaskAnnotator::RunTask() #8 0x7f9a700a3345 blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue() #9 0x7f9a700a0f64 blink::scheduler::TaskQueueManager::DoWork() #10 0x7f9a6e8a088e _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN5media15DecoderSelectorILNS4_13DemuxerStream4TypeE1EEEFvbERKNS_7WeakPtrIS8_EEJbEEEvOT_OT0_DpOT1_ #11 0x7f9a7055ce2b base::debug::TaskAnnotator::RunTask() #12 0x7f9a7057d42a base::MessageLoop::RunTask() #13 0x7f9a7057d762 base::MessageLoop::DeferOrRunPendingTask() #14 0x7f9a7057da44 base::MessageLoop::DoWork() #15 0x7f9a7057f0c0 base::MessagePumpDefault::Run() #16 0x7f9a7057cfef base::MessageLoop::Run() #17 0x7f9a705a62a7 base::RunLoop::Run() #18 0x7f9a7327b36d content::RendererMain() #19 0x7f9a701bab8a content::RunZygote() #20 0x7f9a701bb46b content::RunNamedProcessTypeMain() #21 0x7f9a701bbda8 content::ContentMainRunnerImpl::Run() #22 0x7f9a701c65f6 service_manager::Main() #23 0x7f9a701ba852 content::ContentMain() #24 0x7f9a6e75a194 ChromeMain #25 0x7f9a6d3b2f45 __libc_start_main #26 0x7f9a6e759ff0 <unknown>
,
Aug 2 2017
> #26 Thanks for info! I can reproduce this locally (once per 2~3 runs?). > #27 Oh, failing on benchmarks.benchmark_smoke_unittest.BenchmarkSmokeTest.tab_switching.typical_25.
,
Aug 5 2017
,
Aug 7 2017
I just encountered this problem again on the CQ. """ [1:1:0807/161754.355067:FATAL:ClassicPendingScript.cpp(174)] Check failed: GetResource()->IsLoaded(). #0 0x7f953ca76547 base::debug::StackTrace::StackTrace() #1 0x7f953ca90211 logging::LogMessage::~LogMessage() #2 0x7f9540934252 blink::ClassicPendingScript::GetSource() #3 0x7f95415cdd47 blink::ScriptLoader::ExecuteScriptBlock() #4 0x7f95415ce25e blink::ScriptLoader::Execute() #5 0x7f95409f5ef5 blink::ScriptRunner::ExecuteAsyncTask() #6 0x7f95409f5058 blink::ScriptRunner::ExecuteTask() #7 0x7f953ca76c7b base::debug::TaskAnnotator::RunTask() #8 0x7f953c5b9795 blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue() #9 0x7f953c5b73b4 blink::scheduler::TaskQueueManager::DoWork() #10 0x7f953ad8fdce _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN5media15DecoderSelectorILNS4_13DemuxerStream4TypeE1EEEFvbERKNS_7WeakPtrIS8_EEJbEEEvOT_OT0_DpOT1_ #11 0x7f953ca76c7b base::debug::TaskAnnotator::RunTask() #12 0x7f953ca9735a base::MessageLoop::RunTask() #13 0x7f953ca9768b base::MessageLoop::DeferOrRunPendingTask() #14 0x7f953ca97974 base::MessageLoop::DoWork() #15 0x7f953ca99030 base::MessagePumpDefault::Run() #16 0x7f953ca96d6a base::MessageLoop::Run() #17 0x7f953cac04a7 base::RunLoop::Run() #18 0x7f953f7a7b9f content::RendererMain() #19 0x7f953c6d2bf9 content::RunZygote() #20 0x7f953c6d34ea content::RunNamedProcessTypeMain() #21 0x7f953c6d3e40 content::ContentMainRunnerImpl::Run() #22 0x7f953c6df6a3 service_manager::Main() #23 0x7f953c6d28a2 content::ContentMain() #24 0x7f953ac485bc ChromeMain #25 0x7f953989ef45 __libc_start_main #26 0x7f953ac48410 <unknown> """ https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Flinux_chromium_rel_ng%2F519367%2F%2B%2Frecipes%2Fsteps%2Ftelemetry_perf_unittests__with_patch_%2F0%2Fstdout Is there code that can be reverted/disabled until this problem can be resolved? Please do so as soon as possible.
,
Aug 8 2017
,
Aug 8 2017
,
Aug 8 2017
This CHECK failure is causing many test failures and consequent retries on linux_chromium_rel_ng, one of Chromium's main tryservers. This is preventing valid CLs from landing, and significantly increasing the load on the CQ. Observe that there are many failures of telemetry_perf_unittests on this bot: https://luci-milo.appspot.com/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/?limit=200 and note that for example this CL has retried that bot something like 8 times: https://chromium-review.googlesource.com/c/582247 Only a few failures: https://luci-milo.appspot.com/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/519174 https://luci-milo.appspot.com/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/518134 https://luci-milo.appspot.com/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/518057 https://luci-milo.appspot.com/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/519313 I'm sorry, but this is now an emergency. Raising to P0. Please drop all other work and figure out how to get Chrome back to a working state. If this means reverting earlier patches from Issue 692856 , please do so. Note that changing the CHECKs to DCHECKs will not work because the trybots build Release mode with dcheck_always_on=true. Thanks.
,
Aug 8 2017
,
Aug 8 2017
I misdiagnosed the cause of some of the telemetry_perf_unittests timeouts; nednguyen@ tracked it down to a bad test case that was recently checked in, and filed Issue 753542 about it. Downgrading back to P1, as it's expected that disabling that particular test will likely get this bot back to acceptably good health.
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/faad2ba6d3dfbb4e44cdfba0b4bfaeaa47fba244 commit faad2ba6d3dfbb4e44cdfba0b4bfaeaa47fba244 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Fri Aug 18 23:03:43 2017 Do not revalidate ScriptResource while it has clients This is to suppress revalidation until ClassicPendingScript::GetSource() to avoid DCHECK() failure there. In the case of ClassicPendingScript, RemoveClient() is called in ResourceOwner::SetResource(nullptr) in ClassicPendingScript::DisposeInternal() in PendingScript::Dispose() in ScriptLoader::ExecuteScriptBlock() just after ClassicPendingScript::GetSource(). In other ScriptResourceClient subclasses (WorkletScriptLoader and ModuleScriptFetcher), RemoveClient() is called in NotifyFinished(), and therefore this CL doesn't affect the revalidation behavior so much. Bug: 692856 , 749773 Change-Id: I28cda31b8c103059fa2e05ef0ad38c9a95e11776 Reviewed-on: https://chromium-review.googlesource.com/620272 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#495728} [modify] https://crrev.com/faad2ba6d3dfbb4e44cdfba0b4bfaeaa47fba244/third_party/WebKit/Source/core/loader/resource/ScriptResource.cpp [modify] https://crrev.com/faad2ba6d3dfbb4e44cdfba0b4bfaeaa47fba244/third_party/WebKit/Source/core/loader/resource/ScriptResource.h
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ebf13ab437d390d8ceeb7e36881fc690479f976 commit 8ebf13ab437d390d8ceeb7e36881fc690479f976 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Mon Aug 21 17:45:24 2017 Re-enable tests disabled due to Issue 749773 Because https://chromium-review.googlesource.com/620272 fixes the crashing Issue 749773 , this CL re-enables the tests that were disabled due to the crash. Bug: 749773 , 749918 Change-Id: Icd69fe32fc58c112a87726cadd15647ab1109653 Reviewed-on: https://chromium-review.googlesource.com/623910 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#495980} [modify] https://crrev.com/8ebf13ab437d390d8ceeb7e36881fc690479f976/tools/perf/benchmarks/system_health_smoke_test.py
,
Aug 21 2017
,
Aug 22 2017
No related crashes reported to crbug, sheriff-o-matic, no related telemetry_perf_unittests in https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel?numbuilds=200 after the tests are enabled in Comment #37. Closing as fixed.
,
Jan 24 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by erikc...@chromium.org
, Jul 27 2017