Issue metadata
Sign in to add a comment
|
Compilation for GTK2 fails
Reported by
franksp...@gmail.com,
Jul 27 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36 Steps to reproduce the problem: Flag "use_gtk3=false" when compiling What is the expected behavior? Compilation succeeds What went wrong? "FAILED: obj/chrome/browser/ui/libgtkui/libgtk2ui/gtk_ui.o" Did this work before? Yes 59.0.3071.115 Chrome version: 60.0.3112.78 Channel: n/a OS Version: Flash Version: Shockwave Flash 26.0 r0 I appreciate that many people want GTK3, but for those of us who don't, it would be nice to still have the choice of continuing to use GTK2.
,
Jul 27 2017
I think they're different issues
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca407201886875966db91d55c403fe0be3f0f4ca commit ca407201886875966db91d55c403fe0be3f0f4ca Author: Tom Anderson <thomasanderson@chromium.org> Date: Fri Jul 28 00:32:42 2017 Fix GTK2 build R=erg@chromium.org BUG= 749770 Change-Id: If30b1d7e64998d78fb4e2635540ddfe922661391 Reviewed-on: https://chromium-review.googlesource.com/589826 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#490162} [modify] https://crrev.com/ca407201886875966db91d55c403fe0be3f0f4ca/chrome/browser/ui/libgtkui/gtk_ui.cc
,
Jul 28 2017
,
Jul 28 2017
Tom, thank you so much for the quick fix!
,
Jul 28 2017
Wow. Thank you! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by manoranj...@chromium.org
, Jul 27 2017