Migrate dom-distiller from github to gerrit |
||
Issue descriptionTurns out that chromium/dom-distiller is actually a mirror of github.com/chromium/dom-distiller. We will reverse that mirroring and enable gerrit review for the project. When we get to the right point, here's the CL to make gerrit the default: https://chromium-review.googlesource.com/c/587973/ (can't be landed yet because Submit is blocked by the copy config).
,
Sep 28 2017
This is now done! Both dom-distiller and dom-distiller-dist are now being mirrored from GoB to GitHub, and have appropriate permissions set up on the GoB side to allow development and packaging to continue as normal.
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2de3c97f623cb68017c85060842bb2f2518b926a commit 2de3c97f623cb68017c85060842bb2f2518b926a Author: Aaron Gable <agable@chromium.org> Date: Thu Sep 28 04:53:40 2017 Update DEPS to reference dom-distiller-dist's new home R=mdjones@chromium.org Bug: 749769 Change-Id: If643b7fb385d6406882f7fdee37fd795c4b7cb8f Reviewed-on: https://chromium-review.googlesource.com/688227 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#504904} [modify] https://crrev.com/2de3c97f623cb68017c85060842bb2f2518b926a/DEPS
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/667369731fdcdcb65b6a38b8178d8abe2cd20551 commit 667369731fdcdcb65b6a38b8178d8abe2cd20551 Author: Matthew Jones <mdjones@chromium.org> Date: Thu Sep 28 20:51:58 2017 Update dom-distiller script for new dist repo Dom-distiller is moving to use gerrit and the dist-roll script references need to be updated. The github repos still exist and are mirrored versions of ones hosted by google. BUG= 749769 Change-Id: I99404c9097bb22f3cca5f233d2d1e8fb658d9375 Reviewed-on: https://chromium-review.googlesource.com/687991 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#505149} [modify] https://crrev.com/667369731fdcdcb65b6a38b8178d8abe2cd20551/third_party/dom_distiller_js/update_domdistiller_js.sh
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb592fb15ca50171c3a3d45225405010cdb933b8 commit eb592fb15ca50171c3a3d45225405010cdb933b8 Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Mon Oct 16 17:32:20 2017 Fix bug ID handling in dom-distiller script Update update_domdistiller_js.sh to take both bug ID conventions in Rietveld and Gerrit, and emit in the Gerrit convention. Bug: 749769 Change-Id: I2ef06a894164159282e5f486bcf657297e04ffaf Reviewed-on: https://chromium-review.googlesource.com/720199 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#509090} [modify] https://crrev.com/eb592fb15ca50171c3a3d45225405010cdb933b8/third_party/dom_distiller_js/update_domdistiller_js.sh
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/dom-distiller/+/38037b3482ce9500f2908798d0b88078579b4965 commit 38037b3482ce9500f2908798d0b88078579b4965 Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Tue Oct 17 18:04:33 2017 Update docs after GoB/gerrit migration - Updated the canonical URL of the project. - Added reference to Boilerpipe. - Fixed links. - Misc updates. Bug: 749769 Change-Id: Ice4a4d6da89ddfb81cbd05d0c58ed02ce3b73969 Reviewed-on: https://chromium-review.googlesource.com/722263 Reviewed-by: Matthew Jones <mdjones@chromium.org> [modify] https://crrev.com/38037b3482ce9500f2908798d0b88078579b4965/README.md
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1f82a18d828e57e32082d04700c8e651d992976 commit f1f82a18d828e57e32082d04700c8e651d992976 Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Wed Dec 13 15:52:40 2017 Roll DOM Distiller JavaScript distribution package Diff since last roll: https://github.com/chromium/dom-distiller/compare/0bde3157d7...9596033e36 Picked up changes: 9596033 Skip elements with zero area when finding article element 38037b3 Update docs after GoB/gerrit migration Bug: 749769 ,791975 Change-Id: Id545cf658982204297fcbbcd0c8716fd4f272c28 Reviewed-on: https://chromium-review.googlesource.com/823287 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#523780} [modify] https://crrev.com/f1f82a18d828e57e32082d04700c8e651d992976/DEPS [modify] https://crrev.com/f1f82a18d828e57e32082d04700c8e651d992976/third_party/dom_distiller_js/README.chromium
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ad8e3411d765440af317eda4f5715d232b00317 commit 1ad8e3411d765440af317eda4f5715d232b00317 Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Mon Aug 13 19:41:09 2018 Amend dom-distiller script for bug ID and repo URLs - Amend bug ID handling: one space after colon (:). - Use GoB/gerrit URLs for diff and CL list. Bug: 749769 Change-Id: I7ea67512da418c54405fd7ffb81d3bc24f70b9db Reviewed-on: https://chromium-review.googlesource.com/1171846 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582669} [modify] https://crrev.com/1ad8e3411d765440af317eda4f5715d232b00317/third_party/dom_distiller_js/update_domdistiller_js.sh |
||
►
Sign in to add a comment |
||
Comment 1 by aga...@chromium.org
, Sep 27 2017