New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749748 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 602688



Sign in to add a comment

Support D3D11 video overlays with passthrough command buffer

Project Member Reported by jbau...@chromium.org, Jul 27 2017

Issue description

Here are the command that will need to be implemented:
ScheduleDCLayerCHROMIUM
SetEnableDCLayersCHROMIUM
SetDrawRectangleCHROMIUM
ScheduleDCLayerSharedStateCHROMIUM

Everything except for SetDrawRectangleCHROMIUM should mostly be plumbed through to the GLSurface and should work. SetDrawRectangleCHROMIUM will require a new GL extension to set a draw rectangle and offset.

For full performance we'll also need to ensure that deferred bind is supported for VP9 picture buffers - see https://codereview.chromium.org/2859723002/
 
Cc: kbr@chromium.org
Blocking: 602688
Owner: geoffl...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51a4c2172292e1a85e3fd6f33fb83ea8d2dd16b7

commit 51a4c2172292e1a85e3fd6f33fb83ea8d2dd16b7
Author: Geoff Lang <geofflang@chromium.org>
Date: Fri Jul 28 19:40:17 2017

Implement direct composition functions in the passthrough command buffer.

BUG= 749748 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2debd4a4a8fbed39e930d504f97068bc497358b3
Reviewed-on: https://chromium-review.googlesource.com/590697
Reviewed-by: John Bauman <jbauman@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490488}
[modify] https://crrev.com/51a4c2172292e1a85e3fd6f33fb83ea8d2dd16b7/gpu/command_buffer/service/gl_utils.h
[modify] https://crrev.com/51a4c2172292e1a85e3fd6f33fb83ea8d2dd16b7/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/51a4c2172292e1a85e3fd6f33fb83ea8d2dd16b7/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/51a4c2172292e1a85e3fd6f33fb83ea8d2dd16b7/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
[modify] https://crrev.com/51a4c2172292e1a85e3fd6f33fb83ea8d2dd16b7/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h
[modify] https://crrev.com/51a4c2172292e1a85e3fd6f33fb83ea8d2dd16b7/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
[modify] https://crrev.com/51a4c2172292e1a85e3fd6f33fb83ea8d2dd16b7/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc
[modify] https://crrev.com/51a4c2172292e1a85e3fd6f33fb83ea8d2dd16b7/gpu/command_buffer/service/texture_manager.cc
[modify] https://crrev.com/51a4c2172292e1a85e3fd6f33fb83ea8d2dd16b7/gpu/command_buffer/service/texture_manager.h
[modify] https://crrev.com/51a4c2172292e1a85e3fd6f33fb83ea8d2dd16b7/gpu/ipc/service/image_transport_surface_win.cc

Also required:

SetColorSpaceForScanoutCHROMIUM
Discussed with geofflang@ and it's not stale :-)
I believe without this there will be a power regression, so this feels like it should be higher than P3. Perhaps even launch blocking? 
Labels: -Pri-3 Pri-1
Yes, definitely higher priority.  Working on it this week.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49736ec2cac61eb9cf723c35dce4d374e0930544

commit 49736ec2cac61eb9cf723c35dce4d374e0930544
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Mar 15 14:27:24 2018

Support DC overlays for video in the passthrough command decoder.

BUG= 749748 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I65841d24748352db302da7e5890bcbb77dd581d2
Reviewed-on: https://chromium-review.googlesource.com/952216
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543364}
[modify] https://crrev.com/49736ec2cac61eb9cf723c35dce4d374e0930544/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/49736ec2cac61eb9cf723c35dce4d374e0930544/content/test/gpu/gpu_tests/pixel_test_pages.py
[modify] https://crrev.com/49736ec2cac61eb9cf723c35dce4d374e0930544/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/49736ec2cac61eb9cf723c35dce4d374e0930544/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
[modify] https://crrev.com/49736ec2cac61eb9cf723c35dce4d374e0930544/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h
[modify] https://crrev.com/49736ec2cac61eb9cf723c35dce4d374e0930544/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
[modify] https://crrev.com/49736ec2cac61eb9cf723c35dce4d374e0930544/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84c9e1939751868a4fc0f535cc5dabb2af55841f

commit 84c9e1939751868a4fc0f535cc5dabb2af55841f
Author: Geoff Lang <geofflang@chromium.org>
Date: Fri Mar 16 13:24:51 2018

Unsupress video tests after rebaseline.

TBR=zmo@chromium.org

BUG= 749748 

Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0d19ab8893767bf6752c3c67813e4d0354c5e5fe
Reviewed-on: https://chromium-review.googlesource.com/963070
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543681}
[modify] https://crrev.com/84c9e1939751868a4fc0f535cc5dabb2af55841f/content/test/gpu/gpu_tests/pixel_expectations.py

Status: Fixed (was: Assigned)

Sign in to add a comment