White line between url bar and content when using dark theme (mac) |
|||||||
Issue descriptionbug to track Mac work for issue 628312 Assigning to shrike@ for triage.
,
Jan 31 2018
Reproduces locally by navigating to `data:text/html,<body bgcolor="#000000">`. I'll have a look.
,
Jan 31 2018
Oops, that was actually a red herring: I had "Increase Contrast" enabled, which is supposed to draw a lot of the browser edges in white when using a dark theme. If I disable that setting, the behavior is as in the attached image. It looks right to me so I'm marking this WontFix.
,
Jan 31 2018
I think you don't understand, there is a white line appearing between the bottom of url bar and content, and above where the tabs are located. Let me show you what this issue is concerning, as it has already been patched on Windows. There are two photos attached showing the same theme on both windows and macOS. One is fully dark with no white line spacers (Windows) but the same theme on macOS has white lines. This is the issue. Please put this back on the to-fix list Here is the theme in question: https://chrome.google.com/webstore/detail/material-incognito-dark-t/ahifcnpnjgbadkjdhagpfjfkmlapfoel?hl=en-GB
,
Jan 31 2018
Oooh, okay, I did indeed misunderstand the bug report. Reopening!
,
Jan 31 2018
Before and after screenshots attached for <https://chromium-review.googlesource.com/c/chromium/src/+/895809>.
,
Jan 31 2018
Very nice! In the screenshots in my post above, it is also visible how a small white line is present on the upper side of the address bar as well (that comes into contact where the tabs are present). Could this be addressed as well?
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad47a6acc4904b57a69c518125ab6cf491515fdc commit ad47a6acc4904b57a69c518125ab6cf491515fdc Author: Elly Fong-Jones <ellyjones@google.com> Date: Wed Jan 31 19:35:41 2018 cocoa: use proper color for gradient view separators The separators should be drawn in COLOR_TOOLBAR_BOTTOM_SEPARATOR; this change was already made on the Views side in eba855f22deff3a00b76384582808925841f4be5. Screenshots are attached on the bug showing the effect of this change. Bug: 749732 Change-Id: Ie522f47d77dc492642e352d6b22b1d2d6776c0f0 Reviewed-on: https://chromium-review.googlesource.com/895809 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#533359} [modify] https://crrev.com/ad47a6acc4904b57a69c518125ab6cf491515fdc/chrome/browser/ui/cocoa/background_gradient_view.mm
,
Feb 1 2018
Checked the issue on latest canary 66.0.3336.0 using Mac 10.13.1 as per issue 628312 in comment#0. Observed the issue is still seen on latest canary i.e., a white line is seen on the address bar, Attaching the screen shot for reference. @ellyjones: Please check the attached screen shot and help us in confirming the fix. Thanks!
,
Feb 1 2018
#9: Yup, I did not (yet) fix the line above the address bar, only the one below it. This bug should stay open for now.
,
Feb 2 2018
I thought now would be a good time to mention some other light theme presence on dark themes on macOS that aren't present on windows. For example in the download bar there is a white gradient applied to buttons, which is also present on the CMD+F arrow keys. This gradient is not present on Windows as seen in the screenshots below. Could this be addressed as well?
,
Feb 2 2018
andrew.rogalsky@ Regarding the Downloads Bar: This will be fixed with the Material Design Downloads Bar. You can see the latest progress in Canary when you enable chrome://flags/#mac-md-download-shelf. Regarding the Find-In-Page Bar/buttons please open a new report and tell us the bug number. (Probably there is already a bug report for it, but I am not sure.) Thank you very much in advance.
,
Feb 2 2018
Update to #12: The MD Find-In-Page bug number is Issue 673589 .
,
Jul 6
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by shrike@chromium.org
, Jul 27 2017Owner: ----
Status: Available (was: Assigned)