New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749711 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

CCT signals for WebLite

Project Member Reported by mattcary@chromium.org, Jul 27 2017

Issue description

Add to the CCT API the following information:

timeOfMainResourceFetched for prefetch requests
time of first byte received (for CCT and prefetch)
HTTP response code for prefetch
Also, we are interested in getting the following signals from CCT (for original pages), and its prefetch requests (for weblite pages):
- Time of first byte received.
- HTTP response code for the prefetch requests (indicating whether the weblite page is good).

A design doc needs to be written to see how easy it is to get this information exposed.

 
It would be nice to add FP(first paint) signal as well.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05e0b725647baaf52102d6298954dda80da700f2

commit 05e0b725647baaf52102d6298954dda80da700f2
Author: Matthew Cary <mattcary@chromium.org>
Date: Fri Sep 15 09:19:34 2017

CCT: export load timing and network quality estimation.

Expose load timing and network quality estimation to a Custom Tabs
client via the AndroidPageLoadMetricsObserver.

Bug:  739612 , 749711 
Change-Id: Ic15600f0360d89b36e2bdd7277cc45c539294b6a
Reviewed-on: https://chromium-review.googlesource.com/601467
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502214}
[modify] https://crrev.com/05e0b725647baaf52102d6298954dda80da700f2/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/05e0b725647baaf52102d6298954dda80da700f2/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[modify] https://crrev.com/05e0b725647baaf52102d6298954dda80da700f2/chrome/android/java/src/org/chromium/chrome/browser/metrics/PageLoadMetrics.java
[modify] https://crrev.com/05e0b725647baaf52102d6298954dda80da700f2/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/05e0b725647baaf52102d6298954dda80da700f2/chrome/android/javatests/src/org/chromium/chrome/browser/metrics/PageLoadMetricsTest.java
[modify] https://crrev.com/05e0b725647baaf52102d6298954dda80da700f2/chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc
[modify] https://crrev.com/05e0b725647baaf52102d6298954dda80da700f2/chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.h
[add] https://crrev.com/05e0b725647baaf52102d6298954dda80da700f2/chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/05e0b725647baaf52102d6298954dda80da700f2/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.cc
[modify] https://crrev.com/05e0b725647baaf52102d6298954dda80da700f2/chrome/test/BUILD.gn

Cc: sbirch@chromium.org
Status: WontFix (was: Untriaged)
+sbirch

The prefetch response code is looking to be a little complicated. Some factors that will greatly affect the implementation is if is sufficient to ping back when the main resource is downloaded (in which case the existing signal we get at the end of the preload scanning is sufficient) or if we should report when dependent resources (css, etc) are downloaded as well.

Closing this bug until we have a concrete (reviewable) design from WebLite.

Sign in to add a comment