New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749707 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Eliminate GetBlockingPool in image_source.cc

Project Member Reported by steve...@chromium.org, Jul 27 2017

Issue description

Spreadsheet:
https://docs.google.com/spreadsheets/d/18x9PGMlfgWcBr4fDz2SEEtIwTpSjcBFT2Puib47ZF1w/edit#gid=0

Migration doc: https://chromium.googlesource.com/chromium/src/+/master/docs/task_scheduler_migration.md#


At first this looked like it may be complicated but it looks like we just need to replace GetSequencedTaskRunnerWithShutdownBehavior.

 
Cc: benhenry@chromium.org gab@chromium.org

Comment 2 by gab@chromium.org, Jul 27 2017

Yep that's indeed all there is to it. Initialize |task_runner_| via base::CreateSequencedTaskRunnerWithTraits(...).

Thanks!
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/868b3b89605d73cbbd45044a13d095ceae810899

commit 868b3b89605d73cbbd45044a13d095ceae810899
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jul 28 16:13:49 2017

Remove GetBlockingPool from image_source.cc

Bug=  749707 

Change-Id: I5c47046495c8e2e6fbb25b67ea70cfcd99d68f6a
Reviewed-on: https://chromium-review.googlesource.com/590072
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490417}
[modify] https://crrev.com/868b3b89605d73cbbd45044a13d095ceae810899/chrome/browser/ui/webui/chromeos/image_source.cc

Status: Fixed (was: Started)
Labels: M-62

Sign in to add a comment