[iOS] Should display underlying errors when sign-in fails |
|||||||||
Issue descriptionTo help Issue 749141 and Issue 621224 , we should display underlying errors when the sign-in fails.
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78f86382084b7dd9ecd922e000a4b4d44d10af69 commit 78f86382084b7dd9ecd922e000a4b4d44d10af69 Author: Jérôme Lebel <jlebel@chromium.org> Date: Fri Jul 28 11:33:39 2017 [iOS] Adding underlying errors information when displaying an error Error with description and one underlying error: https://drive.google.com/open?id=0ByXziH_JVCGJZkZzS2s2VEx2Z28 Error without description and with one underlying error: https://drive.google.com/open?id=0ByXziH_JVCGJdENIVUdxMEZjbDA Error without description and without underlying error: https://drive.google.com/open?id=0ByXziH_JVCGJZlZIZzBOYnl2dWs Bug: 749699 Change-Id: I6ec36d328b405d7a69835c9a45744c4519c336dc Reviewed-on: https://chromium-review.googlesource.com/589967 Reviewed-by: Benoit Zanotti <bzanotti@chromium.org> Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#490360} [modify] https://crrev.com/78f86382084b7dd9ecd922e000a4b4d44d10af69/ios/chrome/browser/ui/authentication/BUILD.gn [modify] https://crrev.com/78f86382084b7dd9ecd922e000a4b4d44d10af69/ios/chrome/browser/ui/authentication/authentication_ui_util.h [modify] https://crrev.com/78f86382084b7dd9ecd922e000a4b4d44d10af69/ios/chrome/browser/ui/authentication/authentication_ui_util.mm [add] https://crrev.com/78f86382084b7dd9ecd922e000a4b4d44d10af69/ios/chrome/browser/ui/authentication/authentication_ui_util_unittest.mm
,
Jul 28 2017
There is no way to test this fix unless the user get into the -206 error described in issue 749141 or issue 621224 .
,
Jul 28 2017
,
Jul 28 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 28 2017
,
Jul 28 2017
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d694b10a91304925b50eec5928f408a9cfdbc29 commit 9d694b10a91304925b50eec5928f408a9cfdbc29 Author: Jérôme Lebel <jlebel@chromium.org> Date: Fri Jul 28 20:00:11 2017 [iOS] Adding underlying errors information when displaying an error Error with description and one underlying error: https://drive.google.com/open?id=0ByXziH_JVCGJZkZzS2s2VEx2Z28 Error without description and with one underlying error: https://drive.google.com/open?id=0ByXziH_JVCGJdENIVUdxMEZjbDA Error without description and without underlying error: https://drive.google.com/open?id=0ByXziH_JVCGJZlZIZzBOYnl2dWs TBR=jlebel@chromium.org (cherry picked from commit 78f86382084b7dd9ecd922e000a4b4d44d10af69) Bug: 749699 Change-Id: I6ec36d328b405d7a69835c9a45744c4519c336dc Reviewed-on: https://chromium-review.googlesource.com/589967 Reviewed-by: Benoit Zanotti <bzanotti@chromium.org> Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#490360} Reviewed-on: https://chromium-review.googlesource.com/592030 Cr-Commit-Position: refs/branch-heads/3112@{#690} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/9d694b10a91304925b50eec5928f408a9cfdbc29/ios/chrome/browser/ui/authentication/BUILD.gn [modify] https://crrev.com/9d694b10a91304925b50eec5928f408a9cfdbc29/ios/chrome/browser/ui/authentication/authentication_ui_util.h [modify] https://crrev.com/9d694b10a91304925b50eec5928f408a9cfdbc29/ios/chrome/browser/ui/authentication/authentication_ui_util.mm [add] https://crrev.com/9d694b10a91304925b50eec5928f408a9cfdbc29/ios/chrome/browser/ui/authentication/authentication_ui_util_unittest.mm
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c32a3f2ae43f61f9d8c932869569ede763efe51b commit c32a3f2ae43f61f9d8c932869569ede763efe51b Author: Jérôme Lebel <jlebel@chromium.org> Date: Fri Jul 28 20:03:06 2017 [iOS] Adding underlying errors information when displaying an error Error with description and one underlying error: https://drive.google.com/open?id=0ByXziH_JVCGJZkZzS2s2VEx2Z28 Error without description and with one underlying error: https://drive.google.com/open?id=0ByXziH_JVCGJdENIVUdxMEZjbDA Error without description and without underlying error: https://drive.google.com/open?id=0ByXziH_JVCGJZlZIZzBOYnl2dWs TBR=jlebel@chromium.org (cherry picked from commit 78f86382084b7dd9ecd922e000a4b4d44d10af69) Bug: 749699 Change-Id: I6ec36d328b405d7a69835c9a45744c4519c336dc Reviewed-on: https://chromium-review.googlesource.com/589967 Reviewed-by: Benoit Zanotti <bzanotti@chromium.org> Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#490360} Reviewed-on: https://chromium-review.googlesource.com/592031 Cr-Commit-Position: refs/branch-heads/3163@{#111} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/c32a3f2ae43f61f9d8c932869569ede763efe51b/ios/chrome/browser/ui/authentication/BUILD.gn [modify] https://crrev.com/c32a3f2ae43f61f9d8c932869569ede763efe51b/ios/chrome/browser/ui/authentication/authentication_ui_util.h [modify] https://crrev.com/c32a3f2ae43f61f9d8c932869569ede763efe51b/ios/chrome/browser/ui/authentication/authentication_ui_util.mm [add] https://crrev.com/c32a3f2ae43f61f9d8c932869569ede763efe51b/ios/chrome/browser/ui/authentication/authentication_ui_util_unittest.mm
,
Sep 5 2017
Hi all, As a respin bug for M60, has the postmortem for this bug been drafted and shared? Thanks,
,
Sep 5 2017
,
Sep 11 2017
Friendly ping?
,
Sep 11 2017
I haven't write it yet.
,
Oct 2 2017
Hi there, Any update on the postmortem for this? As a respin bug for M60 postmortems are supposed to be written. Thanks,
,
Oct 10 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by jlebel@chromium.org
, Jul 27 2017