New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749683 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: Make app icon update on package update persistent.

Project Member Reported by khmel@chromium.org, Jul 27 2017

Issue description

In case of package update and potential app icon update we have to invalidate icons in persistence manner and support the case when package was updated offline, while ARC app mojo channel was not active.

Inner bug:
b/63839124
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa3584a9e36c7367e31ff8343efef81d58b7f94e

commit aa3584a9e36c7367e31ff8343efef81d58b7f94e
Author: khmel <khmel@google.com>
Date: Thu Jul 27 17:09:36 2017

arc: Make icon invalidation working with packages updated offline.

Before we had functionality that invalidated icon in the package app
list refresh. This worked well when update happened in runtime mode.
However, it could be the case when a package was updated offline (or
before ArcAppLauncher started) or in case package list updated was not
sent due to crash, for example. In last case icons for updated package
is left outdated. Reliable way is to check the package version. We have
a callback when the package is updated in runtime. Moreover, we sent
list of packages on each ARC container boot. So we have guaranteed
package updates. Once version code is changed then we invalidate
existing icons, and request icon update.

arc: Make icon update working with packages updated offline.

Test: Manually (together with fix on Android side ag/2572656) + for
      the runtime and offline update. Unit tests updated.
Bug:  749683 
Bug: b/63839124
TBR=xiyuan@chromium.org

Change-Id: I6e2223054a5429a8af4e3e0574fa2a4e7e4351ab
Reviewed-on: https://chromium-review.googlesource.com/580689
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489990}
[modify] https://crrev.com/aa3584a9e36c7367e31ff8343efef81d58b7f94e/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/aa3584a9e36c7367e31ff8343efef81d58b7f94e/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/aa3584a9e36c7367e31ff8343efef81d58b7f94e/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/aa3584a9e36c7367e31ff8343efef81d58b7f94e/components/arc/test/fake_app_instance.cc
[modify] https://crrev.com/aa3584a9e36c7367e31ff8343efef81d58b7f94e/components/arc/test/fake_app_instance.h

Comment 2 by khmel@chromium.org, Aug 2 2017

Cc: keta...@chromium.org
Labels: Merge-Request-61
Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 2 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f1e4604b98102db3b0846cd73b9895dbfedb55e

commit 2f1e4604b98102db3b0846cd73b9895dbfedb55e
Author: khmel <khmel@google.com>
Date: Wed Aug 02 22:36:38 2017

[Merge M61] arc: Make icon invalidation working with packages updated offline.

Before we had functionality that invalidated icon in the package app
list refresh. This worked well when update happened in runtime mode.
However, it could be the case when a package was updated offline (or
before ArcAppLauncher started) or in case package list updated was not
sent due to crash, for example. In last case icons for updated package
is left outdated. Reliable way is to check the package version. We have
a callback when the package is updated in runtime. Moreover, we sent
list of packages on each ARC container boot. So we have guaranteed
package updates. Once version code is changed then we invalidate
existing icons, and request icon update.

arc: Make icon update working with packages updated offline.

Test: Manually (together with fix on Android side ag/2572656) + for
      the runtime and offline update. Unit tests updated.
Bug:  749683 
Bug: b/63839124
TBR=khmel@google.com, lhchavez@chromium.org, xiyuan@chromium.org


(cherry picked from commit aa3584a9e36c7367e31ff8343efef81d58b7f94e)

Change-Id: I6e2223054a5429a8af4e3e0574fa2a4e7e4351ab
Reviewed-on: https://chromium-review.googlesource.com/580689
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489990}
Reviewed-on: https://chromium-review.googlesource.com/599024
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#248}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/2f1e4604b98102db3b0846cd73b9895dbfedb55e/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/2f1e4604b98102db3b0846cd73b9895dbfedb55e/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/2f1e4604b98102db3b0846cd73b9895dbfedb55e/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/2f1e4604b98102db3b0846cd73b9895dbfedb55e/components/arc/test/fake_app_instance.cc
[modify] https://crrev.com/2f1e4604b98102db3b0846cd73b9895dbfedb55e/components/arc/test/fake_app_instance.h

Comment 5 by khmel@chromium.org, Aug 2 2017

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment