arc: Make app icon update on package update persistent. |
||||||
Issue descriptionIn case of package update and potential app icon update we have to invalidate icons in persistence manner and support the case when package was updated offline, while ARC app mojo channel was not active. Inner bug: b/63839124
,
Aug 2 2017
,
Aug 2 2017
Approving merge to M61 Chrome OS.
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f1e4604b98102db3b0846cd73b9895dbfedb55e commit 2f1e4604b98102db3b0846cd73b9895dbfedb55e Author: khmel <khmel@google.com> Date: Wed Aug 02 22:36:38 2017 [Merge M61] arc: Make icon invalidation working with packages updated offline. Before we had functionality that invalidated icon in the package app list refresh. This worked well when update happened in runtime mode. However, it could be the case when a package was updated offline (or before ArcAppLauncher started) or in case package list updated was not sent due to crash, for example. In last case icons for updated package is left outdated. Reliable way is to check the package version. We have a callback when the package is updated in runtime. Moreover, we sent list of packages on each ARC container boot. So we have guaranteed package updates. Once version code is changed then we invalidate existing icons, and request icon update. arc: Make icon update working with packages updated offline. Test: Manually (together with fix on Android side ag/2572656) + for the runtime and offline update. Unit tests updated. Bug: 749683 Bug: b/63839124 TBR=khmel@google.com, lhchavez@chromium.org, xiyuan@chromium.org (cherry picked from commit aa3584a9e36c7367e31ff8343efef81d58b7f94e) Change-Id: I6e2223054a5429a8af4e3e0574fa2a4e7e4351ab Reviewed-on: https://chromium-review.googlesource.com/580689 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489990} Reviewed-on: https://chromium-review.googlesource.com/599024 Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#248} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/2f1e4604b98102db3b0846cd73b9895dbfedb55e/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc [modify] https://crrev.com/2f1e4604b98102db3b0846cd73b9895dbfedb55e/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h [modify] https://crrev.com/2f1e4604b98102db3b0846cd73b9895dbfedb55e/chrome/browser/ui/app_list/arc/arc_app_unittest.cc [modify] https://crrev.com/2f1e4604b98102db3b0846cd73b9895dbfedb55e/components/arc/test/fake_app_instance.cc [modify] https://crrev.com/2f1e4604b98102db3b0846cd73b9895dbfedb55e/components/arc/test/fake_app_instance.h
,
Aug 2 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jul 27 2017