New issue
Advanced search Search tips

Issue 749542 link

Starred by 1 user
Status: Fixed
Owner:
eugene...@chromium.org
Closed: Jan 11
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

IsFragmentChangeNavigationBetweenUrls does not catch removing fragment from a URL

Project Member Reported by danyao@chromium.org, Jul 27 2017 
NavigationManagerImpl::IsFragmentChangeNavigationBetweenUrls has always been implemented as the following:

if (existing_url == new_url || !new_url.has_ref())
    return false;

  return existing_url.EqualsIgnoringRef(new_url);

If existing_url = "http://google.com#foo" and new_url = "http://google.com", this method returns false but it should return true.
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 27

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by danyao@chromium.org, Jul 27

Status: Available (was: Untriaged)
This should still be fixed, but is still low priority.

Comment 3 by danyao@chromium.org, Jul 27

Labels: -Hotlist-Recharge-Cold

Comment 4 by eugene...@chromium.org, Jan 10

Owner: eugene...@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3c6980e6798e31899fb214f4be75f45b907733f

commit b3c6980e6798e31899fb214f4be75f45b907733f
Author: Eugene But <eugenebut@google.com>
Date: Fri Jan 11 23:12:47 2019

Remove WebStateObserver::NavigationItemCommitted.

This method is deprecated, and not used anymore. Hence can be safely
removed.

Bug:  749542 ,  781534 
Change-Id: Ia6b9e4cc263e30122ed26bc1df59a788ba18ac91
Reviewed-on: https://chromium-review.googlesource.com/c/1406084
Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622201}
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/BUILD.gn
[delete] https://crrev.com/341089f274d224f5355e466aa0304a4b4a8aefe0/ios/web/load_committed_details.cc
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/navigation/legacy_navigation_manager_impl.mm
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/navigation/navigation_manager_delegate.h
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/navigation/navigation_manager_impl.h
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/navigation/navigation_manager_impl.mm
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/navigation/navigation_manager_impl_unittest.mm
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/navigation/wk_based_navigation_manager_impl.mm
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/navigation/wk_based_navigation_manager_impl_unittest.mm
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/public/BUILD.gn
[delete] https://crrev.com/341089f274d224f5355e466aa0304a4b4a8aefe0/ios/web/public/load_committed_details.h
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/public/test/fakes/crw_test_web_state_observer.h
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/public/test/fakes/crw_test_web_state_observer.mm
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/public/test/fakes/test_web_state_observer.h
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/public/test/fakes/test_web_state_observer.mm
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/public/test/fakes/test_web_state_observer_util.h
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/public/web_state/web_state_observer.h
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/public/web_state/web_state_observer_bridge.h
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/test/fakes/fake_navigation_manager_delegate.h
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/test/fakes/fake_navigation_manager_delegate.mm
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/web_state/web_state_impl.h
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/web_state/web_state_impl.mm
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/web_state/web_state_impl_unittest.mm
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/web_state/web_state_observer.mm
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/web_state/web_state_observer_bridge.mm
[modify] https://crrev.com/b3c6980e6798e31899fb214f4be75f45b907733f/ios/web/web_state/web_state_observer_bridge_unittest.mm

Comment 6 by eugene...@chromium.org, Jan 11

Status: Fixed (was: Started)
►

Sign in to add a comment