New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749534 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 730832



Sign in to add a comment

file links do not pin a revision

Project Member Reported by no...@chromium.org, Jul 27 2017

Issue description

repro:
1. go to https://luci-config.appspot.com/#/services/cast-swarming
2. click "bots.cfg"

expected:
the file URL has a commit hash
https://chrome-internal.googlesource.com/infradata/config/+/c6c96ae/configs/cast-swarming/bots.cfg

actual:
branch is used instead of commit hash
https://chrome-internal.googlesource.com/infradata/config/+/master/configs/cast-swarming/bots.cfg

the revision must be the currently imported (and accepted) revision of the config set
 

Comment 1 by cwpayton@google.com, Jul 27 2017

Owner: cwpayton@google.com
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/5925b54b4ff3522c85710eda81d4305074663fef

commit 5925b54b4ff3522c85710eda81d4305074663fef
Author: cwpayton <cwpayton@google.com>
Date: Thu Jul 27 23:17:29 2017

config_service: Changed file links to point to latest revision instead of master

Config service now uses information from latest accepted revision to direct user
to the correct link

BUG= 749534 

Review-Url: https://codereview.chromium.org/2985223002

[modify] https://crrev.com/5925b54b4ff3522c85710eda81d4305074663fef/appengine/config_service/ui/src/config-ui/config-set.html
[modify] https://crrev.com/5925b54b4ff3522c85710eda81d4305074663fef/appengine/config_service/ui/test/config-ui/config-set_test.html

Status: Fixed (was: Started)

Sign in to add a comment