New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 749533 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 730832



Sign in to add a comment

config: hard to determine type of config set

Project Member Reported by no...@chromium.org, Jul 27 2017

Issue description

on https://luci-config.appspot.com/#/, all cards have titles that don't indicate type of config set: service, project or ref. It makes user to read the Path in the card to understand that.

Please make it easier to visually determine the type of config set.

Consider putting an image specifying the type
 
Owner: ayanaadylova@google.com
Status: Started (was: Untriaged)
We don't have good images for projects vs. services, and I'd rather not start centithreads on designing them at this stage :-)

Instead, how about adding a subtle background color to the card, say, pale blue for services and pale yellow for projects? WDYT?

Comment 3 by no...@chromium.org, Jul 27 2017

color does not say much unless you memorize it. How about simply displaying full config set name, e.g. projects/chromium
?

another example that is especially concerning that both project and ref config set are displayed the same. Why do we strip "/refs/heads/master" suffix? There may be other refs/heads/<name> suffixes.
I changed config set cards to display full config set name. Cameron will also add revision number and time stamp underneath config-set names.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/d3bd7823b4fe248ccc7e513c1039b36e00d20dad

commit d3bd7823b4fe248ccc7e513c1039b36e00d20dad
Author: ayanaadylova <ayanaadylova@google.com>
Date: Thu Jul 27 22:36:19 2017

config_service: include type of config to the config-set card

Included type of config service to make it easier to visually determine the type of config set.

BUG= 749533 

Review-Url: https://codereview.chromium.org/2989833002

[modify] https://crrev.com/d3bd7823b4fe248ccc7e513c1039b36e00d20dad/appengine/config_service/ui/src/config-ui/config-set-card.html
[modify] https://crrev.com/d3bd7823b4fe248ccc7e513c1039b36e00d20dad/appengine/config_service/ui/test/config-ui/config-set_test.html

Status: Fixed (was: Started)
re: #c3: I tend to disagree - a color would give a hint that there are different config types, and it won't take long for the user to realize its meaning if we keep the "Project" or "Service" label.

And later we can add an icon with the same color hue for an even better visual identification (but that'll take longer than we have time for).
It just makes config-set cards smaller if we display only full config set name. After Cameron will commit his changes, config-set card will only contain full path, revision number and time stamp. Otherwise it would contain name, type, full path, revision number and time stamp.

Comment 9 by no...@chromium.org, Jul 28 2017

if there were only projects and services, a color would be fine, but what about ref configs? Before c#5, if I searched for chromium, I saw two cards with the same title "chromium". One was a project config set, another was a ref config set and it was hard to tell them apart.

Comment 10 by no...@chromium.org, Jul 28 2017

I appreciate that now it config sets look more cluttered than before.

Let's color the non-essential parts of config set (i.e. "projects/", "services/" and "/refs/heads/") with a lighter color (i.e. gray) on all pages. I've filed bug 750012 for that

Comment 11 by no...@chromium.org, Jul 28 2017

Status: Verified (was: Fixed)

Sign in to add a comment