New issue
Advanced search Search tips

Issue 749514 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 728227



Sign in to add a comment

Expose SerialDeviceEnumerator interface from Device Service

Project Member Reported by leon....@intel.com, Jul 27 2017

Issue description

interface SerialDeviceEnumerator {
  GetDevices() => (array<device.mojom.DeviceInfo> devices);
}


Based on SerialDeviceEnumerator in //device/serial/, implement mojo interface SerialDeviceEnumerator inside Device Service.

Change users in //extensions/browser/api/serial to consume above interface.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c

commit ed3913b74990ef2ec3b30b4d9595a42e957eeb9c
Author: Han Leon <leon.han@intel.com>
Date: Fri Aug 04 04:57:37 2017

[DeviceService] Expose SerialDeviceEnumerator interface from Device Service

This CL is part of servicification work for //device/serial, it:
 - creates a new mojo interface SerialDeviceEnumerator and exposes it
   from Device Service, the interface implementation wraps
   a device::SerialDeviceEnumerator to do actual work.
 - lets serial extension API impls consume the above interface instead
   of directly calling functions of device::SerialDeviceEnumerator.

BUG= 749514 
TEST=browser_tests SerialApiTest.*

Change-Id: Ib768bb25032fcc4a0899780a2f85467f128a6800
Reviewed-on: https://chromium-review.googlesource.com/586632
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#491942}
[modify] https://crrev.com/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c/chrome/test/data/extensions/api_test/serial/real_hardware/background.js
[add] https://crrev.com/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c/chrome/test/data/extensions/api_test/serial/real_hardware_fail/background.js
[add] https://crrev.com/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c/chrome/test/data/extensions/api_test/serial/real_hardware_fail/manifest.json
[modify] https://crrev.com/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c/device/serial/BUILD.gn
[modify] https://crrev.com/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c/extensions/browser/api/serial/BUILD.gn
[modify] https://crrev.com/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c/extensions/browser/api/serial/serial_api.cc
[modify] https://crrev.com/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c/extensions/browser/api/serial/serial_api.h
[modify] https://crrev.com/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c/extensions/browser/api/serial/serial_apitest.cc
[modify] https://crrev.com/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c/services/device/BUILD.gn
[modify] https://crrev.com/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c/services/device/device_service.cc
[modify] https://crrev.com/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c/services/device/device_service.h
[modify] https://crrev.com/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c/services/device/manifest.json
[modify] https://crrev.com/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c/services/device/public/interfaces/BUILD.gn
[add] https://crrev.com/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c/services/device/public/interfaces/serial.mojom
[add] https://crrev.com/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c/services/device/serial/BUILD.gn
[add] https://crrev.com/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c/services/device/serial/DEPS
[add] https://crrev.com/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c/services/device/serial/serial_device_enumerator_impl.cc
[add] https://crrev.com/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c/services/device/serial/serial_device_enumerator_impl.h
[add] https://crrev.com/ed3913b74990ef2ec3b30b4d9595a42e957eeb9c/services/device/serial/serial_device_enumerator_impl_unittest.cc

Comment 2 by leon....@intel.com, Aug 4 2017

Status: Fixed (was: Started)
Components: Internals>Services>Device

Sign in to add a comment