New issue
Advanced search Search tips

Issue 749492 link

Starred by 4 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 651762



Sign in to add a comment

javascript URL link cannot use target

Project Member Reported by annevank...@gmail.com, Jul 27 2017

Issue description

While writing tests for https://github.com/whatwg/html/issues/1129 I found that the target attribute is not used for javascript URLs in links.
 

Comment 1 by tkent@chromium.org, Jul 28 2017

Components: Blink>Loader
Status: Available (was: Unconfirmed)
Confirmed with 62 canary.

Comment 2 by tkent@chromium.org, Jul 31 2017

Blocking: 651762
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe5b761ee1a25c3ed6ce66447507986f8a4f609f

commit fe5b761ee1a25c3ed6ce66447507986f8a4f609f
Author: Kent Tamura <tkent@chromium.org>
Date: Mon Jul 31 06:43:10 2017

Import some skipped tests in wpt/html/browsers/browsing-the-web/navigating-across-documents/.

We'd like to fix the root cause of these failing tests. They are still skipped
because we know they will time out.

This CL has no behavior changes.

NOEXPORT=true
TBR=kochi@chromium.org

Bug: 749492
Change-Id: I4431045838e7ba1252db3a35ca3364fd6cb5e6e9
Reviewed-on: https://chromium-review.googlesource.com/593379
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490720}
[modify] https://crrev.com/fe5b761ee1a25c3ed6ce66447507986f8a4f609f/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/fe5b761ee1a25c3ed6ce66447507986f8a4f609f/third_party/WebKit/LayoutTests/W3CImportExpectations
[add] https://crrev.com/fe5b761ee1a25c3ed6ce66447507986f8a4f609f/third_party/WebKit/LayoutTests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/008.html
[add] https://crrev.com/fe5b761ee1a25c3ed6ce66447507986f8a4f609f/third_party/WebKit/LayoutTests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/009.html
[add] https://crrev.com/fe5b761ee1a25c3ed6ce66447507986f8a4f609f/third_party/WebKit/LayoutTests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/010.html

Comment 4 by tkent@chromium.org, Aug 1 2017

We need to check usage of the following functions:
- WebLocalFrmameImpl::LoadJavaScriptURL
- ScriptController::ExecuteScriptIfJavaScriptURL

For example, an instance in HTMLFormElement::ScheduleFormSubmission() is obviously wrong. It ignores |target_frame| computed in the function.

Comment 5 by tkent@chromium.org, Aug 1 2017

As for <a href>, it's a bug of FrameLoader::Load(). Probably, PrepareRequestForThisFrame() should be later than |target_frame != frame_| check.

Comment 6 by tkent@chromium.org, Aug 1 2017

Components: -Blink>HTML>A Blink>Forms>Submission

Comment 7 by tkent@chromium.org, Aug 10 2017

Related spec is here: https://html.spec.whatwg.org/multipage/browsing-the-web.html#navigating-across-documents:javascript-protocol

If I understand https://github.com/whatwg/html/issues/2591 correctly, we need to evaluate the JavaScript code synchronously though the specification ask to evaluate it in a task in order to avoid to evaluate it on a document different from the original source document.


 Issue 773468  has been merged into this issue.
From the duplicate:

> Note that this is causing interop issues.  We ran into this because https://uptownbigband.ch/ assumed the spec-violating behavior Chrome has and didn't bother to test in other browsers.

Please up the priority of fixing this.
Project Member

Comment 10 by sheriffbot@chromium.org, Oct 11

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)

Sign in to add a comment